Please do not commit common third party libraries like _zlib_, which is already shipped by all major GNU+Linux distributions. See also https://wiki.debian.org/UpstreamGuide specifically "No inclusion of third party code" section (but not limited to). Thanks.

RElesgoe commented

2021-09-16 19:45:25 -06:00

(Migrated from github.com)

Please do not commit common third party libraries like zlib, which is already shipped by all major GNU+Linux distributions.

See also https://wiki.debian.org/UpstreamGuide specifically "No inclusion of third party code" section (but not limited to). Thanks.

These libraries were committed to facilitate easier compilation on Windows platforms where easy to use package managers do not exist.

Though, now that I'm checking the CMake code, I see that the condition for including the committed zlib is not guarded by the WIN32 variable (https://github.com/pvpgn/pvpgn-server/blob/develop/ConfigureChecks.cmake#L52-L55). This will need to be changed before merging this pull request.

> Please do not commit common third party libraries like _zlib_, which is already shipped by all major GNU+Linux distributions. > > See also https://wiki.debian.org/UpstreamGuide specifically "No inclusion of third party code" section (but not limited to). Thanks. These libraries were committed to facilitate easier compilation on Windows platforms where easy to use package managers do not exist. Though, now that I'm checking the CMake code, I see that the condition for including the committed zlib is not guarded by the `WIN32` variable (https://github.com/pvpgn/pvpgn-server/blob/develop/ConfigureChecks.cmake#L52-L55). This will need to be changed before merging this pull request.

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin develop:develop

git checkout develop

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout master

git merge --no-ff develop

git checkout develop

git rebase master

git checkout master

git merge --ff-only develop

git checkout develop

git rebase master

git checkout master

git merge --no-ff develop

git checkout master

git merge --squash develop