Techwizz/pvpgn-server
1
0
Fork 0
Code Issues68 Pull requests2 Projects Releases8 Packages Wiki Activity Actions

Overhaul versioncheck system #340

Merged
RElesgoe merged 14 commits from develop into master 2018-04-28 18:23:10 -06:00
Conversation 3 Commits 14 Files changed 23 +6591 -5090
RElesgoe commented 2018-02-10 04:10:39 -07:00 (Migrated from github.com)
  • Use JSON format for configuration file (, )
  • Currently won't accept a few versioncheck entries (), I'd like someone to check the hash for WC2 2.01 before I'll merge this pull request
  • version_exeinfo_match in bnetd.conf must be set to true or false now
  • Needs additional testing before merge
  • Need to replace usage of std::forward_list with another container
  • Need to create a document in the docs/ directory detailing how the file should be formatted
- Use JSON format for configuration file (#181, #336) - Currently won't accept a few versioncheck entries (#328), I'd like someone to check the hash for WC2 2.01 before I'll merge this pull request - ````version_exeinfo_match```` in ````bnetd.conf```` must be set to ````true```` or ````false```` now - Needs additional testing before merge - Need to replace usage of ````std::forward_list```` with another container - Need to create a document in the docs/ directory detailing how the file should be formatted
👍 1
RElesgoe commented 2018-02-11 16:41:10 -07:00 (Migrated from github.com)

Known problem (critical): Unable to properly select the correct versioncheck entry based on the computer architecture, client, and version byte. Possible solution: https://github.com/pvpgn/pvpgn-server/issues/336#issuecomment-364817526

Known problem (critical): Unable to properly select the correct versioncheck entry based on the computer architecture, client, and version byte. Possible solution: https://github.com/pvpgn/pvpgn-server/issues/336#issuecomment-364817526
RElesgoe commented 2018-03-28 03:23:06 -06:00 (Migrated from github.com)

@HarpyWar Can you revert the commit, it isn't correct to add this to a pull request.

@HarpyWar Can you revert the commit, it isn't correct to add this to a pull request.
HarpyWar commented 2018-03-28 03:46:09 -06:00 (Migrated from github.com)

I didn't choose it.
We can do nothing with it, because it's very small change. Just don't add new commits which are not related to this PR into develop untill the PR will not be closed. And for next new PR and features use separate branches as it described on https://github.com/pvpgn/pvpgn-server/issues/337

I didn't choose it. We can do nothing with it, because it's very small change. Just don't add new commits which are not related to this PR into `develop` untill the PR will not be closed. And for next new PR and features use separate branches as it described on https://github.com/pvpgn/pvpgn-server/issues/337
Sign in to join this conversation.
No reviewers
No labels
bug
duplicate
enhancement
help wanted
in progress...
information
invalid
not enough info
priority high
priority low
priority normal
question
request
research
wontfix
No milestone
1.99.7.2
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Techwizz/pvpgn-server#340
No description provided.
Delete branch "develop"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?