Techwizz/pvpgn-server
1
0
Fork 0
Code Issues 68 Pull requests 2 Projects Releases 8 Packages Wiki Activity Actions

versioncheck.conf to json #336

New issue
Closed
opened 2018-01-28 17:07:26 -07:00 by xpeh-owns · 21 comments
xpeh-owns commented 2018-01-28 17:07:26 -07:00 (Migrated from github.com)

First results: https://gist.github.com/xpeh-owns/881f040050dd4a4c89cbd34831eccd11

  • Order of appearence? Currently it's 'WAR3', 'W3XP', 'STAR', 'SEXP', 'W2BN', 'DRTL', 'D2XP', 'D2DV'. Newer versions are below, opposite to .conf
  • Key names/order?

You will add newer versions manually, right?

First results: https://gist.github.com/xpeh-owns/881f040050dd4a4c89cbd34831eccd11 - Order of appearence? Currently it's 'WAR3', 'W3XP', 'STAR', 'SEXP', 'W2BN', 'DRTL', 'D2XP', 'D2DV'. Newer versions are below, opposite to .conf - Key names/order? You will add newer versions manually, right?
RElesgoe commented 2018-01-28 17:19:06 -07:00 (Migrated from github.com)

W2BN should be next to W3XP. Can you reverse the order so that the newest versions are at the top instead of oldest.

W2BN should be next to W3XP. Can you reverse the order so that the newest versions are at the top instead of oldest.
xpeh-owns commented 2018-01-28 17:20:02 -07:00 (Migrated from github.com)

Can you reverse the order so that the newest versions are at the top instead of oldest.

But why?
Your proposition of tag order?

> Can you reverse the order so that the newest versions are at the top instead of oldest. But why? Your proposition of tag order?
RElesgoe commented 2018-01-28 17:23:36 -07:00 (Migrated from github.com)

It's quicker to manually insert new entries at the top.

Since WarCraft 2 and WarCraft 3 are the same series, they should be next to each other.

It's quicker to manually insert new entries at the top. Since WarCraft 2 and WarCraft 3 are the same series, they should be next to each other.
xpeh-owns commented 2018-01-28 17:25:52 -07:00 (Migrated from github.com)

It's quicker to manually insert new entries at the top.

If you mean...
So please the whole clienttag order.

> It's quicker to manually insert new entries at the top. If you mean... So please the whole clienttag order.
RElesgoe commented 2018-01-28 17:30:20 -07:00 (Migrated from github.com)

What I mean is that the objects in each array should be sorted so that the newest versions are at the top (e.g. 1.16.1 at the top for STAR and SEXP).
The order of clients should be WAR3, W3XP, W2BN, STAR, SEXP, DRTL, D2XP, D2DV.

What I mean is that the objects in each array should be sorted so that the newest versions are at the top (e.g. 1.16.1 at the top for STAR and SEXP). The order of clients should be WAR3, W3XP, W2BN, STAR, SEXP, DRTL, D2XP, D2DV.
xpeh-owns commented 2018-01-28 17:31:19 -07:00 (Migrated from github.com)

What I mean is that the objects in each array should be sorted so that the newest versions are at the top (e.g. 1.16.1 at the top for STAR and SEXP).

Yes, I've got it.

> What I mean is that the objects in each array should be sorted so that the newest versions are at the top (e.g. 1.16.1 at the top for STAR and SEXP). Yes, I've got it.
xpeh-owns commented 2018-01-28 17:35:35 -07:00 (Migrated from github.com)

https://gist.github.com/xpeh-owns/1d76c897891f9538a63814a55d2ddc12
Need converter from json to conf?

https://gist.github.com/xpeh-owns/1d76c897891f9538a63814a55d2ddc12 Need converter from json to conf?
xpeh-owns commented 2018-01-28 17:37:26 -07:00 (Migrated from github.com)

War 2 and 3 are the same series but war2 is never updated, opposite to star/sexp

War 2 and 3 are the same series but war2 is never updated, opposite to star/sexp
xpeh-owns commented 2018-01-28 17:43:25 -07:00 (Migrated from github.com)

https://gist.github.com/xpeh-owns/3d13e9d504408e0e41f10c7bc98e8583

https://gist.github.com/xpeh-owns/3d13e9d504408e0e41f10c7bc98e8583
xpeh-owns commented 2018-01-28 19:03:51 -07:00 (Migrated from github.com)

Why is there no Mac versions? I've got versioncheck from your rep.

Why is there no Mac versions? I've got versioncheck from your rep.
RElesgoe commented 2018-01-28 19:04:43 -07:00 (Migrated from github.com)

People never submitted versioncheck entries for Mac clients.

People never submitted versioncheck entries for Mac clients.
xpeh-owns commented 2018-01-28 19:07:04 -07:00 (Migrated from github.com)

Surely they exist somewhere, probably even on harpywar forum.
So do you need json-conf converter? Even if you use json in your server original pvpgn still can't do it.

Surely they exist somewhere, probably even on harpywar forum. So do you need json-conf converter? Even if you use json in your server original pvpgn still can't do it.
RElesgoe commented 2018-01-28 19:08:36 -07:00 (Migrated from github.com)

A converter script would be nice, it could be placed in the scripts directory in this repository. Just make a pull request for it.

A converter script would be nice, it could be placed in the scripts directory in this repository. Just make a pull request for it.
xpeh-owns commented 2018-01-28 19:11:31 -07:00 (Migrated from github.com)

I already made one :) This json is produced with a script with no edits after.

I already made one :) This json is produced with a script with no edits after.
xpeh-owns commented 2018-01-28 19:15:05 -07:00 (Migrated from github.com)

So how to upload them? Never had worked with git and github :)

So how to upload them? Never had worked with git and github :)
RElesgoe commented 2018-01-28 19:31:39 -07:00 (Migrated from github.com)

Just make another Gist and I'll upload it.

Just make another Gist and I'll upload it.
xpeh-owns commented 2018-01-28 19:32:46 -07:00 (Migrated from github.com)

I'll probably have to commit something else in the future. Would be better if I commit.

I'll probably have to commit something else in the future. Would be better if I commit.
RElesgoe commented 2018-02-05 12:48:38 -07:00 (Migrated from github.com)

Can you modify your script to output tabs instead of spaces.
Before "WAR3": [ should be a single tab. Before { should be 2 tabs. Before "title", "architecture", etc. should be 3 tabs.

Can you modify your script to output tabs instead of spaces. Before ````"WAR3": [```` should be a single tab. Before ````{```` should be 2 tabs. Before ````"title"````, ````"architecture"````, etc. should be 3 tabs.
RElesgoe commented 2018-02-11 19:48:29 -07:00 (Migrated from github.com)

@xpeh-owns I need the file to be modified like so:

{  
    "WAR3":{  
        "0x1c":{  
            "checkrevision_file":"ver-IX86-1.mpq",
            "equation":"A=1239576727 C=1604096186 B=4198521212 4 A=A+S B=B-C C=C^A A=A+B",
            "entries":[  
                {  
                    "title":"Warcraft III - ROC 1.28.2.",
                    "architecture":"IX86",
                    "version":"1.28.2.227",
                    "hash":"0x2dc96bf5",
                    "file_metadata":"War3.exe 05/20/17 13:25:29 558568",
                    "versiontag":"WAR3_1282"
                },
                {  
                    "title":"Warcraft III - ROC 1.28.1.",
                    "architecture":"IX86",
                    "version":"1.28.1.197",
                    "hash":"0x1fbde0fd",
                    "file_metadata":"War3.exe 04/17/17 12:06:57 536040",
                    "versiontag":"WAR3_1281"
                },
                {  
                    "title":"Warcraft III - ROC 1.28",
                    "architecture":"IX86",
                    "version":"1.28.0.37",
                    "hash":"0xe00c3096",
                    "file_metadata":"War3.exe 04/17/17 12:06:57 536040",
                    "versiontag":"WAR3_128"
                }
            ]
        },
        "0x1b":{  
            "checkrevision_file":"ver-IX86-1.mpq",
            "equation":"B=454282227 C=2370009462 A=2264812340 4 A=A^S B=B-C C=C-A A=A+B",
            "entries":[  
                {  
                    "title":"Warcraft III - ROC 1.27b",
                    "architecture":"IX86",
                    "version":"1.27.1.173",
                    "hash":"0x4026b5b0",
                    "file_metadata":"War3.exe 12/09/16 06:05:09 515048",
                    "versiontag":"WAR3_127B"
                }
            ]
        }
    }
}
@xpeh-owns I need the file to be modified like so: ```` { "WAR3":{ "0x1c":{ "checkrevision_file":"ver-IX86-1.mpq", "equation":"A=1239576727 C=1604096186 B=4198521212 4 A=A+S B=B-C C=C^A A=A+B", "entries":[ { "title":"Warcraft III - ROC 1.28.2.", "architecture":"IX86", "version":"1.28.2.227", "hash":"0x2dc96bf5", "file_metadata":"War3.exe 05/20/17 13:25:29 558568", "versiontag":"WAR3_1282" }, { "title":"Warcraft III - ROC 1.28.1.", "architecture":"IX86", "version":"1.28.1.197", "hash":"0x1fbde0fd", "file_metadata":"War3.exe 04/17/17 12:06:57 536040", "versiontag":"WAR3_1281" }, { "title":"Warcraft III - ROC 1.28", "architecture":"IX86", "version":"1.28.0.37", "hash":"0xe00c3096", "file_metadata":"War3.exe 04/17/17 12:06:57 536040", "versiontag":"WAR3_128" } ] }, "0x1b":{ "checkrevision_file":"ver-IX86-1.mpq", "equation":"B=454282227 C=2370009462 A=2264812340 4 A=A^S B=B-C C=C-A A=A+B", "entries":[ { "title":"Warcraft III - ROC 1.27b", "architecture":"IX86", "version":"1.27.1.173", "hash":"0x4026b5b0", "file_metadata":"War3.exe 12/09/16 06:05:09 515048", "versiontag":"WAR3_127B" } ] } } } ````
RElesgoe commented 2018-02-20 11:51:58 -07:00 (Migrated from github.com)

New format:

{  
    "WAR3":{  
		"IX86":{  
			"0x1c":{  
				"checkrevision_file":"ver-IX86-1.mpq",
				"equation":"A=1239576727 C=1604096186 B=4198521212 4 A=A+S B=B-C C=C^A A=A+B",
				"entries":[  
					{  
						"title":"Warcraft III - ROC 1.28.2.",
						"version":"1.28.2.227",
						"hash":"0x2dc96bf5",
						"file_metadata":"War3.exe 05/20/17 13:25:29 558568",
						"versiontag":"WAR3_1282"
					},
					{
						"title":"Warcraft III - ROC 1.28.1.",
						"version":"1.28.1.197",
						"hash":"0x1fbde0fd",
						"file_metadata":"War3.exe 04/17/17 12:06:57 536040",
						"versiontag":"WAR3_1281"
					},
					{  
						"title":"Warcraft III - ROC 1.28",
						"version":"1.28.0.37",
						"hash":"0xe00c3096",
						"file_metadata":"War3.exe 04/17/17 12:06:57 536040",
						"versiontag":"WAR3_128"
					}
				]
			},
			"0x1b":{  
				"checkrevision_file":"ver-IX86-1.mpq",
				"equation":"B=454282227 C=2370009462 A=2264812340 4 A=A^S B=B-C C=C-A A=A+B",
				"entries":[  
					{  
						"title":"Warcraft III - ROC 1.27b",
						"version":"1.27.1.173",
						"hash":"0x4026b5b0",
						"file_metadata":"War3.exe 12/09/16 06:05:09 515048",
						"versiontag":"WAR3_127B"
					}
				]
			}
		},
		"XMAC":{
		}
    }
}

I considered moving checkrevision_file and equation under the architecture objects, but it would be too time consuming to go back and update every entry.

New format: ```` { "WAR3":{ "IX86":{ "0x1c":{ "checkrevision_file":"ver-IX86-1.mpq", "equation":"A=1239576727 C=1604096186 B=4198521212 4 A=A+S B=B-C C=C^A A=A+B", "entries":[ { "title":"Warcraft III - ROC 1.28.2.", "version":"1.28.2.227", "hash":"0x2dc96bf5", "file_metadata":"War3.exe 05/20/17 13:25:29 558568", "versiontag":"WAR3_1282" }, { "title":"Warcraft III - ROC 1.28.1.", "version":"1.28.1.197", "hash":"0x1fbde0fd", "file_metadata":"War3.exe 04/17/17 12:06:57 536040", "versiontag":"WAR3_1281" }, { "title":"Warcraft III - ROC 1.28", "version":"1.28.0.37", "hash":"0xe00c3096", "file_metadata":"War3.exe 04/17/17 12:06:57 536040", "versiontag":"WAR3_128" } ] }, "0x1b":{ "checkrevision_file":"ver-IX86-1.mpq", "equation":"B=454282227 C=2370009462 A=2264812340 4 A=A^S B=B-C C=C-A A=A+B", "entries":[ { "title":"Warcraft III - ROC 1.27b", "version":"1.27.1.173", "hash":"0x4026b5b0", "file_metadata":"War3.exe 12/09/16 06:05:09 515048", "versiontag":"WAR3_127B" } ] } }, "XMAC":{ } } } ```` I considered moving `checkrevision_file` and `equation` under the architecture objects, but it would be too time consuming to go back and update every entry.
RElesgoe commented 2018-04-28 18:26:53 -06:00 (Migrated from github.com)

74b06d022b

74b06d022b0b61538590e8c30ec20830ebdd3c5c
Sign in to join this conversation.
No labels
bug
duplicate
enhancement
help wanted
in progress...
information
invalid
not enough info
priority high
priority low
priority normal
question
request
research
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: Techwizz/pvpgn-server#336
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?