Code cleanup in:
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git
Findings were:
do not use C99 // comments
space required after that close brace '}'
line over 80 characters
Signed-off-by: Andres More <more.andres@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This is a patch to the ieee80211_crypt.h file that fixed up a space
Errors found by the checkpatch.pl tools
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This is a patch to the ieee80211.h file that fixed up a brace, comments
and space Errors found by the checkpatch.pl tools.
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This is a patch to the dot11d.h file that fixed up a comments and space
Errors found by the checkpatch.pl tools
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This is a patch to the serqt_usb2.c files that fixed space error and
warning found by the checkpatch.pl tools.
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: John Church <j.church@ymail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Toggling the link carrier is a non sense and is the grossest locking I can
think of. Moreover, it's giving a completely inaccurate status to userspace
who could for example decide to turn the interface down on carrier off
detection.
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
If we're not associated, we should not send wireless events to let userspace
know that we just left an ESSID, simply because we havent yet joined it.
If we keep on doing that, wpa_supplicant could receive such events while
actually trying to join an ESSID, and thus decide to stop trying. This leads
to a lot of connection failures as this driver seems to be sending GIWAP
events quite a lot.
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Getting a probe response after sending a probe request to a specific SSID
doesnt mean we're trying to associate with this SSID.
wpa_supplicant should be the only one deciding when to join an SSID, not the
kernel.
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This is a patch to the ioctl.c file that fixes up a brace warning found
by the checkpatch.pl tool
Signed-off-by: Ng Kian Yong <ngky@comp.nus.edu.sg>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This cleans up udlfb a tiny bit.
Signed-off-by: Pavel Machek <pavel@ucw.cz>
Cc: Bernie Thompson <bernie@plugable.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This is a patch to the r8180_rtl8225z2.c file that fixes up errors and
warnings found by the checkpatch.pl tool
Signed-off-by: Olimpiu Pascariu <olimpiu.pascariu@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This is a patch to the file quatech_usb2.c that fixes two space before
tabular and one line of more than 80 characters warnings found by
checkpatch.pl
Signed-off-by: Soeren Moeller <soerenmoeller2001@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Fixed almost all the issues given by checkpatch.pl except for one
warning about an 81 character line, which cannot really be decomposed
(the code is a bit too nested there).
Signed-off-by: Daniel Kenji Toyama <kenji.toyama@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Fixed some indentation and spacing issues.
Signed-off-by: Daniel Kenji Toyama <kenji.toyama@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Replaced lots of spaces by real tabs and resolved other minor issues.
Signed-off-by: Daniel Kenji Toyama <kenji.toyama@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Replaced lots of spaces by real tabs and fixed some 80+ lines.
Signed-off-by: Daniel Kenji Toyama <kenji.toyama@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Replaced all indentation by spaces by tabs.
Signed-off-by: Daniel Kenji Toyama <kenji.toyama@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This is a patch to control.h that presents certain inline comments in a
neater way, and which eliminates the 80 character error found by the
checkpatch.pl tool.
Signed-off-by: Johan Meiring <johanmeiring@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
vme_calc_slot() is not used anywhere other than vme.c so it should be
declared as static.
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Martyn Welch <martyn.welch@ge.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
variable check_reset_cnt in rtl819x_watchdog_wqcallback is now static
again.
also, little cosmetics.
Signed-off-by: Florian Schilhabel <florian.c.schilhabel@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
added a new function: FirmwareRequest92S
This function(instead of FirmwareDownload92S) is now responsible for
requesting the firmware.
FirmwareDownload92S is now easier to read, smaller and follows kernel
coding style.
plus cosmetics.
Signed-off-by: Florian Schilhabel <florian.c.schilhabel@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
refactored EnableHWSecurityConfig8192 and setKey a bit by replacing
if...else if... else with switch...case
plus cosmetics
Signed-off-by: Florian Schilhabel <florian.c.schilhabel@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This patch fixes two incorrect tab warnings found by the checkpatch.pl
tool
Signed-off-by: Jonas Lundqvist <jonas@gannon.se>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This is a patch to the dhfcfg.h file that fixed up a copyright and
commets style Errors found by the checkpatch.pl tools
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This is a patch to the dhf.c file that fixed up a space and comments
style Errors found by the checkpatch.pl tools
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This is a patch to the dhf.h file that fixed up a copyright anf space
style Errors found by the checkpatch.pl tools
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This is a patch to the dhf.c file that fixed up a trailing statements
Errors found by the checkpatch.pl tools, like
trailing statements should be on next line
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This is a patch to the dhf.c file that fixed up a TAB and spaces Errors
found by the checkpatch.pl tools
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This is a patch to the dhf.c file that fixed up a copyright style Errors
found by the checkpatch.pl tools
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This is a patch to the dhf.c file that fixed up a TAB and spaces Errors
found by the checkpatch.pl tools, like
do not use C99 // comments
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This is a patch to the p80211conv.c file that fixed up a TAB and spaces
Errors found by the checkpatch.pl tools
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This is a patch to the ap_h2.c file that fixed up a TAB and spaces
Errors found by the checkpatch.pl tools, like
do not use C99 // comments
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This is a patch to the debug.h file that fixed up a TAB and spaces
Errors found by the checkpatch.pl tools, like
spaces required around that '&' (ctx:VxV)
and
ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
and
do not use C99 // comments
and
Macros with complex values should be enclosed in parenthesis
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Refactor the wext interface to reduce lines of code & module text size.
- add a helper function p80211wext_getmib
- rename p80211wext_dorequest to p80211wext_setmib
- refactor wext to call the get/set mib helpers and so reduce repeated code.
size reported text reduction :-
text data bss dec hex filename
8343 720 0 9063 2367 p80211wext.o.patch
9907 720 0 10631 2987 p80211wext.o.orig
Tested on x86_32 laptop, everything works correctly using NetworkManager,
and iwconfig & iwlist return sensible results when reading from the card.
Signed-off-by: Richard Kennedy <richard@rsk.demon.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Channel 14 is 2484 Mhz (cf p80211wext_channel_to_mhz) so this patch
corrects what seems to be just a typo.
Signed-off-by: Richard Kennedy <richard@rsk.demon.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Use array initialisation technique copied from ipw2200.c.
This should always get the function pointers in the correct place,
without the needed for endless counting, skipping blanks etc.
Signed-off-by: Richard Kennedy <richard@rsk.demon.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This patch includes the feedback received from Richard Kennedy.
Signed-off-by: Edgardo Hames <ehames@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This is a patch to the p80211conv.c file that fixed up a TAB and spaces
Errors found by the checkpatch.pl tools, like
spaces required around that '&' (ctx:VxV)
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
I fixed the reported checkpatch.pl problems except for a bunch of
long lines and some printk:s.
I also removed versioning comments.
Signed-off-by: Lars Lindley <lindley@coyote.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
I fixed comments and some spacing.
Signed-off-by: Lars Lindley <lindley@coyote.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
