Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

driver core: Delete an unnecessary check before the function call "put_device"

Browse source 
The put_device() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Markus Elfring 2015-02-05 11:48:26 +01:00 committed by Greg Kroah-Hartman
parent 7ca7ec40f4
commit 5f0163a5ee
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
drivers/base/core.c
View file

@ -1095,8 +1095,7 @@ int device_add(struct device *dev)
kobject_del(&dev->kobj); kobject_del(&dev->kobj);
Error: Error:
cleanup_device_parent(dev); cleanup_device_parent(dev);
if (parent) put_device(parent);
put_device(parent);
name_error: name_error:
kfree(dev->p); kfree(dev->p);
dev->p = NULL; dev->p = NULL;