From 5f0163a5ee9cc7c59751768bdfd94a73186debba Mon Sep 17 00:00:00 2001 From: Markus Elfring Date: Thu, 5 Feb 2015 11:48:26 +0100 Subject: [PATCH] driver core: Delete an unnecessary check before the function call "put_device" The put_device() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Greg Kroah-Hartman --- drivers/base/core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/base/core.c b/drivers/base/core.c index 07304a3b9ee2..e0998b6b6c49 100644 --- a/drivers/base/core.c +++ b/drivers/base/core.c @@ -1095,8 +1095,7 @@ int device_add(struct device *dev) kobject_del(&dev->kobj); Error: cleanup_device_parent(dev); - if (parent) - put_device(parent); + put_device(parent); name_error: kfree(dev->p); dev->p = NULL;