Tidying things up

RElesgoe commented

2014-04-13 11:59:38 -06:00

(Migrated from github.com)

•Corrected language errors
•Added /j command, alias of /join
•Replaced instances of "PVPGN" with the name of your server
•/warrenty --> /warranty

•Corrected language errors •Added /j command, alias of /join •Replaced instances of "PVPGN" with the name of your server •/warrenty --> /warranty

RElesgoe commented

2014-04-13 12:00:04 -06:00

(Migrated from github.com)

btw I didn't test this one :(

HarpyWar commented

2014-04-13 12:39:58 -06:00

(Migrated from github.com)

Thanks for the corrections, test a compilation please.
I think prefs_get_servername() ("servername" from bnetd.conf) should be in the messages instead of PVPGN_SOFTWARE, so admin can change this var. Do you?

Thanks for the corrections, test a compilation please. I think prefs_get_servername() ("servername" from bnetd.conf) should be in the messages instead of PVPGN_SOFTWARE, so admin can change this var. Do you?

RElesgoe commented

2014-04-13 12:57:02 -06:00

(Migrated from github.com)

I believe that PVPGN_SOFTWARE is already used in the MOTD file along with PVPGN_VERSION
The message is:
Hello [username], welcome to PvPGN Realm!(<--- I think that's another variable)
Running version [PVPGN_SOFTWARE] [PVPGN_VERSION] on [machine].
.......more stuff.....
Those two variables are hardcoded in version.h, now that you pointed out that there's a function to get the servername from bnetd.conf, there's obviously some overlapping functionality here.

I believe that PVPGN_SOFTWARE is already used in the MOTD file along with PVPGN_VERSION The message is: Hello [username], welcome to PvPGN Realm!(<--- I think that's another variable) Running version [PVPGN_SOFTWARE] [PVPGN_VERSION] on [machine]. .......more stuff..... Those two variables are hardcoded in version.h, now that you pointed out that there's a function to get the servername from bnetd.conf, there's obviously some overlapping functionality here.

RElesgoe commented

2014-04-13 13:00:38 -06:00

(Migrated from github.com)

Or actually, I'm wrong.... It'd be more correct to use prefs_get_servername()

HarpyWar commented

2014-04-13 13:02:59 -06:00

(Migrated from github.com)

"PvPGN Realm" is defined in BNETD_SERVERNAME as default value, and it can be changed from bnetd.conf

RElesgoe commented

2014-04-13 14:00:18 -06:00

(Migrated from github.com)

I don't think I can even test anything right now because I already have a custom pvpgn installed already and don't want to overwrite it...

HarpyWar commented

2014-04-14 03:33:55 -06:00

(Migrated from github.com)

You can just check a compilation with Magic Bulder http://code.google.com/p/pvpgn-magic-builder/
I can do it, but if you want to contribute another patches, you have to check it by yourself.

I will merge this commit after that and when you replace PVPGN_SOFTWARE -> prefs_get_servername(). Thanks.

You can just check a compilation with Magic Bulder http://code.google.com/p/pvpgn-magic-builder/ I can do it, but if you want to contribute another patches, you have to check it by yourself. I will merge this commit after that and when you replace PVPGN_SOFTWARE -> prefs_get_servername(). Thanks.

HarpyWar commented

2014-04-15 07:31:29 -06:00

(Migrated from github.com)

Please, fix compile errors.

HarpyWar commented

2014-04-16 22:33:02 -06:00

(Migrated from github.com)

Btw, Magic Builder is deprecated for code from this repository, but you can solve it simply http://forums.harpywar.com/viewtopic.php?pid=6273#p6273

RElesgoe commented

2014-04-16 23:40:48 -06:00

(Migrated from github.com)

That cleared a lot of errors that I was receiving but I the only major error that I get now is:
"cannot open include file 'afxres.h'"

That cleared a lot of errors that I was receiving but I the only major error that I get now is: "cannot open include file 'afxres.h'"

HarpyWar commented

2014-04-16 23:51:56 -06:00

(Migrated from github.com)

It usually means that you have VC++ Express edition. There are include files missed from this edition, but Builder has these files in module\include\vsexpress_include, and they should be eautomatically included when building.
Do you use Magic Builder or manually open a solution file in VC++?

It usually means that you have VC++ Express edition. There are include files missed from this edition, but Builder has these files in module\include\vsexpress_include, and they should be eautomatically included when building. Do you use Magic Builder or manually open a solution file in VC++?

RElesgoe commented

2014-04-16 23:58:54 -06:00

(Migrated from github.com)

I used Magic Builder

HarpyWar commented

2014-04-17 00:20:09 -06:00

(Migrated from github.com)

If you do not receive other errors then make sure you run builder from the directory without spaces.
Try re download builder, may be you changed some important files. Remove only one CMakeLists.txt.
I just test compile on Windows 7 and VC++ 2010 and it also works.

If you do not receive other errors then make sure you run builder from the directory without spaces. Try re download builder, may be you changed some important files. Remove only one CMakeLists.txt. I just test compile on Windows 7 and VC++ 2010 and it also works.

RElesgoe commented

2014-04-17 17:01:52 -06:00

(Migrated from github.com)

I've done all of that and even checked that I have VC++ 2010 installed on Windows 7.

RElesgoe commented

2014-04-19 12:36:44 -06:00

(Migrated from github.com)

Ok this Pull Request should work now.

HarpyWar commented

2014-04-20 00:50:42 -06:00

(Migrated from github.com)

You forgot rename bnhelp.conf -> bnhelp.conf.in :)
CMake will rename it back to bnhelp.conf after installation.