Techwizz/pvpgn-server
1
0
Fork 0
Code Issues 68 Pull requests 2 Projects Releases 8 Packages Wiki Activity Actions

Prevent possible use of uninitialized variable in _client_createaccountw3()

Browse source
This commit is contained in:
RElesgoe 2016-08-24 00:54:55 -07:00
parent 8c2c82a162
commit f0ad3fae24
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/bnetd/handle_bnet.cpp
View file

@ -672,7 +672,6 @@ namespace pvpgn
t_packet *rpacket;
char const *username;
char const *plainpass;
char lpass[20];
t_hash sc_hash;
unsigned int i;
const char *account_salt;
@ -737,10 +736,11 @@ namespace pvpgn
goto out;
}
if (plainpass) {
char lpass[20] = {};
if (plainpass)
{
/* convert plaintext password to lowercase for sc etc. */
std::strncpy(lpass, plainpass, 16);
lpass[16] = 0;
std::snprintf(lpass, sizeof lpass, "%s", plainpass);
strtolower(lpass);
}