From e400a9c1b216213694bceccdfe5792a1f8754082 Mon Sep 17 00:00:00 2001
From: relesgoe <RElesgoe@users.noreply.github.com>
Date: Sat, 13 Jun 2020 08:11:23 -0700
Subject: [PATCH] Replace magic number with a macro constant in smtp_config()
---
src/bnetd/smtp.cpp | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/bnetd/smtp.cpp b/src/bnetd/smtp.cpp
index c722880..99152b3 100644
--- a/src/bnetd/smtp.cpp
+++ b/src/bnetd/smtp.cpp
@@ -17,6 +17,7 @@
#include "smtp.h"
#include <array>
+#include <cstdint>
#include <ctime>
#include <mutex>
#include <string>
@@ -152,7 +153,8 @@ namespace pvpgn
return false;
}
- if (prefs_smtp_port > 65535)
+ // ports are 16 bit integers, so they should never be above UINT16_MAX (65,535)
+ if (prefs_smtp_port > UINT16_MAX)
{
eventlog(eventlog_level_error, __FUNCTION__, "Received out-of-range port number ({})", prefs_smtp_port);
return false;