Techwizz/pvpgn-server
1
0
Fork 0
Code Issues 68 Pull requests 2 Projects Releases 8 Packages Wiki Activity Actions

Fixed memory leak in function _handle_motd_command() when returning without calling xfree() on variable 'filename'

Browse source
This commit is contained in:
RElesgoe 2016-08-23 23:42:24 -07:00
parent 845e659100
commit 24041be4de
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/bnetd/command.cpp
View file

@ -4667,10 +4667,9 @@ namespace pvpgn
static int _handle_motd_command(t_connection * c, char const *text)
{
char const * filename;
std::FILE * fp;
filename = i18n_filename(prefs_get_motdfile(), conn_get_gamelang_localized(c));
const char* const filename = i18n_filename(prefs_get_motdfile(), conn_get_gamelang_localized(c));
if (fp = std::fopen(filename, "r"))
{
@ -4683,6 +4682,9 @@ namespace pvpgn
eventlog(eventlog_level_error, __FUNCTION__, "could not open motd file \"{}\" for reading (std::fopen: {})", filename, std::strerror(errno));
message_send_text(c, message_type_error, c, localize(c, "Unable to open motd."));
}
xfree((void*)filename);
return 0;
}