Techwizz/pvpgn-server
1
0
Fork 0
Code Issues 68 Pull requests 2 Projects Releases 8 Packages Wiki Activity Actions

restrict check for STARTGAME4 packet length for starcraft client only

Browse source 
https://github.com/pvpgn/pvpgn-server/issues/159
This commit is contained in:
HarpyWar 2015-09-22 18:40:01 +03:00
parent f19ca1afa2
commit 224fed7598
1 changed files with 10 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/bnetd/handle_bnet.cpp
View file

@ -4046,13 +4046,17 @@ namespace pvpgn
return -1;
}
// Protection from hack attempt
// Large map name size will cause crash Starcraft client for user who select an item in game list ("Join" area)
// It occurs when the packet size of packet 0x0c in length interval 161-164
if (packet_get_size(packet) > 160)
if (conn_get_clienttag(c) == CLIENTTAG_STARCRAFT_UINT || conn_get_clienttag(c) == CLIENTTAG_BROODWARS_UINT)
{
eventlog(eventlog_level_error, __FUNCTION__, "[%d] got abnormal STARTGAME4 packet length (got %u bytes, hack attempt?)", conn_get_socket(c), packet_get_size(packet));
return -1;
// FIXME: (HarpyWar) Protection from hack attempt
// Large map name size will cause crash Starcraft client for user who select an item in game list ("Join" area)
// It occurs when the packet size of packet 0x0c in length interval 161-164
// https://github.com/pvpgn/pvpgn-server/issues/159
if (packet_get_size(packet) > 160)
{
eventlog(eventlog_level_error, __FUNCTION__, "[%d] got abnormal STARTGAME4 packet length (got %u bytes, hack attempt?)", conn_get_socket(c), packet_get_size(packet));
return -1;
}
}
// Quick hack to make W3 part channels when creating a game