Techwizz/pvpgn-server
1
0
Fork 0
Code Issues 68 Pull requests 2 Projects Releases 8 Packages Wiki Activity Actions

Fixed a memory leak in userlog_append() when returning without calling xfree() on variable 'filename'

Browse source
This commit is contained in:
RElesgoe 2016-08-23 23:35:02 -07:00
parent b460835af8
commit 21402786df
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/bnetd/userlog.cpp
View file

@ -140,7 +140,7 @@ namespace pvpgn
std::strftime(time_string, USEREVENT_TIME_MAXLEN, USEREVENT_TIME_FORMAT, tmnow);
char * filename = userlog_filename(account_get_name(account), true);
const char* const filename = userlog_filename(account_get_name(account), true);
if (FILE *fp = fopen(filename, "a"))
{
@ -152,6 +152,8 @@ namespace pvpgn
{
ERROR1("could not write into user log file \"{}\"", filename);
}
xfree((void*)filename);
}
// read "count" lines from the end starting from "startline"