Techwizz/pvpgn-server
1
0
Fork 0
Code Issues68 Pull requests2 Projects Releases8 Packages Wiki Activity Actions

Fix memory leak in apireg_send() when returning without calling packet_del_ref() on variable 'p'

Browse source
This commit is contained in:
RElesgoe 2016-08-23 20:22:38 -07:00
parent f1ea7d0c09
commit 09bb7569f4
1 changed files with 8 additions and 8 deletions

16
src/bnetd/handle_apireg.cpp
View file

@ -455,13 +455,10 @@ namespace pvpgn
static int apireg_send(t_connection * conn, char const * command)
{
t_packet * p;
char data[MAX_IRC_MESSAGE_LEN + 1];
unsigned len = 0;
t_elem * curr;
p = packet_create(packet_class_raw);
if (command)
len = (std::strlen(command));
@ -473,11 +470,14 @@ namespace pvpgn
std::sprintf(data, "%s", command);
}
packet_set_size(p, 0);
packet_append_data(p, data, len);
DEBUG2("[{}] sent \"{}\"", conn_get_socket(conn), data);
conn_push_outqueue(conn, p);
packet_del_ref(p);
{
t_packet* const p = packet_create(packet_class_raw);
packet_set_size(p, 0);
packet_append_data(p, data, len);
DEBUG2("[{}] sent \"{}\"", conn_get_socket(conn), data);
conn_push_outqueue(conn, p);
packet_del_ref(p);
}
/* In apiregister server we must destroy apiregmember and connection after send packet */