Techwizz/pvpgn-server
1
0
Fork 0
Code Issues 68 Pull requests 2 Projects Releases 8 Packages Wiki Activity Actions

Fix memory leak in _client_motdw3() when continuing loop without calling xfree() on variable 'line'

Browse source
This commit is contained in:
RElesgoe 2016-08-28 02:27:17 -07:00
parent 13ac03d753
commit 049b029a95
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/bnetd/handle_bnet.cpp
View file

@ -2799,7 +2799,7 @@ namespace pvpgn
// read text from bnmotd_w3.txt
char * buff, *line;
char * buff;
std::FILE * fp;
const char* const filename = i18n_filename(prefs_get_motdw3file(), conn_get_gamelang_localized(c));
@ -2809,8 +2809,9 @@ namespace pvpgn
{
while ((buff = file_get_line(fp)))
{
line = message_format_line(c, buff);
char* line = message_format_line(c, buff);
std::snprintf(serverinfo, sizeof serverinfo, "%s\n", &line[1]);
xfree((void*)line);
}
if (std::fclose(fp) < 0)
eventlog(eventlog_level_error, __FUNCTION__, "could not close motdw3 file \"{}\" after reading (std::fopen: {})", filename, std::strerror(errno));