Techwizz/pvpgn-server
1
0
Fork 0
Code Issues68 Pull requests2 Projects Releases8 Packages Wiki Activity Actions

Replace call to std::strncpy() with std::snprintf() in d2ladder_readladder() because std::strncpy() may not null-terimate the destination string

Browse source
This commit is contained in:
relesgoe 2020-08-21 14:52:00 -07:00
parent 636de8071e
commit 0034bb4e96
1 changed files with 1 additions and 1 deletions

2
src/d2dbs/d2ladder.cpp
View file

@ -452,7 +452,7 @@ namespace pvpgn
temp.status = bn_short_get(ldata[i].status);
temp.level = bn_byte_get(ldata[i].level);
temp.chclass = bn_byte_get(ldata[i].chclass);
std::strncpy(temp.charname, ldata[i].charname, sizeof(info[i].charname));
std::snprintf(temp.charname, sizeof(temp.charname), "%s", ldata[i].charname);
if (d2ladder_update_info_and_pos(d2ladder, &temp,
d2ladder_find_char_all(d2ladder, &temp),
d2ladder_find_pos(d2ladder, &temp)) == 1) {