cdb8c2a6d8
The current dc395x driver uses PIO to transfer up to 4 bytes which do not get transferred by DMA (under unclear circumstances). For this the driver uses page_address() which is broken on highmem. Apart from this the actual calculation of the virtual address is wrong (even without highmem). So, e.g., for reading it reads bytes from the driver to a wrong address and returns wrong data, I guess, for writing it would just output random data to the device. The proper fix, as suggested by many, is to dynamically map data using kmap_atomic(page, KM_BIO_SRC_IRQ) / kunmap_atomic(virt). The reason why it has not been done until now, although I've done some preliminary patches more than a year ago was that nobody interested in fixing this problem was able to reliably reproduce it. Now it changed - with the help from Sebastian Frei (CC'ed) I was able to trigger the PIO path. Thus, I was also able to test and debug it. There are 4 cases when PIO is used in dc395x - data-in / -out with and without scatter-gather. I was able to reproduce and test only data-in with and without SG. So, the data-out path is still untested, but it is also somewhat simpler than the data-in. Fredrik Roubert (also CC'ed) also had PIO triggering on his system, and in his case it was data-out without SG. It would be great if he could test the attached patch on his system, but even if he cannot, I would still request to apply the patch and just wait if anybody cries... Implementation: I put 2 new functions in scsi_lib.c and their declarations in scsi_cmnd.h. I exported them without _GPL, although, I don't feel strongly about that - not many drivers are likely to use them. But there is at least one more - I want to use them in tmscsim.c. Whether these are the right files for the functions and their declarations - not sure either. Actually, they are not scsi-specific, so, might go somewhere around other scattergather magic? They are not platform specific either, and most SG functions are defined under arch/*/... As these issues were discussed previously there were some more routines suggested to manipulate scattergather buffers, I think, some of them were needed around crypto code... So, might be a common place reasonable, like lib/scattergather.c? I am open here. Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
159 lines
5.2 KiB
C
159 lines
5.2 KiB
C
#ifndef _SCSI_SCSI_CMND_H
|
|
#define _SCSI_SCSI_CMND_H
|
|
|
|
#include <linux/dma-mapping.h>
|
|
#include <linux/list.h>
|
|
#include <linux/types.h>
|
|
#include <linux/timer.h>
|
|
|
|
struct request;
|
|
struct scatterlist;
|
|
struct scsi_device;
|
|
struct scsi_request;
|
|
|
|
|
|
/* embedded in scsi_cmnd */
|
|
struct scsi_pointer {
|
|
char *ptr; /* data pointer */
|
|
int this_residual; /* left in this buffer */
|
|
struct scatterlist *buffer; /* which buffer */
|
|
int buffers_residual; /* how many buffers left */
|
|
|
|
dma_addr_t dma_handle;
|
|
|
|
volatile int Status;
|
|
volatile int Message;
|
|
volatile int have_data_in;
|
|
volatile int sent_command;
|
|
volatile int phase;
|
|
};
|
|
|
|
struct scsi_cmnd {
|
|
int sc_magic;
|
|
|
|
struct scsi_device *device;
|
|
struct scsi_request *sc_request;
|
|
|
|
struct list_head list; /* scsi_cmnd participates in queue lists */
|
|
|
|
struct list_head eh_entry; /* entry for the host eh_cmd_q */
|
|
int eh_eflags; /* Used by error handlr */
|
|
void (*done) (struct scsi_cmnd *); /* Mid-level done function */
|
|
|
|
/*
|
|
* A SCSI Command is assigned a nonzero serial_number before passed
|
|
* to the driver's queue command function. The serial_number is
|
|
* cleared when scsi_done is entered indicating that the command
|
|
* has been completed. It currently doesn't have much use other
|
|
* than printk's. Some lldd's use this number for other purposes.
|
|
* It's almost certain that such usages are either incorrect or
|
|
* meaningless. Please kill all usages other than printk's. Also,
|
|
* as this number is always identical to ->pid, please convert
|
|
* printk's to use ->pid, so that we can kill this field.
|
|
*/
|
|
unsigned long serial_number;
|
|
/*
|
|
* This is set to jiffies as it was when the command was first
|
|
* allocated. It is used to time how long the command has
|
|
* been outstanding
|
|
*/
|
|
unsigned long jiffies_at_alloc;
|
|
|
|
int retries;
|
|
int allowed;
|
|
int timeout_per_command;
|
|
|
|
unsigned char cmd_len;
|
|
unsigned char old_cmd_len;
|
|
enum dma_data_direction sc_data_direction;
|
|
enum dma_data_direction sc_old_data_direction;
|
|
|
|
/* These elements define the operation we are about to perform */
|
|
#define MAX_COMMAND_SIZE 16
|
|
unsigned char cmnd[MAX_COMMAND_SIZE];
|
|
unsigned request_bufflen; /* Actual request size */
|
|
|
|
struct timer_list eh_timeout; /* Used to time out the command. */
|
|
void *request_buffer; /* Actual requested buffer */
|
|
|
|
/* These elements define the operation we ultimately want to perform */
|
|
unsigned char data_cmnd[MAX_COMMAND_SIZE];
|
|
unsigned short old_use_sg; /* We save use_sg here when requesting
|
|
* sense info */
|
|
unsigned short use_sg; /* Number of pieces of scatter-gather */
|
|
unsigned short sglist_len; /* size of malloc'd scatter-gather list */
|
|
unsigned bufflen; /* Size of data buffer */
|
|
void *buffer; /* Data buffer */
|
|
|
|
unsigned underflow; /* Return error if less than
|
|
this amount is transferred */
|
|
unsigned old_underflow; /* save underflow here when reusing the
|
|
* command for error handling */
|
|
|
|
unsigned transfersize; /* How much we are guaranteed to
|
|
transfer with each SCSI transfer
|
|
(ie, between disconnect /
|
|
reconnects. Probably == sector
|
|
size */
|
|
|
|
int resid; /* Number of bytes requested to be
|
|
transferred less actual number
|
|
transferred (0 if not supported) */
|
|
|
|
struct request *request; /* The command we are
|
|
working on */
|
|
|
|
#define SCSI_SENSE_BUFFERSIZE 96
|
|
unsigned char sense_buffer[SCSI_SENSE_BUFFERSIZE];
|
|
/* obtained by REQUEST SENSE when
|
|
* CHECK CONDITION is received on original
|
|
* command (auto-sense) */
|
|
|
|
/* Low-level done function - can be used by low-level driver to point
|
|
* to completion function. Not used by mid/upper level code. */
|
|
void (*scsi_done) (struct scsi_cmnd *);
|
|
|
|
/*
|
|
* The following fields can be written to by the host specific code.
|
|
* Everything else should be left alone.
|
|
*/
|
|
struct scsi_pointer SCp; /* Scratchpad used by some host adapters */
|
|
|
|
unsigned char *host_scribble; /* The host adapter is allowed to
|
|
* call scsi_malloc and get some memory
|
|
* and hang it here. The host adapter
|
|
* is also expected to call scsi_free
|
|
* to release this memory. (The memory
|
|
* obtained by scsi_malloc is guaranteed
|
|
* to be at an address < 16Mb). */
|
|
|
|
int result; /* Status code from lower level driver */
|
|
|
|
unsigned char tag; /* SCSI-II queued command tag */
|
|
unsigned long pid; /* Process ID, starts at 0. Unique per host. */
|
|
};
|
|
|
|
/*
|
|
* These are the values that scsi_cmd->state can take.
|
|
*/
|
|
#define SCSI_STATE_TIMEOUT 0x1000
|
|
#define SCSI_STATE_FINISHED 0x1001
|
|
#define SCSI_STATE_FAILED 0x1002
|
|
#define SCSI_STATE_QUEUED 0x1003
|
|
#define SCSI_STATE_UNUSED 0x1006
|
|
#define SCSI_STATE_DISCONNECTING 0x1008
|
|
#define SCSI_STATE_INITIALIZING 0x1009
|
|
#define SCSI_STATE_BHQUEUE 0x100a
|
|
#define SCSI_STATE_MLQUEUE 0x100b
|
|
|
|
|
|
extern struct scsi_cmnd *scsi_get_command(struct scsi_device *, gfp_t);
|
|
extern void scsi_put_command(struct scsi_cmnd *);
|
|
extern void scsi_io_completion(struct scsi_cmnd *, unsigned int, unsigned int);
|
|
extern void scsi_finish_command(struct scsi_cmnd *cmd);
|
|
|
|
extern void *scsi_kmap_atomic_sg(struct scatterlist *sg, int sg_count,
|
|
size_t *offset, size_t *len);
|
|
extern void scsi_kunmap_atomic_sg(void *virt);
|
|
|
|
#endif /* _SCSI_SCSI_CMND_H */
|