93de00fd1c
hdparm explicitely marks HDIO_[UNREGISTER,SCAN]_HWIF ioctls as DANGEROUS and given the number of bugs we can assume that there are no real users: * DMA has no chance of working because DMA resources are released by ide_unregister() and they are never allocated again. * Since ide_init_hwif_ports() is used for ->io_ports[] setup the ioctls don't work for almost all hosts with "non-standard" (== non ISA-like) layout of IDE taskfile registers (there is a lot of such host drivers). * ide_port_init_devices() is not called when probing IDE devices so: - drive->autotune is never set and IDE host/devices are not programmed for the correct PIO/DMA transfer modes (=> possible data corruption) - host specific I/O 32-bit and IRQ unmasking settings are not applied (=> possible data corruption) - host specific ->port_init_devs method is not called (=> no luck with ht6560b, qd65xx and opti621 host drivers) * ->rw_disk method is not preserved (=> no HPT3xxN chipsets support). * ->serialized flag is not preserved (=> possible data corruption when using icside, aec62xx (ATP850UF chipset), cmd640, cs5530, hpt366 (HPT3xxN chipsets), rz1000, sc1200, dtc2278 and ht6560b host drivers). * ->ack_intr method is not preserved (=> needed by ide-cris, buddha, gayle and macide host drivers). * ->sata_scr[] and sata_misc[] is cleared by ide_unregister() and it isn't initialized again (SiI3112 support needs them). * To issue an ioctl() there need to be at least one IDE device present in the system. * ->cable_detect method is not preserved + it is not called when probing IDE devices so cable detection is broken (however since DMA support is also broken it doesn't really matter ;-). * Some objects which may have already been freed in ide_unregister() are restored by ide_hwif_restore() (i.e. ->hwgroup). * ide_register_hw() may unregister unrelated IDE ports if free ide_hwifs[] slot cannot be found. * When IDE host drivers are modular unregistered port may be re-used by different host driver that owned it first causing subtle bugs. Since we now have a proper warm-plug support remove these ioctls, then remove no longer needed: - ide_register_hw() and ide_hwif_restore() functions - 'init_default' and 'restore' arguments of ide_unregister() - zeroeing of hwif->{dma,extra}_* fields in ide_unregister() As an added bonus IDE core code size shrinks by ~3kB (x86-32). v2: * fix ide_unregister() arguments in cleanup_module() (Andrew Morton). v3: * fix ide_unregister() arguments in palm_bk3710.c. Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
152 lines
3.4 KiB
C
152 lines
3.4 KiB
C
/*
|
|
* Platform IDE driver
|
|
*
|
|
* Copyright (C) 2007 MontaVista Software
|
|
*
|
|
* Maintainer: Kumar Gala <galak@kernel.crashing.org>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify it
|
|
* under the terms of the GNU General Public License as published by the
|
|
* Free Software Foundation; either version 2 of the License, or (at your
|
|
* option) any later version.
|
|
*/
|
|
|
|
#include <linux/types.h>
|
|
#include <linux/init.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/ide.h>
|
|
#include <linux/ioport.h>
|
|
#include <linux/module.h>
|
|
#include <linux/ata_platform.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/io.h>
|
|
|
|
static void __devinit plat_ide_setup_ports(hw_regs_t *hw,
|
|
void __iomem *base,
|
|
void __iomem *ctrl,
|
|
struct pata_platform_info *pdata,
|
|
int irq)
|
|
{
|
|
unsigned long port = (unsigned long)base;
|
|
int i;
|
|
|
|
hw->io_ports[IDE_DATA_OFFSET] = port;
|
|
|
|
port += (1 << pdata->ioport_shift);
|
|
for (i = IDE_ERROR_OFFSET; i <= IDE_STATUS_OFFSET;
|
|
i++, port += (1 << pdata->ioport_shift))
|
|
hw->io_ports[i] = port;
|
|
|
|
hw->io_ports[IDE_CONTROL_OFFSET] = (unsigned long)ctrl;
|
|
|
|
hw->irq = irq;
|
|
|
|
hw->chipset = ide_generic;
|
|
}
|
|
|
|
static int __devinit plat_ide_probe(struct platform_device *pdev)
|
|
{
|
|
struct resource *res_base, *res_alt, *res_irq;
|
|
void __iomem *base, *alt_base;
|
|
ide_hwif_t *hwif;
|
|
struct pata_platform_info *pdata;
|
|
u8 idx[4] = { 0xff, 0xff, 0xff, 0xff };
|
|
int ret = 0;
|
|
int mmio = 0;
|
|
hw_regs_t hw;
|
|
|
|
pdata = pdev->dev.platform_data;
|
|
|
|
/* get a pointer to the register memory */
|
|
res_base = platform_get_resource(pdev, IORESOURCE_IO, 0);
|
|
res_alt = platform_get_resource(pdev, IORESOURCE_IO, 1);
|
|
|
|
if (!res_base || !res_alt) {
|
|
res_base = platform_get_resource(pdev, IORESOURCE_MEM, 0);
|
|
res_alt = platform_get_resource(pdev, IORESOURCE_MEM, 1);
|
|
if (!res_base || !res_alt) {
|
|
ret = -ENOMEM;
|
|
goto out;
|
|
}
|
|
mmio = 1;
|
|
}
|
|
|
|
res_irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
|
|
if (!res_irq) {
|
|
ret = -EINVAL;
|
|
goto out;
|
|
}
|
|
|
|
if (mmio) {
|
|
base = devm_ioremap(&pdev->dev,
|
|
res_base->start, res_base->end - res_base->start + 1);
|
|
alt_base = devm_ioremap(&pdev->dev,
|
|
res_alt->start, res_alt->end - res_alt->start + 1);
|
|
} else {
|
|
base = devm_ioport_map(&pdev->dev,
|
|
res_base->start, res_base->end - res_base->start + 1);
|
|
alt_base = devm_ioport_map(&pdev->dev,
|
|
res_alt->start, res_alt->end - res_alt->start + 1);
|
|
}
|
|
|
|
hwif = ide_find_port((unsigned long)base);
|
|
if (!hwif) {
|
|
ret = -ENODEV;
|
|
goto out;
|
|
}
|
|
|
|
memset(&hw, 0, sizeof(hw));
|
|
plat_ide_setup_ports(&hw, base, alt_base, pdata, res_irq->start);
|
|
hw.dev = &pdev->dev;
|
|
|
|
ide_init_port_hw(hwif, &hw);
|
|
|
|
if (mmio) {
|
|
hwif->mmio = 1;
|
|
default_hwif_mmiops(hwif);
|
|
}
|
|
|
|
idx[0] = hwif->index;
|
|
|
|
ide_device_add(idx, NULL);
|
|
|
|
platform_set_drvdata(pdev, hwif);
|
|
|
|
return 0;
|
|
|
|
out:
|
|
return ret;
|
|
}
|
|
|
|
static int __devexit plat_ide_remove(struct platform_device *pdev)
|
|
{
|
|
ide_hwif_t *hwif = pdev->dev.driver_data;
|
|
|
|
ide_unregister(hwif->index);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static struct platform_driver platform_ide_driver = {
|
|
.driver = {
|
|
.name = "pata_platform",
|
|
},
|
|
.probe = plat_ide_probe,
|
|
.remove = __devexit_p(plat_ide_remove),
|
|
};
|
|
|
|
static int __init platform_ide_init(void)
|
|
{
|
|
return platform_driver_register(&platform_ide_driver);
|
|
}
|
|
|
|
static void __exit platform_ide_exit(void)
|
|
{
|
|
platform_driver_unregister(&platform_ide_driver);
|
|
}
|
|
|
|
MODULE_DESCRIPTION("Platform IDE driver");
|
|
MODULE_LICENSE("GPL");
|
|
|
|
module_init(platform_ide_init);
|
|
module_exit(platform_ide_exit);
|