d9975b0b07
Currently when performing random CPU hot-plugs and suspend-to-ram(S2R)
on systems using arm_big_little cpufreq driver, we get warnings similar
to something like below:
cpu cpu1: _opp_add: duplicate OPPs detected. Existing: freq: 600000000,
volt: 800000, enabled: 1. New: freq: 600000000, volt: 800000, enabled: 1
This is mainly because the OPPs for the shared cpus are not set. We can
just use dev_pm_opp_of_cpumask_add_table in case the OPPs are obtained
from DT(arm_big_little_dt.c) or use dev_pm_opp_set_sharing_cpus if the
OPPs are obtained by other means like firmware(e.g. scpi-cpufreq.c)
Also now that the generic dev_pm_opp{,_of}_cpumask_remove_table can
handle removal of opp table and entries for all associated CPUs, we can
re-use dev_pm_opp{,_of}_cpumask_remove_table as free_opp_table in
cpufreq_arm_bL_ops.
This patch makes necessary changes to reuse the generic OPP functions for
{init,free}_opp_table and thereby eliminating the warnings.
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
43 lines
1.3 KiB
C
43 lines
1.3 KiB
C
/*
|
|
* ARM big.LITTLE platform's CPUFreq header file
|
|
*
|
|
* Copyright (C) 2013 ARM Ltd.
|
|
* Sudeep KarkadaNagesha <sudeep.karkadanagesha@arm.com>
|
|
*
|
|
* Copyright (C) 2013 Linaro.
|
|
* Viresh Kumar <viresh.kumar@linaro.org>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License version 2 as
|
|
* published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed "as is" WITHOUT ANY WARRANTY of any
|
|
* kind, whether express or implied; without even the implied warranty
|
|
* of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*/
|
|
#ifndef CPUFREQ_ARM_BIG_LITTLE_H
|
|
#define CPUFREQ_ARM_BIG_LITTLE_H
|
|
|
|
#include <linux/cpufreq.h>
|
|
#include <linux/device.h>
|
|
#include <linux/types.h>
|
|
|
|
struct cpufreq_arm_bL_ops {
|
|
char name[CPUFREQ_NAME_LEN];
|
|
|
|
/*
|
|
* This must set opp table for cpu_dev in a similar way as done by
|
|
* dev_pm_opp_of_add_table().
|
|
*/
|
|
int (*init_opp_table)(const struct cpumask *cpumask);
|
|
|
|
/* Optional */
|
|
int (*get_transition_latency)(struct device *cpu_dev);
|
|
void (*free_opp_table)(const struct cpumask *cpumask);
|
|
};
|
|
|
|
int bL_cpufreq_register(struct cpufreq_arm_bL_ops *ops);
|
|
void bL_cpufreq_unregister(struct cpufreq_arm_bL_ops *ops);
|
|
|
|
#endif /* CPUFREQ_ARM_BIG_LITTLE_H */
|