Magnus Karlsson f6dfebc9ed xsk: Fix registration of Rx-only sockets ... [ Upstream commit 2afd23f78f39da84937006ecd24aa664a4ab052b ] Having Rx-only AF_XDP sockets can potentially lead to a crash in the system by a NULL pointer dereference in xsk_umem_consume_tx(). This function iterates through a list of all sockets tied to a umem and checks if there are any packets to send on the Tx ring. Rx-only sockets do not have a Tx ring, so this will cause a NULL pointer dereference. This will happen if you have registered one or more Rx-only sockets to a umem and the driver is checking the Tx ring even on Rx, or if the XDP_SHARED_UMEM mode is used and there is a mix of Rx-only and other sockets tied to the same umem. Fixed by only putting sockets with a Tx component on the list that xsk_umem_consume_tx() iterates over. Fixes: ac98d8aab6 ("xsk: wire upp Tx zero-copy functions") Reported-by: Kal Cutter Conley <kal.conley@dectris.com> Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com> Signed-off-by: Alexei Starovoitov <ast@kernel.org> Acked-by: Jonathan Lemon <jonathan.lemon@gmail.com> Link: https://lore.kernel.org/bpf/1571645818-16244-1-git-send-email-magnus.karlsson@intel.com Signed-off-by: Sasha Levin <sashal@kernel.org>		2020-01-27 14:51:19 +01:00
..
Kconfig
Makefile
xdp_umem.c	xsk: Fix registration of Rx-only sockets	2020-01-27 14:51:19 +01:00
xdp_umem.h
xdp_umem_props.h
xsk.c	xsk: avoid store-tearing when assigning umem	2020-01-27 14:51:10 +01:00
xsk_queue.c
xsk_queue.h	xsk: Properly terminate assignment in xskq_produce_flush_desc	2019-07-26 09:14:12 +02:00