John Johansen 4cd4fc7703 apparmor: fix suspicious RCU usage warning in policy.c/policy.h ... The recent 3.12 pull request for apparmor was missing a couple rcu _protected access modifiers. Resulting in the follow suspicious RCU usage [ 29.804534] [ INFO: suspicious RCU usage. ] [ 29.804539] 3.11.0+ #5 Not tainted [ 29.804541] ------------------------------- [ 29.804545] security/apparmor/include/policy.h:363 suspicious rcu_dereference_check() usage! [ 29.804548] [ 29.804548] other info that might help us debug this: [ 29.804548] [ 29.804553] [ 29.804553] rcu_scheduler_active = 1, debug_locks = 1 [ 29.804558] 2 locks held by apparmor_parser/1268: [ 29.804560] #0: (sb_writers#9){.+.+.+}, at: [<ffffffff81120a4c>] file_start_write+0x27/0x29 [ 29.804576] #1: (&ns->lock){+.+.+.}, at: [<ffffffff811f5d88>] aa_replace_profiles+0x166/0x57c [ 29.804589] [ 29.804589] stack backtrace: [ 29.804595] CPU: 0 PID: 1268 Comm: apparmor_parser Not tainted 3.11.0+ #5 [ 29.804599] Hardware name: ASUSTeK Computer Inc. UL50VT /UL50VT , BIOS 217 03/01/2010 [ 29.804602] 0000000000000000 ffff8800b95a1d90 ffffffff8144eb9b ffff8800b94db540 [ 29.804611] ffff8800b95a1dc0 ffffffff81087439 ffff880138cc3a18 ffff880138cc3a18 [ 29.804619] ffff8800b9464a90 ffff880138cc3a38 ffff8800b95a1df0 ffffffff811f5084 [ 29.804628] Call Trace: [ 29.804636] [<ffffffff8144eb9b>] dump_stack+0x4e/0x82 [ 29.804642] [<ffffffff81087439>] lockdep_rcu_suspicious+0xfc/0x105 [ 29.804649] [<ffffffff811f5084>] __aa_update_replacedby+0x53/0x7f [ 29.804655] [<ffffffff811f5408>] __replace_profile+0x11f/0x1ed [ 29.804661] [<ffffffff811f6032>] aa_replace_profiles+0x410/0x57c [ 29.804668] [<ffffffff811f16d4>] profile_replace+0x35/0x4c [ 29.804674] [<ffffffff81120fa3>] vfs_write+0xad/0x113 [ 29.804680] [<ffffffff81121609>] SyS_write+0x44/0x7a [ 29.804687] [<ffffffff8145bfd2>] system_call_fastpath+0x16/0x1b [ 29.804691] [ 29.804694] =============================== [ 29.804697] [ INFO: suspicious RCU usage. ] [ 29.804700] 3.11.0+ #5 Not tainted [ 29.804703] ------------------------------- [ 29.804706] security/apparmor/policy.c:566 suspicious rcu_dereference_check() usage! [ 29.804709] [ 29.804709] other info that might help us debug this: [ 29.804709] [ 29.804714] [ 29.804714] rcu_scheduler_active = 1, debug_locks = 1 [ 29.804718] 2 locks held by apparmor_parser/1268: [ 29.804721] #0: (sb_writers#9){.+.+.+}, at: [<ffffffff81120a4c>] file_start_write+0x27/0x29 [ 29.804733] #1: (&ns->lock){+.+.+.}, at: [<ffffffff811f5d88>] aa_replace_profiles+0x166/0x57c [ 29.804744] [ 29.804744] stack backtrace: [ 29.804750] CPU: 0 PID: 1268 Comm: apparmor_parser Not tainted 3.11.0+ #5 [ 29.804753] Hardware name: ASUSTeK Computer Inc. UL50VT /UL50VT , BIOS 217 03/01/2010 [ 29.804756] 0000000000000000 ffff8800b95a1d80 ffffffff8144eb9b ffff8800b94db540 [ 29.804764] ffff8800b95a1db0 ffffffff81087439 ffff8800b95b02b0 0000000000000000 [ 29.804772] ffff8800b9efba08 ffff880138cc3a38 ffff8800b95a1dd0 ffffffff811f4f94 [ 29.804779] Call Trace: [ 29.804786] [<ffffffff8144eb9b>] dump_stack+0x4e/0x82 [ 29.804791] [<ffffffff81087439>] lockdep_rcu_suspicious+0xfc/0x105 [ 29.804798] [<ffffffff811f4f94>] aa_free_replacedby_kref+0x4d/0x62 [ 29.804804] [<ffffffff811f4f47>] ? aa_put_namespace+0x17/0x17 [ 29.804810] [<ffffffff811f4f0b>] kref_put+0x36/0x40 [ 29.804816] [<ffffffff811f5423>] __replace_profile+0x13a/0x1ed [ 29.804822] [<ffffffff811f6032>] aa_replace_profiles+0x410/0x57c [ 29.804829] [<ffffffff811f16d4>] profile_replace+0x35/0x4c [ 29.804835] [<ffffffff81120fa3>] vfs_write+0xad/0x113 [ 29.804840] [<ffffffff81121609>] SyS_write+0x44/0x7a [ 29.804847] [<ffffffff8145bfd2>] system_call_fastpath+0x16/0x1b Reported-by: miles.lane@gmail.com CC: paulmck@linux.vnet.ibm.com Signed-off-by: John Johansen <john.johansen@canonical.com> Signed-off-by: James Morris <james.l.morris@oracle.com>		2013-09-30 09:54:01 +10:00
..
include	apparmor: fix suspicious RCU usage warning in policy.c/policy.h	2013-09-30 09:54:01 +10:00
.gitignore	AppArmor: remove af_names.h from .gitignore	2012-09-01 08:35:34 -07:00
apparmorfs.c	apparmor: add the ability to report a sha1 hash of loaded policy	2013-08-14 11:42:08 -07:00
audit.c	apparmor: fix the audit type table	2013-04-28 00:37:41 -07:00
capability.c	apparmor: export set of capabilities supported by the apparmor module	2013-08-14 11:42:07 -07:00
context.c	apparmor: change how profile replacement update is done	2013-08-14 11:42:06 -07:00
crypto.c	apparmor: Use shash crypto API interface for profile hashes	2013-09-30 09:53:59 +10:00
domain.c	apparmor: allow setting any profile into the unconfined state	2013-08-14 11:42:07 -07:00
file.c	new helper: file_inode(file)	2013-02-22 23:31:31 -05:00
ipc.c	apparmor: add utility function to get an arbitrary tasks profile.	2013-04-28 00:35:53 -07:00
Kconfig	apparmor: add the ability to report a sha1 hash of loaded policy	2013-08-14 11:42:08 -07:00
lib.c	apparmor: remove minimum size check for vmalloc()	2013-08-14 11:42:05 -07:00
lsm.c	Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security	2013-09-07 14:34:07 -07:00
Makefile	apparmor: add the ability to report a sha1 hash of loaded policy	2013-08-14 11:42:08 -07:00
match.c	apparmor: reserve and mask off the top 8 bits of the base field	2013-04-28 00:37:32 -07:00
path.c	apparmor: fix error code to failure message mapping for name lookup	2013-04-28 00:35:40 -07:00
policy.c	apparmor: fix suspicious RCU usage warning in policy.c/policy.h	2013-09-30 09:54:01 +10:00
policy_unpack.c	apparmor: add the ability to report a sha1 hash of loaded policy	2013-08-14 11:42:08 -07:00
procattr.c	apparmor: add interface files for profiles and namespaces	2013-08-14 11:42:07 -07:00
resource.c	apparmor: relax the restrictions on setting rlimits	2013-04-28 00:36:46 -07:00
sid.c	AppArmor: core policy routines	2010-08-02 15:38:37 +10:00