83e3e89d66
[ Upstream commit ffc8599aa9763f39f6736a79da4d1575e7006f9a ]
On machines where the GART aperture is mapped over physical RAM,
/proc/kcore contains the GART aperture range. Accessing the GART range via
/proc/kcore results in a kernel crash.
vmcore used to have the same issue, until it was fixed with commit
2a3e83c6f9 ("x86/gart: Exclude GART aperture from vmcore")', leveraging
existing hook infrastructure in vmcore to let /proc/vmcore return zeroes
when attempting to read the aperture region, and so it won't read from the
actual memory.
Apply the same workaround for kcore. First implement the same hook
infrastructure for kcore, then reuse the hook functions introduced in the
previous vmcore fix. Just with some minor adjustment, rename some functions
for more general usage, and simplify the hook infrastructure a bit as there
is no module usage yet.
Suggested-by: Baoquan He <bhe@redhat.com>
Signed-off-by: Kairui Song <kasong@redhat.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Jiri Bohac <jbohac@suse.cz>
Acked-by: Baoquan He <bhe@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Omar Sandoval <osandov@fb.com>
Cc: Dave Young <dyoung@redhat.com>
Link: https://lkml.kernel.org/r/20190308030508.13548-1-kasong@redhat.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
61 lines
1.2 KiB
C
61 lines
1.2 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
/*
|
|
* /proc/kcore definitions
|
|
*/
|
|
#ifndef _LINUX_KCORE_H
|
|
#define _LINUX_KCORE_H
|
|
|
|
enum kcore_type {
|
|
KCORE_TEXT,
|
|
KCORE_VMALLOC,
|
|
KCORE_RAM,
|
|
KCORE_VMEMMAP,
|
|
KCORE_USER,
|
|
KCORE_OTHER,
|
|
KCORE_REMAP,
|
|
};
|
|
|
|
struct kcore_list {
|
|
struct list_head list;
|
|
unsigned long addr;
|
|
unsigned long vaddr;
|
|
size_t size;
|
|
int type;
|
|
};
|
|
|
|
struct vmcore {
|
|
struct list_head list;
|
|
unsigned long long paddr;
|
|
unsigned long long size;
|
|
loff_t offset;
|
|
};
|
|
|
|
struct vmcoredd_node {
|
|
struct list_head list; /* List of dumps */
|
|
void *buf; /* Buffer containing device's dump */
|
|
unsigned int size; /* Size of the buffer */
|
|
};
|
|
|
|
#ifdef CONFIG_PROC_KCORE
|
|
void __init kclist_add(struct kcore_list *, void *, size_t, int type);
|
|
static inline
|
|
void kclist_add_remap(struct kcore_list *m, void *addr, void *vaddr, size_t sz)
|
|
{
|
|
m->vaddr = (unsigned long)vaddr;
|
|
kclist_add(m, addr, sz, KCORE_REMAP);
|
|
}
|
|
|
|
extern int __init register_mem_pfn_is_ram(int (*fn)(unsigned long pfn));
|
|
#else
|
|
static inline
|
|
void kclist_add(struct kcore_list *new, void *addr, size_t size, int type)
|
|
{
|
|
}
|
|
|
|
static inline
|
|
void kclist_add_remap(struct kcore_list *m, void *addr, void *vaddr, size_t sz)
|
|
{
|
|
}
|
|
#endif
|
|
|
|
#endif /* _LINUX_KCORE_H */
|