18374d89e5
John Blackwood reported: > on an older Dell PowerEdge 6650 system with 8 cpus (4 are hyper-threaded), > and 32 bit (x86) kernel, once you change the irq smp_affinity of an irq > to be less than all cpus in the system, you can never change really the > irq smp_affinity back to be all cpus in the system (0xff) again, > even though no error status is returned on the "/bin/echo ff > > /proc/irq/[n]/smp_affinity" operation. > > This is due to that fact that BAD_APICID has the same value as > all cpus (0xff) on 32bit kernels, and thus the value returned from > set_desc_affinity() via the cpu_mask_to_apicid_and() function is treated > as a failure in set_ioapic_affinity_irq_desc(), and no affinity changes > are made. set_desc_affinity() is already checking if the incoming cpu mask intersects with the cpu online mask or not. So there is no need for the apic op cpu_mask_to_apicid_and() to check again and return BAD_APICID. Remove the BAD_APICID return value from cpu_mask_to_apicid_and() and also fix set_desc_affinity() to return -1 instead of using BAD_APICID to represent error conditions (as cpu_mask_to_apicid_and() can return logical or physical apicid values and BAD_APICID is really to represent bad physical apic id). Reported-by: John Blackwood <john.blackwood@ccur.com> Root-caused-by: John Blackwood <john.blackwood@ccur.com> Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com> LKML-Reference: <1261103386.2535.409.camel@sbs-t61> Signed-off-by: H. Peter Anvin <hpa@zytor.com>
156 lines
4.3 KiB
C
156 lines
4.3 KiB
C
#ifndef _ASM_X86_HW_IRQ_H
|
|
#define _ASM_X86_HW_IRQ_H
|
|
|
|
/*
|
|
* (C) 1992, 1993 Linus Torvalds, (C) 1997 Ingo Molnar
|
|
*
|
|
* moved some of the old arch/i386/kernel/irq.h to here. VY
|
|
*
|
|
* IRQ/IPI changes taken from work by Thomas Radke
|
|
* <tomsoft@informatik.tu-chemnitz.de>
|
|
*
|
|
* hacked by Andi Kleen for x86-64.
|
|
* unified by tglx
|
|
*/
|
|
|
|
#include <asm/irq_vectors.h>
|
|
|
|
#ifndef __ASSEMBLY__
|
|
|
|
#include <linux/percpu.h>
|
|
#include <linux/profile.h>
|
|
#include <linux/smp.h>
|
|
|
|
#include <asm/atomic.h>
|
|
#include <asm/irq.h>
|
|
#include <asm/sections.h>
|
|
|
|
/* Interrupt handlers registered during init_IRQ */
|
|
extern void apic_timer_interrupt(void);
|
|
extern void x86_platform_ipi(void);
|
|
extern void error_interrupt(void);
|
|
extern void perf_pending_interrupt(void);
|
|
|
|
extern void spurious_interrupt(void);
|
|
extern void thermal_interrupt(void);
|
|
extern void reschedule_interrupt(void);
|
|
extern void mce_self_interrupt(void);
|
|
|
|
extern void invalidate_interrupt(void);
|
|
extern void invalidate_interrupt0(void);
|
|
extern void invalidate_interrupt1(void);
|
|
extern void invalidate_interrupt2(void);
|
|
extern void invalidate_interrupt3(void);
|
|
extern void invalidate_interrupt4(void);
|
|
extern void invalidate_interrupt5(void);
|
|
extern void invalidate_interrupt6(void);
|
|
extern void invalidate_interrupt7(void);
|
|
|
|
extern void irq_move_cleanup_interrupt(void);
|
|
extern void reboot_interrupt(void);
|
|
extern void threshold_interrupt(void);
|
|
|
|
extern void call_function_interrupt(void);
|
|
extern void call_function_single_interrupt(void);
|
|
|
|
/* PIC specific functions */
|
|
extern void disable_8259A_irq(unsigned int irq);
|
|
extern void enable_8259A_irq(unsigned int irq);
|
|
extern int i8259A_irq_pending(unsigned int irq);
|
|
extern void make_8259A_irq(unsigned int irq);
|
|
extern void init_8259A(int aeoi);
|
|
|
|
/* IOAPIC */
|
|
#define IO_APIC_IRQ(x) (((x) >= NR_IRQS_LEGACY) || ((1<<(x)) & io_apic_irqs))
|
|
extern unsigned long io_apic_irqs;
|
|
|
|
extern void init_VISWS_APIC_irqs(void);
|
|
extern void setup_IO_APIC(void);
|
|
extern void disable_IO_APIC(void);
|
|
|
|
struct io_apic_irq_attr {
|
|
int ioapic;
|
|
int ioapic_pin;
|
|
int trigger;
|
|
int polarity;
|
|
};
|
|
|
|
static inline void set_io_apic_irq_attr(struct io_apic_irq_attr *irq_attr,
|
|
int ioapic, int ioapic_pin,
|
|
int trigger, int polarity)
|
|
{
|
|
irq_attr->ioapic = ioapic;
|
|
irq_attr->ioapic_pin = ioapic_pin;
|
|
irq_attr->trigger = trigger;
|
|
irq_attr->polarity = polarity;
|
|
}
|
|
|
|
/*
|
|
* This is performance-critical, we want to do it O(1)
|
|
*
|
|
* Most irqs are mapped 1:1 with pins.
|
|
*/
|
|
struct irq_cfg {
|
|
struct irq_pin_list *irq_2_pin;
|
|
cpumask_var_t domain;
|
|
cpumask_var_t old_domain;
|
|
u8 vector;
|
|
u8 move_in_progress : 1;
|
|
};
|
|
|
|
extern struct irq_cfg *irq_cfg(unsigned int);
|
|
extern int assign_irq_vector(int, struct irq_cfg *, const struct cpumask *);
|
|
extern void send_cleanup_vector(struct irq_cfg *);
|
|
|
|
struct irq_desc;
|
|
extern unsigned int set_desc_affinity(struct irq_desc *, const struct cpumask *,
|
|
unsigned int *dest_id);
|
|
extern int IO_APIC_get_PCI_irq_vector(int bus, int devfn, int pin, struct io_apic_irq_attr *irq_attr);
|
|
extern void setup_ioapic_dest(void);
|
|
|
|
extern void enable_IO_APIC(void);
|
|
|
|
/* Statistics */
|
|
extern atomic_t irq_err_count;
|
|
extern atomic_t irq_mis_count;
|
|
|
|
/* EISA */
|
|
extern void eisa_set_level_irq(unsigned int irq);
|
|
|
|
/* SMP */
|
|
extern void smp_apic_timer_interrupt(struct pt_regs *);
|
|
extern void smp_spurious_interrupt(struct pt_regs *);
|
|
extern void smp_x86_platform_ipi(struct pt_regs *);
|
|
extern void smp_error_interrupt(struct pt_regs *);
|
|
#ifdef CONFIG_X86_IO_APIC
|
|
extern asmlinkage void smp_irq_move_cleanup_interrupt(void);
|
|
#endif
|
|
#ifdef CONFIG_SMP
|
|
extern void smp_reschedule_interrupt(struct pt_regs *);
|
|
extern void smp_call_function_interrupt(struct pt_regs *);
|
|
extern void smp_call_function_single_interrupt(struct pt_regs *);
|
|
#ifdef CONFIG_X86_32
|
|
extern void smp_invalidate_interrupt(struct pt_regs *);
|
|
#else
|
|
extern asmlinkage void smp_invalidate_interrupt(struct pt_regs *);
|
|
#endif
|
|
#endif
|
|
|
|
extern void (*__initconst interrupt[NR_VECTORS-FIRST_EXTERNAL_VECTOR])(void);
|
|
|
|
typedef int vector_irq_t[NR_VECTORS];
|
|
DECLARE_PER_CPU(vector_irq_t, vector_irq);
|
|
|
|
#ifdef CONFIG_X86_IO_APIC
|
|
extern void lock_vector_lock(void);
|
|
extern void unlock_vector_lock(void);
|
|
extern void __setup_vector_irq(int cpu);
|
|
#else
|
|
static inline void lock_vector_lock(void) {}
|
|
static inline void unlock_vector_lock(void) {}
|
|
static inline void __setup_vector_irq(int cpu) {}
|
|
#endif
|
|
|
|
#endif /* !ASSEMBLY_ */
|
|
|
|
#endif /* _ASM_X86_HW_IRQ_H */
|