f6d87f4bd2
Impact: preserve user-modified affinities on interrupts
Kumar Galak noticed that commit
1840475676 (genirq: Expose default irq
affinity mask (take 3))
overrides an already set affinity setting across a free /
request_irq(). Happens e.g. with ifdown/ifup of a network device.
Change the logic to mark the affinities as set and keep them
intact. This also fixes the unlocked access to irq_desc in
irq_select_affinity() when called from irq_affinity_proc_write()
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
69 lines
1.9 KiB
C
69 lines
1.9 KiB
C
/*
|
|
* IRQ subsystem internal functions and variables:
|
|
*/
|
|
|
|
extern int noirqdebug;
|
|
|
|
/* Set default functions for irq_chip structures: */
|
|
extern void irq_chip_set_defaults(struct irq_chip *chip);
|
|
|
|
/* Set default handler: */
|
|
extern void compat_irq_chip_set_default_handler(struct irq_desc *desc);
|
|
|
|
extern int __irq_set_trigger(struct irq_desc *desc, unsigned int irq,
|
|
unsigned long flags);
|
|
|
|
#ifdef CONFIG_PROC_FS
|
|
extern void register_irq_proc(unsigned int irq, struct irq_desc *desc);
|
|
extern void register_handler_proc(unsigned int irq, struct irqaction *action);
|
|
extern void unregister_handler_proc(unsigned int irq, struct irqaction *action);
|
|
#else
|
|
static inline void register_irq_proc(unsigned int irq, struct irq_desc *desc) { }
|
|
static inline void register_handler_proc(unsigned int irq,
|
|
struct irqaction *action) { }
|
|
static inline void unregister_handler_proc(unsigned int irq,
|
|
struct irqaction *action) { }
|
|
#endif
|
|
|
|
extern int irq_select_affinity_usr(unsigned int irq);
|
|
|
|
/*
|
|
* Debugging printout:
|
|
*/
|
|
|
|
#include <linux/kallsyms.h>
|
|
|
|
#define P(f) if (desc->status & f) printk("%14s set\n", #f)
|
|
|
|
static inline void print_irq_desc(unsigned int irq, struct irq_desc *desc)
|
|
{
|
|
printk("irq %d, desc: %p, depth: %d, count: %d, unhandled: %d\n",
|
|
irq, desc, desc->depth, desc->irq_count, desc->irqs_unhandled);
|
|
printk("->handle_irq(): %p, ", desc->handle_irq);
|
|
print_symbol("%s\n", (unsigned long)desc->handle_irq);
|
|
printk("->chip(): %p, ", desc->chip);
|
|
print_symbol("%s\n", (unsigned long)desc->chip);
|
|
printk("->action(): %p\n", desc->action);
|
|
if (desc->action) {
|
|
printk("->action->handler(): %p, ", desc->action->handler);
|
|
print_symbol("%s\n", (unsigned long)desc->action->handler);
|
|
}
|
|
|
|
P(IRQ_INPROGRESS);
|
|
P(IRQ_DISABLED);
|
|
P(IRQ_PENDING);
|
|
P(IRQ_REPLAY);
|
|
P(IRQ_AUTODETECT);
|
|
P(IRQ_WAITING);
|
|
P(IRQ_LEVEL);
|
|
P(IRQ_MASKED);
|
|
#ifdef CONFIG_IRQ_PER_CPU
|
|
P(IRQ_PER_CPU);
|
|
#endif
|
|
P(IRQ_NOPROBE);
|
|
P(IRQ_NOREQUEST);
|
|
P(IRQ_NOAUTOEN);
|
|
}
|
|
|
|
#undef P
|
|
|