3eef34ad7d
kernfs_node->parent and ->name are currently marked as "published"
indicating that kernfs users may access them directly; however, those
fields may get updated by kernfs_rename[_ns]() and unrestricted access
may lead to erroneous values or oops.
Protect ->parent and ->name updates with a irq-safe spinlock
kernfs_rename_lock and implement the following accessors for these
fields.
* kernfs_name() - format the node's name into the specified buffer
* kernfs_path() - format the node's path into the specified buffer
* pr_cont_kernfs_name() - pr_cont a node's name (doesn't need buffer)
* pr_cont_kernfs_path() - pr_cont a node's path (doesn't need buffer)
* kernfs_get_parent() - pin and return a node's parent
All can be called under any context. The recursive sysfs_pathname()
in fs/sysfs/dir.c is replaced with kernfs_path() and
sysfs_rename_dir_ns() is updated to use kernfs_get_parent() instead of
dereferencing parent directly.
v2: Dummy definition of kernfs_path() for !CONFIG_KERNFS was missing
static inline making it cause a lot of build warnings. Add it.
Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
123 lines
3.1 KiB
C
123 lines
3.1 KiB
C
/*
|
|
* fs/sysfs/dir.c - sysfs core and dir operation implementation
|
|
*
|
|
* Copyright (c) 2001-3 Patrick Mochel
|
|
* Copyright (c) 2007 SUSE Linux Products GmbH
|
|
* Copyright (c) 2007 Tejun Heo <teheo@suse.de>
|
|
*
|
|
* This file is released under the GPLv2.
|
|
*
|
|
* Please see Documentation/filesystems/sysfs.txt for more information.
|
|
*/
|
|
|
|
#undef DEBUG
|
|
|
|
#include <linux/fs.h>
|
|
#include <linux/kobject.h>
|
|
#include <linux/slab.h>
|
|
#include "sysfs.h"
|
|
|
|
DEFINE_SPINLOCK(sysfs_symlink_target_lock);
|
|
|
|
void sysfs_warn_dup(struct kernfs_node *parent, const char *name)
|
|
{
|
|
char *buf, *path = NULL;
|
|
|
|
buf = kzalloc(PATH_MAX, GFP_KERNEL);
|
|
if (buf)
|
|
path = kernfs_path(parent, buf, PATH_MAX);
|
|
|
|
WARN(1, KERN_WARNING "sysfs: cannot create duplicate filename '%s/%s'\n",
|
|
path, name);
|
|
|
|
kfree(buf);
|
|
}
|
|
|
|
/**
|
|
* sysfs_create_dir_ns - create a directory for an object with a namespace tag
|
|
* @kobj: object we're creating directory for
|
|
* @ns: the namespace tag to use
|
|
*/
|
|
int sysfs_create_dir_ns(struct kobject *kobj, const void *ns)
|
|
{
|
|
struct kernfs_node *parent, *kn;
|
|
|
|
BUG_ON(!kobj);
|
|
|
|
if (kobj->parent)
|
|
parent = kobj->parent->sd;
|
|
else
|
|
parent = sysfs_root_kn;
|
|
|
|
if (!parent)
|
|
return -ENOENT;
|
|
|
|
kn = kernfs_create_dir_ns(parent, kobject_name(kobj),
|
|
S_IRWXU | S_IRUGO | S_IXUGO, kobj, ns);
|
|
if (IS_ERR(kn)) {
|
|
if (PTR_ERR(kn) == -EEXIST)
|
|
sysfs_warn_dup(parent, kobject_name(kobj));
|
|
return PTR_ERR(kn);
|
|
}
|
|
|
|
kobj->sd = kn;
|
|
return 0;
|
|
}
|
|
|
|
/**
|
|
* sysfs_remove_dir - remove an object's directory.
|
|
* @kobj: object.
|
|
*
|
|
* The only thing special about this is that we remove any files in
|
|
* the directory before we remove the directory, and we've inlined
|
|
* what used to be sysfs_rmdir() below, instead of calling separately.
|
|
*/
|
|
void sysfs_remove_dir(struct kobject *kobj)
|
|
{
|
|
struct kernfs_node *kn = kobj->sd;
|
|
|
|
/*
|
|
* In general, kboject owner is responsible for ensuring removal
|
|
* doesn't race with other operations and sysfs doesn't provide any
|
|
* protection; however, when @kobj is used as a symlink target, the
|
|
* symlinking entity usually doesn't own @kobj and thus has no
|
|
* control over removal. @kobj->sd may be removed anytime
|
|
* and symlink code may end up dereferencing an already freed node.
|
|
*
|
|
* sysfs_symlink_target_lock synchronizes @kobj->sd
|
|
* disassociation against symlink operations so that symlink code
|
|
* can safely dereference @kobj->sd.
|
|
*/
|
|
spin_lock(&sysfs_symlink_target_lock);
|
|
kobj->sd = NULL;
|
|
spin_unlock(&sysfs_symlink_target_lock);
|
|
|
|
if (kn) {
|
|
WARN_ON_ONCE(kernfs_type(kn) != KERNFS_DIR);
|
|
kernfs_remove(kn);
|
|
}
|
|
}
|
|
|
|
int sysfs_rename_dir_ns(struct kobject *kobj, const char *new_name,
|
|
const void *new_ns)
|
|
{
|
|
struct kernfs_node *parent;
|
|
int ret;
|
|
|
|
parent = kernfs_get_parent(kobj->sd);
|
|
ret = kernfs_rename_ns(kobj->sd, parent, new_name, new_ns);
|
|
kernfs_put(parent);
|
|
return ret;
|
|
}
|
|
|
|
int sysfs_move_dir_ns(struct kobject *kobj, struct kobject *new_parent_kobj,
|
|
const void *new_ns)
|
|
{
|
|
struct kernfs_node *kn = kobj->sd;
|
|
struct kernfs_node *new_parent;
|
|
|
|
new_parent = new_parent_kobj && new_parent_kobj->sd ?
|
|
new_parent_kobj->sd : sysfs_root_kn;
|
|
|
|
return kernfs_rename_ns(kn, new_parent, kn->name, new_ns);
|
|
}
|