Tom Rix bb0d61385e hwmon: (applesmc) check status earlier. ... [ Upstream commit cecf7560f00a8419396a2ed0f6e5d245ccb4feac ] clang static analysis reports this representative problem applesmc.c:758:10: warning: 1st function call argument is an uninitialized value left = be16_to_cpu(*(__be16 *)(buffer + 6)) >> 2; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ buffer is filled by the earlier call ret = applesmc_read_key(LIGHT_SENSOR_LEFT_KEY, ... This problem is reported because a goto skips the status check. Other similar problems use data from applesmc_read_key before checking the status. So move the checks to before the use. Signed-off-by: Tom Rix <trix@redhat.com> Reviewed-by: Henrik Rydberg <rydberg@bitmath.org> Link: https://lore.kernel.org/r/20200820131932.10590-1-trix@redhat.com Signed-off-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Sasha Levin <sashal@kernel.org>		2020-09-09 19:04:23 +02:00
..
pmbus	hwmon: (adm1275) Make sure we are reading enough data for different chips	2020-07-29 10:16:53 +02:00
ab8500.c
abituguru.c
abituguru3.c
abx500.c
abx500.h
acpi_power_meter.c	hwmon: (acpi_power_meter) Fix potential memory leak in acpi_power_meter_add()	2020-07-09 09:37:11 +02:00
ad7314.c
ad7414.c
ad7418.c
adc128d818.c
adcxx.c
adm1021.c
adm1025.c
adm1026.c
adm1029.c
adm1031.c
adm9240.c
ads1015.c
ads7828.c
ads7871.c
adt7x10.c
adt7x10.h
adt7310.c
adt7410.c
adt7411.c
adt7462.c	hwmon: (adt7462) Fix an error return in ADT7462_REG_VOLT()	2020-03-11 14:15:12 +01:00
adt7470.c
adt7475.c	hwmon: (adt7475) Make volt2reg return same reg as reg2volt input	2020-01-29 16:43:18 +01:00
amc6821.c
applesmc.c	hwmon: (applesmc) check status earlier.	2020-09-09 19:04:23 +02:00
asb100.c
asc7621.c
aspeed-pwm-tacho.c	hwmon: (aspeed-pwm-tacho) Avoid possible buffer overflow	2020-07-29 10:16:53 +02:00
asus_atk0110.c
atxp1.c
coretemp.c
da9052-hwmon.c	hwmon: (da9052) Synchronize access with mfd	2020-05-20 08:18:44 +02:00
da9055-hwmon.c
dell-smm-hwmon.c
dme1737.c
ds620.c
ds1621.c
emc6w201.c
emc1403.c
emc2103.c	hwmon: (emc2103) fix unable to change fan pwm1_enable attribute	2020-07-22 09:32:11 +02:00
f71805f.c
f71882fg.c
f75375s.c
fam15h_power.c
fschmd.c
ftsteutates.c
g760a.c
g762.c
gl518sm.c
gl520sm.c
gpio-fan.c
hih6130.c
hwmon-vid.c
hwmon.c	hwmon: (core) Do not use device managed functions for memory allocations	2020-01-29 16:43:18 +01:00
i5k_amb.c
i5500_temp.c
ibmaem.c
ibmpex.c
ibmpowernv.c
iio_hwmon.c
ina2xx.c
ina209.c
ina3221.c	hwmon: (ina3221) Fix INA3221_CONFIG_MODE macros	2019-11-24 08:21:01 +01:00
it87.c
jc42.c	hwmon: (jc42) Fix name to have no illegal characters	2020-05-02 17:26:00 +02:00
jz4740-hwmon.c
k8temp.c
k10temp.c	hwmon/k10temp, x86/amd_nb: Consolidate shared device IDs	2020-06-22 09:05:23 +02:00
Kconfig
lineage-pem.c
lm63.c
lm70.c
lm73.c
lm75.c	hwmon: (lm75) Fix write operations for negative temperatures	2020-01-27 14:51:08 +01:00
lm75.h
lm77.c
lm78.c
lm80.c
lm83.c
lm85.c
lm87.c
lm90.c
lm92.c
lm93.c
lm95234.c
lm95241.c
lm95245.c
ltc2945.c
ltc2990.c
ltc4151.c
ltc4215.c
ltc4222.c
ltc4245.c
ltc4260.c
ltc4261.c
ltq-cputemp.c
Makefile
max197.c
max1111.c
max1619.c
max1668.c
max6621.c
max6639.c
max6642.c
max6650.c
max6697.c	hwmon: (max6697) Make sure the OVERT mask is set correctly	2020-07-09 09:37:10 +02:00
max16065.c
max31722.c
max31790.c
mc13783-adc.c
mcp3021.c
menf21bmc_hwmon.c
mlxreg-fan.c
nct6683.c
nct6775.c
nct7802.c	hwmon: (nct7802) Fix voltage limits to wrong registers	2020-01-29 16:43:21 +01:00
nct7904.c
npcm750-pwm-fan.c	hwmon: (npcm-750-pwm-fan) Change initial pwm target to 255	2019-11-24 08:21:01 +01:00
nsa320-hwmon.c
ntc_thermistor.c
pc87360.c
pc87427.c
pcf8591.c
powr1220.c
pwm-fan.c	hwmon: (pwm-fan) Silence error on probe deferral	2019-11-24 08:21:00 +01:00
raspberrypi-hwmon.c
s3c-hwmon.c
sch56xx-common.c
sch56xx-common.h
sch5627.c
sch5636.c
scmi-hwmon.c	hwmon: (scmi) Fix potential buffer overflow in scmi_hwmon_probe()	2020-07-29 10:16:54 +02:00
scpi-hwmon.c
sht3x.c
sht15.c
sht21.c
shtc1.c	hwmon: (shtc1) fix shtc1 and shtw1 id mask	2020-01-27 14:51:12 +01:00
sis5595.c
smm665.c
smsc47b397.c
smsc47m1.c
smsc47m192.c
stts751.c
tc74.c
tc654.c
thmc50.c
tmp102.c
tmp103.c
tmp108.c
tmp401.c
tmp421.c
ultra45_env.c
vexpress-hwmon.c
via-cputemp.c
via686a.c
vt1211.c
vt8231.c
w83l785ts.c
w83l786ng.c
w83627ehf.c
w83627hf.c	hwmon: (w83627hf) Use request_muxed_region for Super-IO accesses	2020-01-27 14:50:39 +01:00
w83773g.c
w83781d.c
w83791d.c
w83792d.c
w83793.c
w83795.c
wm831x-hwmon.c
wm8350-hwmon.c
xgene-hwmon.c