kernel-fxtec-pro1x/net/xdp
Björn Töpel 03cfd4e0ed xsk: Add overflow check for u64 division, stored into u32
commit b16a87d0aef7a6be766f6618976dc5ff2c689291 upstream.

The npgs member of struct xdp_umem is an u32 entity, and stores the
number of pages the UMEM consumes. The calculation of npgs

  npgs = size / PAGE_SIZE

can overflow.

To avoid overflow scenarios, the division is now first stored in a
u64, and the result is verified to fit into 32b.

An alternative would be storing the npgs as a u64, however, this
wastes memory and is an unrealisticly large packet area.

Fixes: c0c77d8fb7 ("xsk: add user memory registration support sockopt")
Reported-by: "Minh Bùi Quang" <minhquangbui99@gmail.com>
Signed-off-by: Björn Töpel <bjorn.topel@intel.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Jonathan Lemon <jonathan.lemon@gmail.com>
Link: https://lore.kernel.org/bpf/CACtPs=GGvV-_Yj6rbpzTVnopgi5nhMoCcTkSkYrJHGQHJWFZMQ@mail.gmail.com/
Link: https://lore.kernel.org/bpf/20200525080400.13195-1-bjorn.topel@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-06-03 08:19:48 +02:00
..
Kconfig
Makefile
xdp_umem.c xsk: Add overflow check for u64 division, stored into u32 2020-06-03 08:19:48 +02:00
xdp_umem.h
xdp_umem_props.h
xsk.c xsk: avoid store-tearing when assigning umem 2020-01-27 14:51:10 +01:00
xsk_queue.c
xsk_queue.h xsk: Properly terminate assignment in xskq_produce_flush_desc 2019-07-26 09:14:12 +02:00