2fac6f3fec
Patch from Deepak Saxena The current memset() and memzero() macros on ARM reference the incoming parameters more than once and this can cause uninted side-effects. The issue was found while debugging SCTP protocol and with the specific usage of memzero(skb_put(skb,size),size). This call would call skb_put(skb,size) twice leading to badness. The fixed version copies the incoming parameters into local variables and uses those instead. Signed-off-by: Deepak Saxena Signed-off-by: Russell King
50 lines
1.2 KiB
C
50 lines
1.2 KiB
C
#ifndef __ASM_ARM_STRING_H
|
|
#define __ASM_ARM_STRING_H
|
|
|
|
/*
|
|
* We don't do inline string functions, since the
|
|
* optimised inline asm versions are not small.
|
|
*/
|
|
|
|
#define __HAVE_ARCH_STRRCHR
|
|
extern char * strrchr(const char * s, int c);
|
|
|
|
#define __HAVE_ARCH_STRCHR
|
|
extern char * strchr(const char * s, int c);
|
|
|
|
#define __HAVE_ARCH_MEMCPY
|
|
extern void * memcpy(void *, const void *, __kernel_size_t);
|
|
|
|
#define __HAVE_ARCH_MEMMOVE
|
|
extern void * memmove(void *, const void *, __kernel_size_t);
|
|
|
|
#define __HAVE_ARCH_MEMCHR
|
|
extern void * memchr(const void *, int, __kernel_size_t);
|
|
|
|
#define __HAVE_ARCH_MEMZERO
|
|
#define __HAVE_ARCH_MEMSET
|
|
extern void * memset(void *, int, __kernel_size_t);
|
|
|
|
extern void __memzero(void *ptr, __kernel_size_t n);
|
|
|
|
#define memset(p,v,n) \
|
|
({ \
|
|
void *__p = (p); size_t __n = n; \
|
|
if ((__n) != 0) { \
|
|
if (__builtin_constant_p((v)) && (v) == 0) \
|
|
__memzero((__p),(__n)); \
|
|
else \
|
|
memset((__p),(v),(__n)); \
|
|
} \
|
|
(__p); \
|
|
})
|
|
|
|
#define memzero(p,n) \
|
|
({ \
|
|
void *__p = (p); size_t __n = n; \
|
|
if ((__n) != 0) \
|
|
__memzero((__p),(__n)); \
|
|
(__p); \
|
|
})
|
|
|
|
#endif
|