a4683487f9
In response to an async related regression James noted: "My theory is that this is an init problem: The assumption in a lot of our code is that async_synchronize_full() waits for everything ... even the domain specific async schedules, which isn't true." ...so make this assumption true. Each domain, including the default one, registers itself on a global domain list when work is scheduled. Once all entries complete it exits that list. Waiting for the list to be empty syncs all in-flight work across all domains. Domains can opt-out of global syncing if they are declared as exclusive ASYNC_DOMAIN_EXCLUSIVE(). All stack-based domains have been declared exclusive since the domain may go out of scope as soon as the last work item completes. Statically declared domains are mostly ok, but async_unregister_domain() is there to close any theoretical races with pending async_synchronize_full waiters at module removal time. Signed-off-by: Dan Williams <dan.j.williams@intel.com> Acked-by: Arjan van de Ven <arjan@linux.intel.com> Reported-by: Meelis Roos <mroos@linux.ee> Reported-by: Eldad Zack <eldadzack@gmail.com> Tested-by: Eldad Zack <eldad@fogrefinery.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
55 lines
1.8 KiB
C
55 lines
1.8 KiB
C
/*
|
|
* async.h: Asynchronous function calls for boot performance
|
|
*
|
|
* (C) Copyright 2009 Intel Corporation
|
|
* Author: Arjan van de Ven <arjan@linux.intel.com>
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License
|
|
* as published by the Free Software Foundation; version 2
|
|
* of the License.
|
|
*/
|
|
#ifndef __ASYNC_H__
|
|
#define __ASYNC_H__
|
|
|
|
#include <linux/types.h>
|
|
#include <linux/list.h>
|
|
|
|
typedef u64 async_cookie_t;
|
|
typedef void (async_func_ptr) (void *data, async_cookie_t cookie);
|
|
struct async_domain {
|
|
struct list_head node;
|
|
struct list_head domain;
|
|
int count;
|
|
unsigned registered:1;
|
|
};
|
|
|
|
/*
|
|
* domain participates in global async_synchronize_full
|
|
*/
|
|
#define ASYNC_DOMAIN(_name) \
|
|
struct async_domain _name = { .node = LIST_HEAD_INIT(_name.node), \
|
|
.domain = LIST_HEAD_INIT(_name.domain), \
|
|
.count = 0, \
|
|
.registered = 1 }
|
|
|
|
/*
|
|
* domain is free to go out of scope as soon as all pending work is
|
|
* complete, this domain does not participate in async_synchronize_full
|
|
*/
|
|
#define ASYNC_DOMAIN_EXCLUSIVE(_name) \
|
|
struct async_domain _name = { .node = LIST_HEAD_INIT(_name.node), \
|
|
.domain = LIST_HEAD_INIT(_name.domain), \
|
|
.count = 0, \
|
|
.registered = 0 }
|
|
|
|
extern async_cookie_t async_schedule(async_func_ptr *ptr, void *data);
|
|
extern async_cookie_t async_schedule_domain(async_func_ptr *ptr, void *data,
|
|
struct async_domain *domain);
|
|
void async_unregister_domain(struct async_domain *domain);
|
|
extern void async_synchronize_full(void);
|
|
extern void async_synchronize_full_domain(struct async_domain *domain);
|
|
extern void async_synchronize_cookie(async_cookie_t cookie);
|
|
extern void async_synchronize_cookie_domain(async_cookie_t cookie,
|
|
struct async_domain *domain);
|
|
#endif
|