684f978347
Letting WARN_ON/WARN_ON_ONCE return the condition means that you could do
if (WARN_ON(blah)) {
handle_impossible_case
}
Rather than
if (unlikely(blah)) {
WARN_ON(1)
handle_impossible_case
}
I checked all the newly added WARN_ON_ONCE users and none of them test the
return status so we can still change it.
[akpm@osdl.org: warning fix]
[akpm@osdl.org: build fix]
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
100 lines
2.5 KiB
C
100 lines
2.5 KiB
C
#ifndef _ASM_POWERPC_BUG_H
|
|
#define _ASM_POWERPC_BUG_H
|
|
#ifdef __KERNEL__
|
|
|
|
#include <asm/asm-compat.h>
|
|
/*
|
|
* Define an illegal instr to trap on the bug.
|
|
* We don't use 0 because that marks the end of a function
|
|
* in the ELF ABI. That's "Boo Boo" in case you wonder...
|
|
*/
|
|
#define BUG_OPCODE .long 0x00b00b00 /* For asm */
|
|
#define BUG_ILLEGAL_INSTR "0x00b00b00" /* For BUG macro */
|
|
|
|
#ifndef __ASSEMBLY__
|
|
|
|
struct bug_entry {
|
|
unsigned long bug_addr;
|
|
long line;
|
|
const char *file;
|
|
const char *function;
|
|
};
|
|
|
|
struct bug_entry *find_bug(unsigned long bugaddr);
|
|
|
|
/*
|
|
* If this bit is set in the line number it means that the trap
|
|
* is for WARN_ON rather than BUG or BUG_ON.
|
|
*/
|
|
#define BUG_WARNING_TRAP 0x1000000
|
|
|
|
#ifdef CONFIG_BUG
|
|
|
|
/*
|
|
* BUG_ON() and WARN_ON() do their best to cooperate with compile-time
|
|
* optimisations. However depending on the complexity of the condition
|
|
* some compiler versions may not produce optimal results.
|
|
*/
|
|
|
|
#define BUG() do { \
|
|
__asm__ __volatile__( \
|
|
"1: twi 31,0,0\n" \
|
|
".section __bug_table,\"a\"\n" \
|
|
"\t"PPC_LONG" 1b,%0,%1,%2\n" \
|
|
".previous" \
|
|
: : "i" (__LINE__), "i" (__FILE__), "i" (__FUNCTION__)); \
|
|
} while (0)
|
|
|
|
#define BUG_ON(x) do { \
|
|
if (__builtin_constant_p(x)) { \
|
|
if (x) \
|
|
BUG(); \
|
|
} else { \
|
|
__asm__ __volatile__( \
|
|
"1: "PPC_TLNEI" %0,0\n" \
|
|
".section __bug_table,\"a\"\n" \
|
|
"\t"PPC_LONG" 1b,%1,%2,%3\n" \
|
|
".previous" \
|
|
: : "r" ((long)(x)), "i" (__LINE__), \
|
|
"i" (__FILE__), "i" (__FUNCTION__)); \
|
|
} \
|
|
} while (0)
|
|
|
|
#define __WARN() do { \
|
|
__asm__ __volatile__( \
|
|
"1: twi 31,0,0\n" \
|
|
".section __bug_table,\"a\"\n" \
|
|
"\t"PPC_LONG" 1b,%0,%1,%2\n" \
|
|
".previous" \
|
|
: : "i" (__LINE__ + BUG_WARNING_TRAP), \
|
|
"i" (__FILE__), "i" (__FUNCTION__)); \
|
|
} while (0)
|
|
|
|
#define WARN_ON(x) ({ \
|
|
typeof(x) __ret_warn_on = (x); \
|
|
if (__builtin_constant_p(__ret_warn_on)) { \
|
|
if (__ret_warn_on) \
|
|
__WARN(); \
|
|
} else { \
|
|
__asm__ __volatile__( \
|
|
"1: "PPC_TLNEI" %0,0\n" \
|
|
".section __bug_table,\"a\"\n" \
|
|
"\t"PPC_LONG" 1b,%1,%2,%3\n" \
|
|
".previous" \
|
|
: : "r" (__ret_warn_on), \
|
|
"i" (__LINE__ + BUG_WARNING_TRAP), \
|
|
"i" (__FILE__), "i" (__FUNCTION__)); \
|
|
} \
|
|
unlikely(__ret_warn_on); \
|
|
})
|
|
|
|
#define HAVE_ARCH_BUG
|
|
#define HAVE_ARCH_BUG_ON
|
|
#define HAVE_ARCH_WARN_ON
|
|
#endif /* CONFIG_BUG */
|
|
#endif /* __ASSEMBLY __ */
|
|
|
|
#include <asm-generic/bug.h>
|
|
|
|
#endif /* __KERNEL__ */
|
|
#endif /* _ASM_POWERPC_BUG_H */
|