7d12e780e0
Maintain a per-CPU global "struct pt_regs *" variable which can be used instead
of passing regs around manually through all ~1800 interrupt handlers in the
Linux kernel.
The regs pointer is used in few places, but it potentially costs both stack
space and code to pass it around. On the FRV arch, removing the regs parameter
from all the genirq function results in a 20% speed up of the IRQ exit path
(ie: from leaving timer_interrupt() to leaving do_IRQ()).
Where appropriate, an arch may override the generic storage facility and do
something different with the variable. On FRV, for instance, the address is
maintained in GR28 at all times inside the kernel as part of general exception
handling.
Having looked over the code, it appears that the parameter may be handed down
through up to twenty or so layers of functions. Consider a USB character
device attached to a USB hub, attached to a USB controller that posts its
interrupts through a cascaded auxiliary interrupt controller. A character
device driver may want to pass regs to the sysrq handler through the input
layer which adds another few layers of parameter passing.
I've build this code with allyesconfig for x86_64 and i386. I've runtested the
main part of the code on FRV and i386, though I can't test most of the drivers.
I've also done partial conversion for powerpc and MIPS - these at least compile
with minimal configurations.
This will affect all archs. Mostly the changes should be relatively easy.
Take do_IRQ(), store the regs pointer at the beginning, saving the old one:
struct pt_regs *old_regs = set_irq_regs(regs);
And put the old one back at the end:
set_irq_regs(old_regs);
Don't pass regs through to generic_handle_irq() or __do_IRQ().
In timer_interrupt(), this sort of change will be necessary:
- update_process_times(user_mode(regs));
- profile_tick(CPU_PROFILING, regs);
+ update_process_times(user_mode(get_irq_regs()));
+ profile_tick(CPU_PROFILING);
I'd like to move update_process_times()'s use of get_irq_regs() into itself,
except that i386, alone of the archs, uses something other than user_mode().
Some notes on the interrupt handling in the drivers:
(*) input_dev() is now gone entirely. The regs pointer is no longer stored in
the input_dev struct.
(*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking. It does
something different depending on whether it's been supplied with a regs
pointer or not.
(*) Various IRQ handler function pointers have been moved to type
irq_handler_t.
Signed-Off-By: David Howells <dhowells@redhat.com>
(cherry picked from 1b16e7ac850969f38b375e511e3fa2f474a33867 commit)
86 lines
2.2 KiB
C
86 lines
2.2 KiB
C
/* defines for inline arch setup functions */
|
|
|
|
#include <asm/apic.h>
|
|
#include <asm/i8259.h>
|
|
|
|
/**
|
|
* do_timer_interrupt_hook - hook into timer tick
|
|
* @regs: standard registers from interrupt
|
|
*
|
|
* Description:
|
|
* This hook is called immediately after the timer interrupt is ack'd.
|
|
* It's primary purpose is to allow architectures that don't possess
|
|
* individual per CPU clocks (like the CPU APICs supply) to broadcast the
|
|
* timer interrupt as a means of triggering reschedules etc.
|
|
**/
|
|
|
|
static inline void do_timer_interrupt_hook(void)
|
|
{
|
|
do_timer(1);
|
|
#ifndef CONFIG_SMP
|
|
update_process_times(user_mode_vm(get_irq_regs()));
|
|
#endif
|
|
/*
|
|
* In the SMP case we use the local APIC timer interrupt to do the
|
|
* profiling, except when we simulate SMP mode on a uniprocessor
|
|
* system, in that case we have to call the local interrupt handler.
|
|
*/
|
|
#ifndef CONFIG_X86_LOCAL_APIC
|
|
profile_tick(CPU_PROFILING);
|
|
#else
|
|
if (!using_apic_timer)
|
|
smp_local_timer_interrupt();
|
|
#endif
|
|
}
|
|
|
|
|
|
/* you can safely undefine this if you don't have the Neptune chipset */
|
|
|
|
#define BUGGY_NEPTUN_TIMER
|
|
|
|
/**
|
|
* do_timer_overflow - process a detected timer overflow condition
|
|
* @count: hardware timer interrupt count on overflow
|
|
*
|
|
* Description:
|
|
* This call is invoked when the jiffies count has not incremented but
|
|
* the hardware timer interrupt has. It means that a timer tick interrupt
|
|
* came along while the previous one was pending, thus a tick was missed
|
|
**/
|
|
static inline int do_timer_overflow(int count)
|
|
{
|
|
int i;
|
|
|
|
spin_lock(&i8259A_lock);
|
|
/*
|
|
* This is tricky when I/O APICs are used;
|
|
* see do_timer_interrupt().
|
|
*/
|
|
i = inb(0x20);
|
|
spin_unlock(&i8259A_lock);
|
|
|
|
/* assumption about timer being IRQ0 */
|
|
if (i & 0x01) {
|
|
/*
|
|
* We cannot detect lost timer interrupts ...
|
|
* well, that's why we call them lost, don't we? :)
|
|
* [hmm, on the Pentium and Alpha we can ... sort of]
|
|
*/
|
|
count -= LATCH;
|
|
} else {
|
|
#ifdef BUGGY_NEPTUN_TIMER
|
|
/*
|
|
* for the Neptun bug we know that the 'latch'
|
|
* command doesn't latch the high and low value
|
|
* of the counter atomically. Thus we have to
|
|
* substract 256 from the counter
|
|
* ... funny, isnt it? :)
|
|
*/
|
|
|
|
count -= 256;
|
|
#else
|
|
printk("do_slow_gettimeoffset(): hardware timer problem?\n");
|
|
#endif
|
|
}
|
|
return count;
|
|
}
|