Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity
kernel-fxtec-pro1x/drivers/remoteproc
History
Brandon Maier cf03695ce9 remoteproc: Initialize rproc_class before use 
[ Upstream commit a8f40111d184098cd2b3dc0c7170c42250a5fa09 ]

The remoteproc_core and remoteproc drivers all initialize with module_init().
However remoteproc drivers need the rproc_class during their probe. If one of
the remoteproc drivers runs init and gets through probe before
remoteproc_init() runs, a NULL pointer access of rproc_class's `glue_dirs`
spinlock occurs.

> Unable to handle kernel NULL pointer dereference at virtual address 000000dc
> pgd = c0004000
> [000000dc] *pgd=00000000
> Internal error: Oops: 5 [#1] PREEMPT ARM
> Modules linked in:
> CPU: 0 PID: 1 Comm: swapper Tainted: G        W       4.14.106-rt56 #1
> Hardware name: Generic OMAP36xx (Flattened Device Tree)
> task: c6050000 task.stack: c604a000
> PC is at rt_spin_lock+0x40/0x6c
> LR is at rt_spin_lock+0x28/0x6c
> pc : [<c0523c90>]    lr : [<c0523c78>]    psr: 60000013
> sp : c604bdc0  ip : 00000000  fp : 00000000
> r10: 00000000  r9 : c61c7c10  r8 : c6269c20
> r7 : c0905888  r6 : c6269c20  r5 : 00000000  r4 : 000000d4
> r3 : 000000dc  r2 : c6050000  r1 : 00000002  r0 : 000000d4
> Flags: nZCv  IRQs on  FIQs on  Mode SVC_32  ISA ARM  Segment none
...
> [<c0523c90>] (rt_spin_lock) from [<c03b65a4>] (get_device_parent+0x54/0x17c)
> [<c03b65a4>] (get_device_parent) from [<c03b6bec>] (device_add+0xe0/0x5b4)
> [<c03b6bec>] (device_add) from [<c042adf4>] (rproc_add+0x18/0xd8)
> [<c042adf4>] (rproc_add) from [<c01110e4>] (my_rproc_probe+0x158/0x204)
> [<c01110e4>] (my_rproc_probe) from [<c03bb6b8>] (platform_drv_probe+0x34/0x70)
> [<c03bb6b8>] (platform_drv_probe) from [<c03b9dd4>] (driver_probe_device+0x2c8/0x420)
> [<c03b9dd4>] (driver_probe_device) from [<c03ba02c>] (__driver_attach+0x100/0x11c)
> [<c03ba02c>] (__driver_attach) from [<c03b7d08>] (bus_for_each_dev+0x7c/0xc0)
> [<c03b7d08>] (bus_for_each_dev) from [<c03b910c>] (bus_add_driver+0x1cc/0x264)
> [<c03b910c>] (bus_add_driver) from [<c03ba714>] (driver_register+0x78/0xf8)
> [<c03ba714>] (driver_register) from [<c010181c>] (do_one_initcall+0x100/0x190)
> [<c010181c>] (do_one_initcall) from [<c0800de8>] (kernel_init_freeable+0x130/0x1d0)
> [<c0800de8>] (kernel_init_freeable) from [<c051eee8>] (kernel_init+0x8/0x114)
> [<c051eee8>] (kernel_init) from [<c01175b0>] (ret_from_fork+0x14/0x24)
> Code: e2843008 e3c2203f f5d3f000 e5922010 (e193cf9f)
> ---[ end trace 0000000000000002 ]---

Signed-off-by: Brandon Maier <brandon.maier@rockwellcollins.com>
Link: https://lore.kernel.org/r/20190530225223.136420-1-brandon.maier@rockwellcollins.com
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2020-02-24 08:34:50 +01:00
..
da8xx_remoteproc.c remoteproc/davinci: Use %zx for formating size_t 2019-11-20 18:45:25 +01:00
imx_rproc.c remoteproc: imx_rproc: Slightly simplify code in 'imx_rproc_probe()' 2018-03-18 15:43:46 -07:00
Kconfig remoteproc: qcom: fix Q6V5_WCSS dependencies 2018-07-30 21:17:26 -07:00
keystone_remoteproc.c remoteproc/keystone: explicitly request exclusive reset control 2017-08-27 23:16:22 -07:00
Makefile remoteproc: qcom: Introduce Hexagon V5 based WCSS driver 2018-06-18 15:57:58 -07:00
omap_remoteproc.c drivers: remoteproc: constify rproc_ops structures 2017-01-18 10:46:50 -08:00
omap_remoteproc.h
qcom_adsp_pil.c remoteproc: qcom: adsp: Use common q6v5 helpers 2018-06-18 15:56:02 -07:00
qcom_common.c remoteproc: rename subdev probe and remove functions 2018-06-26 14:09:12 -07:00
qcom_common.h remoteproc: qcom: Introduce sysmon 2018-02-12 16:57:22 -08:00
qcom_q6v5.c remoteproc: qcom: q6v5: Fix a race condition on fatal crash 2019-11-24 08:20:29 +01:00
qcom_q6v5.h remoteproc: q6v5: Extract common resource handling 2018-06-18 15:55:57 -07:00
qcom_q6v5_pil.c remoteproc: qcom: q6v5-mss: Add missing regulator for MSM8996 2020-01-27 14:50:10 +01:00
qcom_q6v5_wcss.c remoteproc: qcom: Introduce Hexagon V5 based WCSS driver 2018-06-18 15:57:58 -07:00
qcom_sysmon.c remoteproc: Make client initialize ops in rproc_subdev 2018-06-26 13:53:07 -07:00
qcom_wcnss.c remoteproc: qcom: Introduce sysmon 2018-02-12 16:57:22 -08:00
qcom_wcnss.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
qcom_wcnss_iris.c remoteproc: qcom_wcnss: Fix circular module dependency 2016-11-14 21:52:19 -08:00
remoteproc_core.c remoteproc: Initialize rproc_class before use 2020-02-24 08:34:50 +01:00
remoteproc_debugfs.c remoteproc: replace "%p" with "%pK" 2018-07-30 23:24:15 -07:00
remoteproc_elf_loader.c remoteproc: Move resource table load logic to find 2018-01-15 09:29:53 -08:00
remoteproc_internal.h remoteproc: Rename "load_rsc_table" to "parse_fw" 2018-02-12 11:05:30 -08:00
remoteproc_sysfs.c remoteproc: Check for NULL firmwares in sysfs interface 2019-11-24 08:20:29 +01:00
remoteproc_virtio.c remoteproc: replace "%p" with "%pK" 2018-07-30 23:24:15 -07:00
st_remoteproc.c remoteproc: st: explicitly request exclusive reset control 2017-08-27 23:18:52 -07:00
st_slim_rproc.c remoteproc: st_slim: replace "%p" with "%pK" 2018-07-30 23:25:09 -07:00
wkup_m3_rproc.c drivers: remoteproc: constify rproc_ops structures 2017-01-18 10:46:50 -08:00