93de00fd1c
hdparm explicitely marks HDIO_[UNREGISTER,SCAN]_HWIF ioctls as DANGEROUS
and given the number of bugs we can assume that there are no real users:
* DMA has no chance of working because DMA resources are released by
ide_unregister() and they are never allocated again.
* Since ide_init_hwif_ports() is used for ->io_ports[] setup the ioctls
don't work for almost all hosts with "non-standard" (== non ISA-like)
layout of IDE taskfile registers (there is a lot of such host drivers).
* ide_port_init_devices() is not called when probing IDE devices so:
- drive->autotune is never set and IDE host/devices are not programmed
for the correct PIO/DMA transfer modes (=> possible data corruption)
- host specific I/O 32-bit and IRQ unmasking settings are not applied
(=> possible data corruption)
- host specific ->port_init_devs method is not called (=> no luck with
ht6560b, qd65xx and opti621 host drivers)
* ->rw_disk method is not preserved (=> no HPT3xxN chipsets support).
* ->serialized flag is not preserved (=> possible data corruption when
using icside, aec62xx (ATP850UF chipset), cmd640, cs5530, hpt366
(HPT3xxN chipsets), rz1000, sc1200, dtc2278 and ht6560b host drivers).
* ->ack_intr method is not preserved (=> needed by ide-cris, buddha,
gayle and macide host drivers).
* ->sata_scr[] and sata_misc[] is cleared by ide_unregister() and it
isn't initialized again (SiI3112 support needs them).
* To issue an ioctl() there need to be at least one IDE device present
in the system.
* ->cable_detect method is not preserved + it is not called when probing
IDE devices so cable detection is broken (however since DMA support is
also broken it doesn't really matter ;-).
* Some objects which may have already been freed in ide_unregister()
are restored by ide_hwif_restore() (i.e. ->hwgroup).
* ide_register_hw() may unregister unrelated IDE ports if free ide_hwifs[]
slot cannot be found.
* When IDE host drivers are modular unregistered port may be re-used by
different host driver that owned it first causing subtle bugs.
Since we now have a proper warm-plug support remove these ioctls,
then remove no longer needed:
- ide_register_hw() and ide_hwif_restore() functions
- 'init_default' and 'restore' arguments of ide_unregister()
- zeroeing of hwif->{dma,extra}_* fields in ide_unregister()
As an added bonus IDE core code size shrinks by ~3kB (x86-32).
v2:
* fix ide_unregister() arguments in cleanup_module() (Andrew Morton).
v3:
* fix ide_unregister() arguments in palm_bk3710.c.
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
84 lines
1.8 KiB
C
84 lines
1.8 KiB
C
/*
|
|
* Copyright (c) 2003-2004 Simtec Electronics
|
|
* Ben Dooks <ben@simtec.co.uk>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License version 2 as
|
|
* published by the Free Software Foundation.
|
|
*
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/errno.h>
|
|
#include <linux/ide.h>
|
|
#include <linux/init.h>
|
|
|
|
#include <asm/mach-types.h>
|
|
|
|
#include <asm/io.h>
|
|
#include <asm/irq.h>
|
|
#include <asm/arch/map.h>
|
|
#include <asm/arch/bast-map.h>
|
|
#include <asm/arch/bast-irq.h>
|
|
|
|
static int __init bastide_register(unsigned int base, unsigned int aux, int irq)
|
|
{
|
|
ide_hwif_t *hwif;
|
|
hw_regs_t hw;
|
|
int i;
|
|
u8 idx[4] = { 0xff, 0xff, 0xff, 0xff };
|
|
|
|
memset(&hw, 0, sizeof(hw));
|
|
|
|
base += BAST_IDE_CS;
|
|
aux += BAST_IDE_CS;
|
|
|
|
for (i = IDE_DATA_OFFSET; i <= IDE_STATUS_OFFSET; i++) {
|
|
hw.io_ports[i] = (unsigned long)base;
|
|
base += 0x20;
|
|
}
|
|
|
|
hw.io_ports[IDE_CONTROL_OFFSET] = aux + (6 * 0x20);
|
|
hw.irq = irq;
|
|
|
|
hwif = ide_find_port(hw.io_ports[IDE_DATA_OFFSET]);
|
|
if (hwif == NULL)
|
|
goto out;
|
|
|
|
i = hwif->index;
|
|
|
|
if (hwif->present)
|
|
ide_unregister(i);
|
|
else if (!hwif->hold)
|
|
ide_init_port_data(hwif, i);
|
|
|
|
ide_init_port_hw(hwif, &hw);
|
|
hwif->quirkproc = NULL;
|
|
|
|
idx[0] = i;
|
|
|
|
ide_device_add(idx, NULL);
|
|
out:
|
|
return 0;
|
|
}
|
|
|
|
static int __init bastide_init(void)
|
|
{
|
|
/* we can treat the VR1000 and the BAST the same */
|
|
|
|
if (!(machine_is_bast() || machine_is_vr1000()))
|
|
return 0;
|
|
|
|
printk("BAST: IDE driver, (c) 2003-2004 Simtec Electronics\n");
|
|
|
|
bastide_register(BAST_VA_IDEPRI, BAST_VA_IDEPRIAUX, IRQ_IDE0);
|
|
bastide_register(BAST_VA_IDESEC, BAST_VA_IDESECAUX, IRQ_IDE1);
|
|
|
|
return 0;
|
|
}
|
|
|
|
module_init(bastide_init);
|
|
|
|
MODULE_AUTHOR("Ben Dooks <ben@simtec.co.uk>");
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_DESCRIPTION("Simtec BAST / Thorcom VR1000 IDE driver");
|