ac619f4eba
With CPU hotplug, there is a theoretical race between other CMOS (namely RTC) accesses and those done in the SMP secondary processor bringup path. I am unware of the problem having been noticed by anyone in practice, but it would very likely be rather spurious and very hard to reproduce. So to be on the safe side, acquire rtc_lock around those accesses. Signed-off-by: Jan Beulich <jbeulich@novell.com> Cc: John Stultz <john.stultz@linaro.org> Link: http://lkml.kernel.org/r/4E257AE7020000780004E2FF@nat28.tlf.novell.com Signed-off-by: Ingo Molnar <mingo@elte.hu>
68 lines
1.5 KiB
C
68 lines
1.5 KiB
C
/* two abstractions specific to kernel/smpboot.c, mainly to cater to visws
|
|
* which needs to alter them. */
|
|
|
|
static inline void smpboot_clear_io_apic_irqs(void)
|
|
{
|
|
#ifdef CONFIG_X86_IO_APIC
|
|
io_apic_irqs = 0;
|
|
#endif
|
|
}
|
|
|
|
static inline void smpboot_setup_warm_reset_vector(unsigned long start_eip)
|
|
{
|
|
unsigned long flags;
|
|
|
|
spin_lock_irqsave(&rtc_lock, flags);
|
|
CMOS_WRITE(0xa, 0xf);
|
|
spin_unlock_irqrestore(&rtc_lock, flags);
|
|
local_flush_tlb();
|
|
pr_debug("1.\n");
|
|
*((volatile unsigned short *)phys_to_virt(apic->trampoline_phys_high)) =
|
|
start_eip >> 4;
|
|
pr_debug("2.\n");
|
|
*((volatile unsigned short *)phys_to_virt(apic->trampoline_phys_low)) =
|
|
start_eip & 0xf;
|
|
pr_debug("3.\n");
|
|
}
|
|
|
|
static inline void smpboot_restore_warm_reset_vector(void)
|
|
{
|
|
unsigned long flags;
|
|
|
|
/*
|
|
* Install writable page 0 entry to set BIOS data area.
|
|
*/
|
|
local_flush_tlb();
|
|
|
|
/*
|
|
* Paranoid: Set warm reset code and vector here back
|
|
* to default values.
|
|
*/
|
|
spin_lock_irqsave(&rtc_lock, flags);
|
|
CMOS_WRITE(0, 0xf);
|
|
spin_unlock_irqrestore(&rtc_lock, flags);
|
|
|
|
*((volatile u32 *)phys_to_virt(apic->trampoline_phys_low)) = 0;
|
|
}
|
|
|
|
static inline void __init smpboot_setup_io_apic(void)
|
|
{
|
|
#ifdef CONFIG_X86_IO_APIC
|
|
/*
|
|
* Here we can be sure that there is an IO-APIC in the system. Let's
|
|
* go and set it up:
|
|
*/
|
|
if (!skip_ioapic_setup && nr_ioapics)
|
|
setup_IO_APIC();
|
|
else {
|
|
nr_ioapics = 0;
|
|
}
|
|
#endif
|
|
}
|
|
|
|
static inline void smpboot_clear_io_apic(void)
|
|
{
|
|
#ifdef CONFIG_X86_IO_APIC
|
|
nr_ioapics = 0;
|
|
#endif
|
|
}
|