30bdaafb64
commit 5c49056ad9f3c786f7716da2dd47e4488fc6bd25 upstream.
One of a class of bugs pointed out by Lars in a recent review.
iio_push_to_buffers_with_timestamp assumes the buffer used is aligned
to the size of the timestamp (8 bytes). This is not guaranteed in
this driver which uses an array of smaller elements on the stack.
As Lars also noted this anti pattern can involve a leak of data to
userspace and that indeed can happen here. We close both issues by
moving to a suitable structure in the iio_priv() data.
This data is allocated with kzalloc so no data can leak
apart from previous readings.
Explicit alignment of ts needed to ensure consistent padding
on all architectures (particularly x86_32 with it's 4 byte alignment
of s64)
Fixes:
|
||
|---|---|---|
| .. | ||
| am2315.c | ||
| dht11.c | ||
| hdc100x.c | ||
| hid-sensor-humidity.c | ||
| hts221.h | ||
| hts221_buffer.c | ||
| hts221_core.c | ||
| hts221_i2c.c | ||
| hts221_spi.c | ||
| htu21.c | ||
| Kconfig | ||
| Makefile | ||
| si7005.c | ||
| si7020.c | ||