9f67ad0fa7
commit eb1a148ef41d8ae8d9201efc3f1b145976290331 upstream.
One of a class of bugs pointed out by Lars in a recent review.
iio_push_to_buffers_with_timestamp assumes the buffer used is aligned
to the size of the timestamp (8 bytes). This is not guaranteed in
this driver which uses an array of smaller elements on the stack.
As Lars also noted this anti pattern can involve a leak of data to
userspace and that indeed can happen here. We close both issues by
moving to a suitable structure in the iio_priv() data with alignment
explicitly requested. This data is allocated with kzalloc so no
data can leak appart from previous readings.
The explicit alignment of ts is necessary to ensure consistent
padding for x86_32 in which the ts would otherwise be 4 byte aligned.
Fixes:
|
||
|---|---|---|
| .. | ||
| ams-iaq-core.c | ||
| atlas-ph-sensor.c | ||
| bme680.h | ||
| bme680_core.c | ||
| bme680_i2c.c | ||
| bme680_spi.c | ||
| ccs811.c | ||
| Kconfig | ||
| Makefile | ||
| vz89x.c | ||