1c594c05a7
On "/etc/init.d/capiutils stop", this oops happened. The oops happens on reading /proc/capi/controllers because capi_ctrl->procinfo is called for the wrongly not unregistered controller, which points to b1isa_procinfo(), which was removed on module unload. b1isa_exit() did not call b1isa_remove() for its controllers because io[0] == 0 on module unload despite having been 0x340 on module load. Besides, just removing the controllers that where added on module load time and not those that were added later via b1isa_add_card() is wrong too - the place where all added cards are found is isa_dev[]. relevant dmesg lines: [ 0.000000] Linux version 2.6.27.4 (w@shubashi) (gcc version 4.3.2 (Debian 4.3.2-1) ) #3 Thu Oct 30 16:49:03 CET 2008 [ 67.403555] CAPI Subsystem Rev 1.1.2.8 [ 68.529154] capifs: Rev 1.1.2.3 [ 68.563292] capi20: Rev 1.1.2.7: started up with major 68 (middleware+capifs) [ 77.026936] b1: revision 1.1.2.2 [ 77.049992] b1isa: revision 1.1.2.3 [ 77.722655] kcapi: Controller [001]: b1isa-340 attached [ 77.722671] b1isa: AVM B1 ISA at i/o 0x340, irq 5, revision 255 [ 81.272669] b1isa-340: card 1 "B1" ready. [ 81.272683] b1isa-340: card 1 Protocol: DSS1 [ 81.272689] b1isa-340: card 1 Linetype: point to multipoint [ 81.272695] b1isa-340: B1-card (3.11-03) now active [ 81.272702] kcapi: card [001] "b1isa-340" ready. [ 153.721281] kcapi: card [001] down. [ 154.151889] BUG: unable to handle kernel paging request at e87af000 [ 154.152081] IP: [<e87af000>] [ 154.153292] *pde = 2655b067 *pte = 00000000 [ 154.153307] Oops: 0000 [#1] [ 154.153360] Modules linked in: rfcomm l2cap ppdev lp ipt_MASQUERADE tun capi capifs kernelcapi ac battery nfsd exportfs nfs lockd nfs_acl sunrpc sit tunnel4 bridge stp llc ipt_REJECT ipt_LOG xt_tcpudp xt_state iptable_filter iptable_mangle iptable_nat nf_nat nf_conntrack_ipv4 nf_conntrack ip_tables x_tables nls_utf8 isofs nls_base zlib_inflate loop ipv6 netconsole snd_via82xx dvb_usb_dib0700 gameport dib7000p dib7000m dvb_usb snd_ac97_codec ac97_bus dvb_core mt2266 snd_pcm tuner_xc2028 dib3000mc dibx000_common mt2060 dib0070 snd_page_alloc snd_mpu401_uart snd_seq_midi snd_seq_midi_event btusb snd_rawmidi bluetooth snd_seq snd_timer snd_seq_device snd via686a i2c_viapro soundcore i2c_core parport_pc parport button dm_mirror dm_log dm_snapshot floppy sg ohci1394 uhci_hcd ehci_hcd 8139too mii ieee1394 usbcore sr_mod cdrom sd_mod thermal processor fan [last unloaded: b1] [ 154.153360] [ 154.153360] Pid: 4132, comm: capiinit Not tainted (2.6.27.4 #3) [ 154.153360] EIP: 0060:[<e87af000>] EFLAGS: 00010286 CPU: 0 [ 154.153360] EIP is at 0xe87af000 [ 154.153360] EAX: e6b9ccc8 EBX: e6b9ccc8 ECX: e87a0c67 EDX: e87af000 [ 154.153360] ESI: e142bbc0 EDI: e87a56e0 EBP: e0505f0c ESP: e0505ee4 [ 154.153360] DS: 007b ES: 007b FS: 0000 GS: 0033 SS: 0068 [ 154.153360] Process capiinit (pid: 4132, ti=e0504000 task=d1196cf0 task.ti=e0504000) [ 154.153360] Stack: e879f650 00000246 e0505ef4 c01472eb e0505f0c 00000246 e7001780 fffffff4 [ 154.153360] fffffff4 e142bbc0 e0505f48 c01a56c6 00000400 b805e000 d102dc80 e142bbe0 [ 154.153360] 00000000 e87a56e0 00000246 e12617ac 00000000 00000000 e1261760 fffffffb [ 154.153360] Call Trace: [ 154.153360] [<e879f650>] ? controller_show+0x20/0x90 [kernelcapi] [ 154.153360] [<c01472eb>] ? trace_hardirqs_on+0xb/0x10 [ 154.153360] [<c01a56c6>] ? seq_read+0x126/0x2f0 [ 154.153360] [<c01a55a0>] ? seq_read+0x0/0x2f0 [ 154.153360] [<c01c033c>] ? proc_reg_read+0x5c/0x90 [ 154.153360] [<c0189919>] ? vfs_read+0x99/0x140 [ 154.153360] [<c01c02e0>] ? proc_reg_read+0x0/0x90 [ 154.153360] [<c0189a7d>] ? sys_read+0x3d/0x70 [ 154.153360] [<c0103c3d>] ? sysenter_do_call+0x12/0x35 [ 154.153360] ======================= [ 154.153360] Code: Bad EIP value. [ 154.153360] EIP: [<e87af000>] 0xe87af000 SS:ESP 0068:e0505ee4 [ 154.153360] ---[ end trace 23750b6c2862de94 ]--- Signed-off-by: Wilfried Klaebe <linux-kernel@lebenslange-mailadresse.de> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Acked-by: Karsten Keil <kkeil@suse.de> Signed-off-by: David S. Miller <davem@davemloft.net>
243 lines
5.9 KiB
C
243 lines
5.9 KiB
C
/* $Id: b1isa.c,v 1.1.2.3 2004/02/10 01:07:12 keil Exp $
|
|
*
|
|
* Module for AVM B1 ISA-card.
|
|
*
|
|
* Copyright 1999 by Carsten Paeth <calle@calle.de>
|
|
*
|
|
* This software may be used and distributed according to the terms
|
|
* of the GNU General Public License, incorporated herein by reference.
|
|
*
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/skbuff.h>
|
|
#include <linux/delay.h>
|
|
#include <linux/mm.h>
|
|
#include <linux/interrupt.h>
|
|
#include <linux/ioport.h>
|
|
#include <linux/capi.h>
|
|
#include <linux/init.h>
|
|
#include <linux/pci.h>
|
|
#include <asm/io.h>
|
|
#include <linux/isdn/capicmd.h>
|
|
#include <linux/isdn/capiutil.h>
|
|
#include <linux/isdn/capilli.h>
|
|
#include "avmcard.h"
|
|
|
|
/* ------------------------------------------------------------- */
|
|
|
|
static char *revision = "$Revision: 1.1.2.3 $";
|
|
|
|
/* ------------------------------------------------------------- */
|
|
|
|
MODULE_DESCRIPTION("CAPI4Linux: Driver for AVM B1 ISA card");
|
|
MODULE_AUTHOR("Carsten Paeth");
|
|
MODULE_LICENSE("GPL");
|
|
|
|
/* ------------------------------------------------------------- */
|
|
|
|
static void b1isa_remove(struct pci_dev *pdev)
|
|
{
|
|
avmctrl_info *cinfo = pci_get_drvdata(pdev);
|
|
avmcard *card;
|
|
|
|
if (!cinfo)
|
|
return;
|
|
|
|
card = cinfo->card;
|
|
|
|
b1_reset(card->port);
|
|
b1_reset(card->port);
|
|
|
|
detach_capi_ctr(&cinfo->capi_ctrl);
|
|
free_irq(card->irq, card);
|
|
release_region(card->port, AVMB1_PORTLEN);
|
|
b1_free_card(card);
|
|
}
|
|
|
|
/* ------------------------------------------------------------- */
|
|
|
|
static char *b1isa_procinfo(struct capi_ctr *ctrl);
|
|
|
|
static int b1isa_probe(struct pci_dev *pdev)
|
|
{
|
|
avmctrl_info *cinfo;
|
|
avmcard *card;
|
|
int retval;
|
|
|
|
card = b1_alloc_card(1);
|
|
if (!card) {
|
|
printk(KERN_WARNING "b1isa: no memory.\n");
|
|
retval = -ENOMEM;
|
|
goto err;
|
|
}
|
|
|
|
cinfo = card->ctrlinfo;
|
|
|
|
card->port = pci_resource_start(pdev, 0);
|
|
card->irq = pdev->irq;
|
|
card->cardtype = avm_b1isa;
|
|
sprintf(card->name, "b1isa-%x", card->port);
|
|
|
|
if ( card->port != 0x150 && card->port != 0x250
|
|
&& card->port != 0x300 && card->port != 0x340) {
|
|
printk(KERN_WARNING "b1isa: invalid port 0x%x.\n", card->port);
|
|
retval = -EINVAL;
|
|
goto err_free;
|
|
}
|
|
if (b1_irq_table[card->irq & 0xf] == 0) {
|
|
printk(KERN_WARNING "b1isa: irq %d not valid.\n", card->irq);
|
|
retval = -EINVAL;
|
|
goto err_free;
|
|
}
|
|
if (!request_region(card->port, AVMB1_PORTLEN, card->name)) {
|
|
printk(KERN_WARNING "b1isa: ports 0x%03x-0x%03x in use.\n",
|
|
card->port, card->port + AVMB1_PORTLEN);
|
|
retval = -EBUSY;
|
|
goto err_free;
|
|
}
|
|
retval = request_irq(card->irq, b1_interrupt, 0, card->name, card);
|
|
if (retval) {
|
|
printk(KERN_ERR "b1isa: unable to get IRQ %d.\n", card->irq);
|
|
goto err_release_region;
|
|
}
|
|
b1_reset(card->port);
|
|
if ((retval = b1_detect(card->port, card->cardtype)) != 0) {
|
|
printk(KERN_NOTICE "b1isa: NO card at 0x%x (%d)\n",
|
|
card->port, retval);
|
|
retval = -ENODEV;
|
|
goto err_free_irq;
|
|
}
|
|
b1_reset(card->port);
|
|
b1_getrevision(card);
|
|
|
|
cinfo->capi_ctrl.owner = THIS_MODULE;
|
|
cinfo->capi_ctrl.driver_name = "b1isa";
|
|
cinfo->capi_ctrl.driverdata = cinfo;
|
|
cinfo->capi_ctrl.register_appl = b1_register_appl;
|
|
cinfo->capi_ctrl.release_appl = b1_release_appl;
|
|
cinfo->capi_ctrl.send_message = b1_send_message;
|
|
cinfo->capi_ctrl.load_firmware = b1_load_firmware;
|
|
cinfo->capi_ctrl.reset_ctr = b1_reset_ctr;
|
|
cinfo->capi_ctrl.procinfo = b1isa_procinfo;
|
|
cinfo->capi_ctrl.ctr_read_proc = b1ctl_read_proc;
|
|
strcpy(cinfo->capi_ctrl.name, card->name);
|
|
|
|
retval = attach_capi_ctr(&cinfo->capi_ctrl);
|
|
if (retval) {
|
|
printk(KERN_ERR "b1isa: attach controller failed.\n");
|
|
goto err_free_irq;
|
|
}
|
|
|
|
printk(KERN_INFO "b1isa: AVM B1 ISA at i/o %#x, irq %d, revision %d\n",
|
|
card->port, card->irq, card->revision);
|
|
|
|
pci_set_drvdata(pdev, cinfo);
|
|
return 0;
|
|
|
|
err_free_irq:
|
|
free_irq(card->irq, card);
|
|
err_release_region:
|
|
release_region(card->port, AVMB1_PORTLEN);
|
|
err_free:
|
|
b1_free_card(card);
|
|
err:
|
|
return retval;
|
|
}
|
|
|
|
static char *b1isa_procinfo(struct capi_ctr *ctrl)
|
|
{
|
|
avmctrl_info *cinfo = (avmctrl_info *)(ctrl->driverdata);
|
|
|
|
if (!cinfo)
|
|
return "";
|
|
sprintf(cinfo->infobuf, "%s %s 0x%x %d r%d",
|
|
cinfo->cardname[0] ? cinfo->cardname : "-",
|
|
cinfo->version[VER_DRIVER] ? cinfo->version[VER_DRIVER] : "-",
|
|
cinfo->card ? cinfo->card->port : 0x0,
|
|
cinfo->card ? cinfo->card->irq : 0,
|
|
cinfo->card ? cinfo->card->revision : 0
|
|
);
|
|
return cinfo->infobuf;
|
|
}
|
|
|
|
/* ------------------------------------------------------------- */
|
|
|
|
#define MAX_CARDS 4
|
|
static struct pci_dev isa_dev[MAX_CARDS];
|
|
static int io[MAX_CARDS];
|
|
static int irq[MAX_CARDS];
|
|
|
|
module_param_array(io, int, NULL, 0);
|
|
module_param_array(irq, int, NULL, 0);
|
|
MODULE_PARM_DESC(io, "I/O base address(es)");
|
|
MODULE_PARM_DESC(irq, "IRQ number(s) (assigned)");
|
|
|
|
static int b1isa_add_card(struct capi_driver *driver, capicardparams *data)
|
|
{
|
|
int i;
|
|
|
|
for (i = 0; i < MAX_CARDS; i++) {
|
|
if (isa_dev[i].resource[0].start)
|
|
continue;
|
|
|
|
isa_dev[i].resource[0].start = data->port;
|
|
isa_dev[i].irq = data->irq;
|
|
|
|
if (b1isa_probe(&isa_dev[i]) == 0)
|
|
return 0;
|
|
}
|
|
return -ENODEV;
|
|
}
|
|
|
|
static struct capi_driver capi_driver_b1isa = {
|
|
.name = "b1isa",
|
|
.revision = "1.0",
|
|
.add_card = b1isa_add_card,
|
|
};
|
|
|
|
static int __init b1isa_init(void)
|
|
{
|
|
char *p;
|
|
char rev[32];
|
|
int i;
|
|
|
|
if ((p = strchr(revision, ':')) != NULL && p[1]) {
|
|
strlcpy(rev, p + 2, 32);
|
|
if ((p = strchr(rev, '$')) != NULL && p > rev)
|
|
*(p-1) = 0;
|
|
} else
|
|
strcpy(rev, "1.0");
|
|
|
|
for (i = 0; i < MAX_CARDS; i++) {
|
|
if (!io[i])
|
|
break;
|
|
|
|
isa_dev[i].resource[0].start = io[i];
|
|
isa_dev[i].irq = irq[i];
|
|
|
|
if (b1isa_probe(&isa_dev[i]) != 0)
|
|
return -ENODEV;
|
|
}
|
|
|
|
strlcpy(capi_driver_b1isa.revision, rev, 32);
|
|
register_capi_driver(&capi_driver_b1isa);
|
|
printk(KERN_INFO "b1isa: revision %s\n", rev);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void __exit b1isa_exit(void)
|
|
{
|
|
int i;
|
|
|
|
for (i = 0; i < MAX_CARDS; i++) {
|
|
if (isa_dev[i].resource[0].start)
|
|
b1isa_remove(&isa_dev[i]);
|
|
}
|
|
unregister_capi_driver(&capi_driver_b1isa);
|
|
}
|
|
|
|
module_init(b1isa_init);
|
|
module_exit(b1isa_exit);
|