Maneesh Soni 41dde781f5 MIPS Kprobes: Fix OOPS in arch_prepare_kprobe() ... This patch fixes the arch_prepare_kprobe() on MIPS when it tries to find the instruction at the previous address to the probed address. The oops happens when the probed address is the first address in a kernel module and there is no previous address. The patch uses probe_kernel_read() to safely read the previous instruction. CPU 3 Unable to handle kernel paging request at virtual address ffffffffc0211ffc, epc == ffffffff81113204, ra == ffffffff8111511c Oops[#1]: Cpu 3 $ 0 : 0000000000000000 0000000000000001 ffffffffc0212000 0000000000000000 $ 4 : ffffffffc0220030 0000000000000000 0000000000000adf ffffffff81a3f898 $ 8 : ffffffffc0220030 ffffffffffffffff 000000000000ffff 0000000000004821 $12 : 000000000000000a ffffffff81105ddc ffffffff812927d0 0000000000000000 $16 : ffffffff81a40000 ffffffffc0220030 ffffffffc0220030 ffffffffc0212660 $20 : 0000000000000000 0000000000000008 efffffffffffffff ffffffffc0220000 $24 : 0000000000000002 ffffffff8139f5b0 $28 : a800000072adc000 a800000072adfca0 ffffffffc0220000 ffffffff8111511c Hi : 0000000000000000 Lo : 0000000000000000 epc : ffffffff81113204 arch_prepare_kprobe+0x1c/0xe8 Tainted: P ra : ffffffff8111511c register_kprobe+0x33c/0x730 Status: 10008ce3 KX SX UX KERNEL EXL IE Cause : 00800008 BadVA : ffffffffc0211ffc PrId : 000d9008 (Cavium Octeon II) Modules linked in: bpa_mem crashinfo pds tun cpumem ipv6 exportfs nfsd OOBnd(P) OOBhal(P) cvmx_mdio cvmx_gpio aipcmod(P) mtsmod procfs(P) utaker_mod dplr_pci hello atomicm_foo [last unloaded: sysmgr_hb] Process stapio (pid: 5603, threadinfo=a800000072adc000, task=a8000000722e0438, tls=000000002b4bcda0) Stack : ffffffff81a40000 ffffffff81a40000 ffffffffc0220030 ffffffff8111511c ffffffffc0218008 0000000000000001 ffffffffc0218008 0000000000000001 ffffffffc0220000 ffffffffc021efe8 1000000000000000 0000000000000008 efffffffffffffff ffffffffc0220000 ffffffffc0220000 ffffffffc021d500 0000000000000022 0000000000000002 1111000072be02b8 0000000000000000 00000000000015e6 00000000000015e6 00000000007d0f00 a800000072be02b8 0000000000000000 ffffffff811d16c8 a80000000382e3b0 ffffffff811d5ba0 ffffffff81b0a270 ffffffff81b0a270 ffffffffc0212000 0000000000000013 ffffffffc0220030 ffffffffc021ed00 a800000089114c80 000000007f90d590 a800000072adfe38 a800000089114c80 0000000010020000 0000000010020000 ... Call Trace: [<ffffffff81113204>] arch_prepare_kprobe+0x1c/0xe8 [<ffffffff8111511c>] register_kprobe+0x33c/0x730 [<ffffffffc021d500>] _stp_ctl_write_cmd+0x8e8/0xa88 [atomicm_foo] [<ffffffff812925cc>] vfs_write+0xb4/0x178 [<ffffffff81292828>] SyS_write+0x58/0x148 [<ffffffff81103844>] handle_sysn32+0x44/0x84 Code: ffb20010 ffb00000 dc820028 <8c44fffc> 8c500000 0c4449e0 0004203c 14400029 3c048199 Signed-off-by: Maneesh Soni <manesoni@cisco.com> Signed-off-by: Victor Kamensky <kamensky@cisco.com> Cc: David Daney <david.daney@cavium.com> Cc: ananth@in.ibm.com Cc: linux-kernel@vger.kernel.org Cc: linux-mips@linux-mips.org Patchwork: https://patchwork.linux-mips.org/patch/2915/ Signed-off-by: Ralf Baechle <ralf@linux-mips.org>		2011-12-07 22:04:03 +00:00
..
alchemy	Merge branch 'upstream' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus	2011-11-03 13:28:14 -07:00
ar7	MIPS: Mark cascade and low level interrupts IRQF_NO_THREAD	2011-09-21 17:52:15 +02:00
ath79
bcm47xx	mips: add export.h to files using EXPORT_SYMBOL/THIS_MODULE	2011-10-31 19:30:57 -04:00
bcm63xx	MIPS: Mark cascade and low level interrupts IRQF_NO_THREAD	2011-09-21 17:52:15 +02:00
boot
cavium-octeon	MIPS: Octeon: Fix compile error in arch/mips/cavium-octeon/flash_setup.c	2011-11-10 17:59:45 +00:00
cobalt	MIPS: Mark cascade and low level interrupts IRQF_NO_THREAD	2011-09-21 17:52:15 +02:00
configs
dec	MIPS: Mark cascade and low level interrupts IRQF_NO_THREAD	2011-09-21 17:52:15 +02:00
emma	MIPS: Yosemite, Emma: Fix off-by-two in arcs_cmdline buffer size check	2011-11-08 12:35:29 +00:00
fw
include/asm	MIPS: Hook up process_vm_readv and process_vm_writev system calls.	2011-11-09 00:07:56 +00:00
jazz
jz4740	MIPS: JZ4740: GPIO: Check correct IRQ in demux handler	2011-10-24 23:34:25 +01:00
kernel	MIPS Kprobes: Fix OOPS in arch_prepare_kprobe()	2011-12-07 22:04:03 +00:00
lantiq	MIPS: lantiq: use export.h in favour of module.h	2011-11-14 13:59:24 +00:00
lasat	MIPS: Mark cascade and low level interrupts IRQF_NO_THREAD	2011-09-21 17:52:15 +02:00
lib
loongson	mips: fix implicit smp.h usage in various files.	2011-10-31 19:30:55 -04:00
math-emu
mipssim
mm	MIPS: Remove __init from add_wired_entry()	2011-10-24 23:34:23 +01:00
mti-malta	MIPS: Mark cascade and low level interrupts IRQF_NO_THREAD	2011-09-21 17:52:15 +02:00
netlogic	MIPS: XLR, XLS: Add comment for smp setup	2011-10-24 23:34:25 +01:00
oprofile
pci	MIPS: lantiq: use export.h in favour of module.h	2011-11-14 13:59:24 +00:00
pmc-sierra	MIPS: Yosemite, Emma: Fix off-by-two in arcs_cmdline buffer size check	2011-11-08 12:35:29 +00:00
pnx833x
pnx8550	MIPS: PNX8550: Fix section mismatch	2011-10-20 15:00:18 +01:00
power
powertv	Merge branch 'modsplit-Oct31_2011' of git://git.kernel.org/pub/scm/linux/kernel/git/paulg/linux	2011-11-06 19:44:47 -08:00
rb532	mips: add export.h to files using EXPORT_SYMBOL/THIS_MODULE	2011-10-31 19:30:57 -04:00
sgi-ip22	MIPS: Mark cascade and low level interrupts IRQF_NO_THREAD	2011-09-21 17:52:15 +02:00
sgi-ip27	MIPS: IP27: Sort out section mismatch.	2011-10-20 15:00:18 +01:00
sgi-ip32
sibyte
sni	MIPS: Mark cascade and low level interrupts IRQF_NO_THREAD	2011-09-21 17:52:15 +02:00
txx9	mips: add export.h to files using EXPORT_SYMBOL/THIS_MODULE	2011-10-31 19:30:57 -04:00
vr41xx	mips: fix implicit smp.h usage in various files.	2011-10-31 19:30:55 -04:00
wrppmc
Kbuild
Kbuild.platforms
Kconfig	Merge branch 'trivial' of git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild	2011-11-06 18:54:53 -08:00
Kconfig.debug
Makefile	kbuild: Fix missing system calls check on mips.	2011-11-09 14:37:44 +01:00