30e748a507
This matters to any sort of device that is wired to one of the CPU interrupt pins on an SMP system. Typically the scenario is most easily triggered with the count/compare timer interrupt where the same interrupt number and thus irq_desc is used on each processor. CPU A CPU B do_IRQ() generic_handle_irq() handle_level_irq() spin_lock(desc_lock) set IRQ_INPROGRESS spin_unlock(desc_lock) do_IRQ() generic_handle_irq() handle_level_irq() spin_lock(desc_lock) IRQ_INPROGRESS set => bail out spin_lock(desc_lock) clear IRQ_INPROGRESS spin_unlock(desc_lock) In case of the cp0 compare interrupt this means the interrupt will be acked and not handled or re-armed on CPU b, so there won't be any timer interrupt until the count register wraps around. With kernels 2.6.20 ... 2.6.23 we usually were lucky that things were just working right on VSMP because the count registers are synchronized on bootup so it takes something that disables interrupts for a long time on one processor to trigger this one. For scenarios where an interrupt is multicasted or broadcasted over several CPUs the existing code was safe and the fix will break it. There is no way to know in the interrupt controller code because it is abstracted from the platform code. I think we do not have such a setup currently, so this should be ok. Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
48 lines
1.2 KiB
C
48 lines
1.2 KiB
C
/*
|
|
* Copyright (C) 2003 Ralf Baechle
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify it
|
|
* under the terms of the GNU General Public License as published by the
|
|
* Free Software Foundation; either version 2 of the License, or (at your
|
|
* option) any later version.
|
|
*
|
|
* Handler for RM7000 extended interrupts. These are a non-standard
|
|
* feature so we handle them separately from standard interrupts.
|
|
*/
|
|
#include <linux/init.h>
|
|
#include <linux/interrupt.h>
|
|
#include <linux/kernel.h>
|
|
|
|
#include <asm/irq_cpu.h>
|
|
#include <asm/mipsregs.h>
|
|
#include <asm/system.h>
|
|
|
|
static inline void unmask_rm7k_irq(unsigned int irq)
|
|
{
|
|
set_c0_intcontrol(0x100 << (irq - RM7K_CPU_IRQ_BASE));
|
|
}
|
|
|
|
static inline void mask_rm7k_irq(unsigned int irq)
|
|
{
|
|
clear_c0_intcontrol(0x100 << (irq - RM7K_CPU_IRQ_BASE));
|
|
}
|
|
|
|
static struct irq_chip rm7k_irq_controller = {
|
|
.name = "RM7000",
|
|
.ack = mask_rm7k_irq,
|
|
.mask = mask_rm7k_irq,
|
|
.mask_ack = mask_rm7k_irq,
|
|
.unmask = unmask_rm7k_irq,
|
|
};
|
|
|
|
void __init rm7k_cpu_irq_init(void)
|
|
{
|
|
int base = RM7K_CPU_IRQ_BASE;
|
|
int i;
|
|
|
|
clear_c0_intcontrol(0x00000f00); /* Mask all */
|
|
|
|
for (i = base; i < base + 4; i++)
|
|
set_irq_chip_and_handler(i, &rm7k_irq_controller,
|
|
handle_percpu_irq);
|
|
}
|