55a5542a54
The resume code checks if the resume cpu is the same as the suspend cpu. If not, and if it is also not possible to switch to the suspend cpu, an error message should be printed and the resume process should be stopped by loading a disabled wait psw. The current logic is broken in multiple ways, the message is never printed, and the disabled wait psw never loaded because the kernel panics before that: - sam31 and SIGP_SET_ARCHITECTURE to ESA mode is wrong, this will break on the first 64bit instruction in sclp_early_printk(). - The init stack should be used, but the stack pointer is not set up correctly (missing aghi %r15,-STACK_FRAME_OVERHEAD). - __sclp_early_printk() checks the sclp_init_state. If it is not sclp_init_state_uninitialized, it simply returns w/o printing anything. In the resumed kernel however, sclp_init_state will never be uninitialized. This patch fixes those issues by removing the sam31/ESA logic, adding a correct init stack pointer, and also introducing sclp_early_printk_force() to allow using sclp_early_printk() even when sclp_init_state is not uninitialized. Reviewed-by: Heiko Carstens <heiko.carstens@de.ibm.com> Signed-off-by: Gerald Schaefer <gerald.schaefer@de.ibm.com> Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
36 lines
824 B
C
36 lines
824 B
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* Copyright IBM Corp. 2017
|
|
*/
|
|
|
|
#include <linux/console.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/init.h>
|
|
#include <asm/sclp.h>
|
|
|
|
static void sclp_early_write(struct console *con, const char *s, unsigned int len)
|
|
{
|
|
__sclp_early_printk(s, len, 0);
|
|
}
|
|
|
|
static struct console sclp_early_console = {
|
|
.name = "earlysclp",
|
|
.write = sclp_early_write,
|
|
.flags = CON_PRINTBUFFER | CON_BOOT,
|
|
.index = -1,
|
|
};
|
|
|
|
static int __init setup_early_printk(char *buf)
|
|
{
|
|
if (early_console)
|
|
return 0;
|
|
/* Accept only "earlyprintk" and "earlyprintk=sclp" */
|
|
if (buf && strncmp(buf, "sclp", 4))
|
|
return 0;
|
|
if (!sclp.has_linemode && !sclp.has_vt220)
|
|
return 0;
|
|
early_console = &sclp_early_console;
|
|
register_console(early_console);
|
|
return 0;
|
|
}
|
|
early_param("earlyprintk", setup_early_printk);
|