297d716f62
Change the ownership of power_supply structure from each driver implementing the class to the power supply core. The patch changes power_supply_register() function thus all drivers implementing power supply class are adjusted. Each driver provides the implementation of power supply. However it should not be the owner of power supply class instance because it is exposed by core to other subsystems with power_supply_get_by_name(). These other subsystems have no knowledge when the driver will unregister the power supply. This leads to several issues when driver is unbound - mostly because user of power supply accesses freed memory. Instead let the core own the instance of struct 'power_supply'. Other users of this power supply will still access valid memory because it will be freed when device reference count reaches 0. Currently this means "it will leak" but power_supply_put() call in next patches will solve it. This solves invalid memory references in following race condition scenario: Thread 1: charger manager Thread 2: power supply driver, used by charger manager THREAD 1 (charger manager) THREAD 2 (power supply driver) ========================== ============================== psy = power_supply_get_by_name() Driver unbind, .remove power_supply_unregister() Device fully removed psy->get_property() The 'get_property' call is executed in invalid context because the driver was unbound and struct 'power_supply' memory was freed. This could be observed easily with charger manager driver (here compiled with max17040 fuel gauge): $ cat /sys/devices/virtual/power_supply/cm-battery/capacity & $ echo "1-0036" > /sys/bus/i2c/drivers/max17040/unbind [ 55.725123] Unable to handle kernel NULL pointer dereference at virtual address 00000000 [ 55.732584] pgd = d98d4000 [ 55.734060] [00000000] *pgd=5afa2831, *pte=00000000, *ppte=00000000 [ 55.740318] Internal error: Oops: 80000007 [#1] PREEMPT SMP ARM [ 55.746210] Modules linked in: [ 55.749259] CPU: 1 PID: 2936 Comm: cat Tainted: G W 3.19.0-rc1-next-20141226-00048-gf79f475f3c44-dirty #1496 [ 55.760190] Hardware name: SAMSUNG EXYNOS (Flattened Device Tree) [ 55.766270] task: d9b76f00 ti: daf54000 task.ti: daf54000 [ 55.771647] PC is at 0x0 [ 55.774182] LR is at charger_get_property+0x2f4/0x36c [ 55.779201] pc : [<00000000>] lr : [<c034b0b4>] psr: 60000013 [ 55.779201] sp : daf55e90 ip : 00000003 fp : 00000000 [ 55.790657] r10: 00000000 r9 : c06e2878 r8 : d9b26c68 [ 55.795865] r7 : dad81610 r6 : daec7410 r5 : daf55ebc r4 : 00000000 [ 55.802367] r3 : 00000000 r2 : daf55ebc r1 : 0000002a r0 : d9b26c68 [ 55.808879] Flags: nZCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment user [ 55.815994] Control: 10c5387d Table: 598d406a DAC: 00000015 [ 55.821723] Process cat (pid: 2936, stack limit = 0xdaf54210) [ 55.827451] Stack: (0xdaf55e90 to 0xdaf56000) [ 55.831795] 5e80: 60000013 c01459c4 0000002a c06f8ef8 [ 55.839956] 5ea0: db651000 c06f8ef8 daebac00 c04cb668 daebac08 c0346864 00000000 c01459c4 [ 55.848115] 5ec0: d99eaa80 c06f8ef8 00000fff 00001000 db651000 c027f25c c027f240 d99eaa80 [ 55.856274] 5ee0: d9a06c00 c0146218 daf55f18 00001000 d99eaa80 db4c18c0 00000001 00000001 [ 55.864468] 5f00: daf55f80 c0144c78 c0144c54 c0107f90 00015000 d99eaab0 00000000 00000000 [ 55.872603] 5f20: 000051c7 00000000 db4c18c0 c04a9370 00015000 00001000 daf55f80 00001000 [ 55.880763] 5f40: daf54000 00015000 00000000 c00e53dc db4c18c0 c00e548c 0000000d 00008124 [ 55.888937] 5f60: 00000001 00000000 00000000 db4c18c0 db4c18c0 00001000 00015000 c00e5550 [ 55.897099] 5f80: 00000000 00000000 00001000 00001000 00015000 00000003 00000003 c000f364 [ 55.905239] 5fa0: 00000000 c000f1a0 00001000 00015000 00000003 00015000 00001000 0001333c [ 55.913399] 5fc0: 00001000 00015000 00000003 00000003 00000002 00000000 00000000 00000000 [ 55.921560] 5fe0: 7fffe000 be999850 0000a225 b6f3c19c 60000010 00000003 00000000 00000000 [ 55.929744] [<c034b0b4>] (charger_get_property) from [<c0346864>] (power_supply_show_property+0x48/0x20c) [ 55.939286] [<c0346864>] (power_supply_show_property) from [<c027f25c>] (dev_attr_show+0x1c/0x48) [ 55.948130] [<c027f25c>] (dev_attr_show) from [<c0146218>] (sysfs_kf_seq_show+0x84/0x104) [ 55.956298] [<c0146218>] (sysfs_kf_seq_show) from [<c0144c78>] (kernfs_seq_show+0x24/0x28) [ 55.964536] [<c0144c78>] (kernfs_seq_show) from [<c0107f90>] (seq_read+0x1b0/0x484) [ 55.972172] [<c0107f90>] (seq_read) from [<c00e53dc>] (__vfs_read+0x18/0x4c) [ 55.979188] [<c00e53dc>] (__vfs_read) from [<c00e548c>] (vfs_read+0x7c/0x100) [ 55.986304] [<c00e548c>] (vfs_read) from [<c00e5550>] (SyS_read+0x40/0x8c) [ 55.993164] [<c00e5550>] (SyS_read) from [<c000f1a0>] (ret_fast_syscall+0x0/0x48) [ 56.000626] Code: bad PC value [ 56.011652] ---[ end trace 7b64343fbdae8ef1 ]--- Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> [for the nvec part] Reviewed-by: Marc Dietrich <marvin24@gmx.de> [for compal-laptop.c] Acked-by: Darren Hart <dvhart@linux.intel.com> [for the mfd part] Acked-by: Lee Jones <lee.jones@linaro.org> [for the hid part] Acked-by: Jiri Kosina <jkosina@suse.cz> [for the acpi part] Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by: Sebastian Reichel <sre@kernel.org>
383 lines
9.2 KiB
C
383 lines
9.2 KiB
C
/*
|
|
* max8903_charger.c - Maxim 8903 USB/Adapter Charger Driver
|
|
*
|
|
* Copyright (C) 2011 Samsung Electronics
|
|
* MyungJoo Ham <myungjoo.ham@samsung.com>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
|
|
*
|
|
*/
|
|
|
|
#include <linux/gpio.h>
|
|
#include <linux/interrupt.h>
|
|
#include <linux/module.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/power_supply.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/power/max8903_charger.h>
|
|
|
|
struct max8903_data {
|
|
struct max8903_pdata pdata;
|
|
struct device *dev;
|
|
struct power_supply *psy;
|
|
struct power_supply_desc psy_desc;
|
|
bool fault;
|
|
bool usb_in;
|
|
bool ta_in;
|
|
};
|
|
|
|
static enum power_supply_property max8903_charger_props[] = {
|
|
POWER_SUPPLY_PROP_STATUS, /* Charger status output */
|
|
POWER_SUPPLY_PROP_ONLINE, /* External power source */
|
|
POWER_SUPPLY_PROP_HEALTH, /* Fault or OK */
|
|
};
|
|
|
|
static int max8903_get_property(struct power_supply *psy,
|
|
enum power_supply_property psp,
|
|
union power_supply_propval *val)
|
|
{
|
|
struct max8903_data *data = power_supply_get_drvdata(psy);
|
|
|
|
switch (psp) {
|
|
case POWER_SUPPLY_PROP_STATUS:
|
|
val->intval = POWER_SUPPLY_STATUS_UNKNOWN;
|
|
if (data->pdata.chg) {
|
|
if (gpio_get_value(data->pdata.chg) == 0)
|
|
val->intval = POWER_SUPPLY_STATUS_CHARGING;
|
|
else if (data->usb_in || data->ta_in)
|
|
val->intval = POWER_SUPPLY_STATUS_NOT_CHARGING;
|
|
else
|
|
val->intval = POWER_SUPPLY_STATUS_DISCHARGING;
|
|
}
|
|
break;
|
|
case POWER_SUPPLY_PROP_ONLINE:
|
|
val->intval = 0;
|
|
if (data->usb_in || data->ta_in)
|
|
val->intval = 1;
|
|
break;
|
|
case POWER_SUPPLY_PROP_HEALTH:
|
|
val->intval = POWER_SUPPLY_HEALTH_GOOD;
|
|
if (data->fault)
|
|
val->intval = POWER_SUPPLY_HEALTH_UNSPEC_FAILURE;
|
|
break;
|
|
default:
|
|
return -EINVAL;
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
static irqreturn_t max8903_dcin(int irq, void *_data)
|
|
{
|
|
struct max8903_data *data = _data;
|
|
struct max8903_pdata *pdata = &data->pdata;
|
|
bool ta_in;
|
|
enum power_supply_type old_type;
|
|
|
|
ta_in = gpio_get_value(pdata->dok) ? false : true;
|
|
|
|
if (ta_in == data->ta_in)
|
|
return IRQ_HANDLED;
|
|
|
|
data->ta_in = ta_in;
|
|
|
|
/* Set Current-Limit-Mode 1:DC 0:USB */
|
|
if (pdata->dcm)
|
|
gpio_set_value(pdata->dcm, ta_in ? 1 : 0);
|
|
|
|
/* Charger Enable / Disable (cen is negated) */
|
|
if (pdata->cen)
|
|
gpio_set_value(pdata->cen, ta_in ? 0 :
|
|
(data->usb_in ? 0 : 1));
|
|
|
|
dev_dbg(data->dev, "TA(DC-IN) Charger %s.\n", ta_in ?
|
|
"Connected" : "Disconnected");
|
|
|
|
old_type = data->psy_desc.type;
|
|
|
|
if (data->ta_in)
|
|
data->psy_desc.type = POWER_SUPPLY_TYPE_MAINS;
|
|
else if (data->usb_in)
|
|
data->psy_desc.type = POWER_SUPPLY_TYPE_USB;
|
|
else
|
|
data->psy_desc.type = POWER_SUPPLY_TYPE_BATTERY;
|
|
|
|
if (old_type != data->psy_desc.type)
|
|
power_supply_changed(data->psy);
|
|
|
|
return IRQ_HANDLED;
|
|
}
|
|
|
|
static irqreturn_t max8903_usbin(int irq, void *_data)
|
|
{
|
|
struct max8903_data *data = _data;
|
|
struct max8903_pdata *pdata = &data->pdata;
|
|
bool usb_in;
|
|
enum power_supply_type old_type;
|
|
|
|
usb_in = gpio_get_value(pdata->uok) ? false : true;
|
|
|
|
if (usb_in == data->usb_in)
|
|
return IRQ_HANDLED;
|
|
|
|
data->usb_in = usb_in;
|
|
|
|
/* Do not touch Current-Limit-Mode */
|
|
|
|
/* Charger Enable / Disable (cen is negated) */
|
|
if (pdata->cen)
|
|
gpio_set_value(pdata->cen, usb_in ? 0 :
|
|
(data->ta_in ? 0 : 1));
|
|
|
|
dev_dbg(data->dev, "USB Charger %s.\n", usb_in ?
|
|
"Connected" : "Disconnected");
|
|
|
|
old_type = data->psy_desc.type;
|
|
|
|
if (data->ta_in)
|
|
data->psy_desc.type = POWER_SUPPLY_TYPE_MAINS;
|
|
else if (data->usb_in)
|
|
data->psy_desc.type = POWER_SUPPLY_TYPE_USB;
|
|
else
|
|
data->psy_desc.type = POWER_SUPPLY_TYPE_BATTERY;
|
|
|
|
if (old_type != data->psy_desc.type)
|
|
power_supply_changed(data->psy);
|
|
|
|
return IRQ_HANDLED;
|
|
}
|
|
|
|
static irqreturn_t max8903_fault(int irq, void *_data)
|
|
{
|
|
struct max8903_data *data = _data;
|
|
struct max8903_pdata *pdata = &data->pdata;
|
|
bool fault;
|
|
|
|
fault = gpio_get_value(pdata->flt) ? false : true;
|
|
|
|
if (fault == data->fault)
|
|
return IRQ_HANDLED;
|
|
|
|
data->fault = fault;
|
|
|
|
if (fault)
|
|
dev_err(data->dev, "Charger suffers a fault and stops.\n");
|
|
else
|
|
dev_err(data->dev, "Charger recovered from a fault.\n");
|
|
|
|
return IRQ_HANDLED;
|
|
}
|
|
|
|
static int max8903_probe(struct platform_device *pdev)
|
|
{
|
|
struct max8903_data *data;
|
|
struct device *dev = &pdev->dev;
|
|
struct max8903_pdata *pdata = pdev->dev.platform_data;
|
|
struct power_supply_config psy_cfg = {};
|
|
int ret = 0;
|
|
int gpio;
|
|
int ta_in = 0;
|
|
int usb_in = 0;
|
|
|
|
data = devm_kzalloc(dev, sizeof(struct max8903_data), GFP_KERNEL);
|
|
if (data == NULL) {
|
|
dev_err(dev, "Cannot allocate memory.\n");
|
|
return -ENOMEM;
|
|
}
|
|
memcpy(&data->pdata, pdata, sizeof(struct max8903_pdata));
|
|
data->dev = dev;
|
|
platform_set_drvdata(pdev, data);
|
|
|
|
if (pdata->dc_valid == false && pdata->usb_valid == false) {
|
|
dev_err(dev, "No valid power sources.\n");
|
|
ret = -EINVAL;
|
|
goto err;
|
|
}
|
|
|
|
if (pdata->dc_valid) {
|
|
if (pdata->dok && gpio_is_valid(pdata->dok) &&
|
|
pdata->dcm && gpio_is_valid(pdata->dcm)) {
|
|
gpio = pdata->dok; /* PULL_UPed Interrupt */
|
|
ta_in = gpio_get_value(gpio) ? 0 : 1;
|
|
|
|
gpio = pdata->dcm; /* Output */
|
|
gpio_set_value(gpio, ta_in);
|
|
} else {
|
|
dev_err(dev, "When DC is wired, DOK and DCM should"
|
|
" be wired as well.\n");
|
|
ret = -EINVAL;
|
|
goto err;
|
|
}
|
|
} else {
|
|
if (pdata->dcm) {
|
|
if (gpio_is_valid(pdata->dcm))
|
|
gpio_set_value(pdata->dcm, 0);
|
|
else {
|
|
dev_err(dev, "Invalid pin: dcm.\n");
|
|
ret = -EINVAL;
|
|
goto err;
|
|
}
|
|
}
|
|
}
|
|
|
|
if (pdata->usb_valid) {
|
|
if (pdata->uok && gpio_is_valid(pdata->uok)) {
|
|
gpio = pdata->uok;
|
|
usb_in = gpio_get_value(gpio) ? 0 : 1;
|
|
} else {
|
|
dev_err(dev, "When USB is wired, UOK should be wired."
|
|
"as well.\n");
|
|
ret = -EINVAL;
|
|
goto err;
|
|
}
|
|
}
|
|
|
|
if (pdata->cen) {
|
|
if (gpio_is_valid(pdata->cen)) {
|
|
gpio_set_value(pdata->cen, (ta_in || usb_in) ? 0 : 1);
|
|
} else {
|
|
dev_err(dev, "Invalid pin: cen.\n");
|
|
ret = -EINVAL;
|
|
goto err;
|
|
}
|
|
}
|
|
|
|
if (pdata->chg) {
|
|
if (!gpio_is_valid(pdata->chg)) {
|
|
dev_err(dev, "Invalid pin: chg.\n");
|
|
ret = -EINVAL;
|
|
goto err;
|
|
}
|
|
}
|
|
|
|
if (pdata->flt) {
|
|
if (!gpio_is_valid(pdata->flt)) {
|
|
dev_err(dev, "Invalid pin: flt.\n");
|
|
ret = -EINVAL;
|
|
goto err;
|
|
}
|
|
}
|
|
|
|
if (pdata->usus) {
|
|
if (!gpio_is_valid(pdata->usus)) {
|
|
dev_err(dev, "Invalid pin: usus.\n");
|
|
ret = -EINVAL;
|
|
goto err;
|
|
}
|
|
}
|
|
|
|
data->fault = false;
|
|
data->ta_in = ta_in;
|
|
data->usb_in = usb_in;
|
|
|
|
data->psy_desc.name = "max8903_charger";
|
|
data->psy_desc.type = (ta_in) ? POWER_SUPPLY_TYPE_MAINS :
|
|
((usb_in) ? POWER_SUPPLY_TYPE_USB :
|
|
POWER_SUPPLY_TYPE_BATTERY);
|
|
data->psy_desc.get_property = max8903_get_property;
|
|
data->psy_desc.properties = max8903_charger_props;
|
|
data->psy_desc.num_properties = ARRAY_SIZE(max8903_charger_props);
|
|
|
|
psy_cfg.drv_data = data;
|
|
|
|
data->psy = power_supply_register(dev, &data->psy_desc, &psy_cfg);
|
|
if (IS_ERR(data->psy)) {
|
|
dev_err(dev, "failed: power supply register.\n");
|
|
ret = PTR_ERR(data->psy);
|
|
goto err;
|
|
}
|
|
|
|
if (pdata->dc_valid) {
|
|
ret = request_threaded_irq(gpio_to_irq(pdata->dok),
|
|
NULL, max8903_dcin,
|
|
IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING,
|
|
"MAX8903 DC IN", data);
|
|
if (ret) {
|
|
dev_err(dev, "Cannot request irq %d for DC (%d)\n",
|
|
gpio_to_irq(pdata->dok), ret);
|
|
goto err_psy;
|
|
}
|
|
}
|
|
|
|
if (pdata->usb_valid) {
|
|
ret = request_threaded_irq(gpio_to_irq(pdata->uok),
|
|
NULL, max8903_usbin,
|
|
IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING,
|
|
"MAX8903 USB IN", data);
|
|
if (ret) {
|
|
dev_err(dev, "Cannot request irq %d for USB (%d)\n",
|
|
gpio_to_irq(pdata->uok), ret);
|
|
goto err_dc_irq;
|
|
}
|
|
}
|
|
|
|
if (pdata->flt) {
|
|
ret = request_threaded_irq(gpio_to_irq(pdata->flt),
|
|
NULL, max8903_fault,
|
|
IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING,
|
|
"MAX8903 Fault", data);
|
|
if (ret) {
|
|
dev_err(dev, "Cannot request irq %d for Fault (%d)\n",
|
|
gpio_to_irq(pdata->flt), ret);
|
|
goto err_usb_irq;
|
|
}
|
|
}
|
|
|
|
return 0;
|
|
|
|
err_usb_irq:
|
|
if (pdata->usb_valid)
|
|
free_irq(gpio_to_irq(pdata->uok), data);
|
|
err_dc_irq:
|
|
if (pdata->dc_valid)
|
|
free_irq(gpio_to_irq(pdata->dok), data);
|
|
err_psy:
|
|
power_supply_unregister(data->psy);
|
|
err:
|
|
return ret;
|
|
}
|
|
|
|
static int max8903_remove(struct platform_device *pdev)
|
|
{
|
|
struct max8903_data *data = platform_get_drvdata(pdev);
|
|
|
|
if (data) {
|
|
struct max8903_pdata *pdata = &data->pdata;
|
|
|
|
if (pdata->flt)
|
|
free_irq(gpio_to_irq(pdata->flt), data);
|
|
if (pdata->usb_valid)
|
|
free_irq(gpio_to_irq(pdata->uok), data);
|
|
if (pdata->dc_valid)
|
|
free_irq(gpio_to_irq(pdata->dok), data);
|
|
power_supply_unregister(data->psy);
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static struct platform_driver max8903_driver = {
|
|
.probe = max8903_probe,
|
|
.remove = max8903_remove,
|
|
.driver = {
|
|
.name = "max8903-charger",
|
|
},
|
|
};
|
|
|
|
module_platform_driver(max8903_driver);
|
|
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_DESCRIPTION("MAX8903 Charger Driver");
|
|
MODULE_AUTHOR("MyungJoo Ham <myungjoo.ham@samsung.com>");
|
|
MODULE_ALIAS("platform:max8903-charger");
|