253d3b139a
Error handling code following a kmalloc should free the allocated data. The semantic match that finds the problem is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @r exists@ local idexpression x; statement S; expression E; identifier f,l; position p1,p2; expression *ptr != NULL; @@ ( if ((x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...)) == NULL) S | x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...); ... if (x == NULL) S ) <... when != x when != if (...) { <+...x...+> } x->f = E ...> ( return \(0\|<+...x...+>\|ptr\); | return@p2 ...; ) @script:python@ p1 << r.p1; p2 << r.p2; @@ print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> |
||
|---|---|---|
| .. | ||
| go7007-driver.c | ||
| go7007-fw.c | ||
| go7007-i2c.c | ||
| go7007-priv.h | ||
| go7007-usb.c | ||
| go7007-v4l2.c | ||
| go7007.h | ||
| go7007.txt | ||
| Kconfig | ||
| Makefile | ||
| README | ||
| s2250-board.c | ||
| s2250-loader.c | ||
| saa7134-go7007.c | ||
| snd-go7007.c | ||
| wis-i2c.h | ||
| wis-ov7640.c | ||
| wis-saa7113.c | ||
| wis-saa7115.c | ||
| wis-sony-tuner.c | ||
| wis-tw2804.c | ||
| wis-tw9903.c | ||
| wis-uda1342.c | ||
Todo: - checkpatch.pl cleanups - sparse cleanups - lots of little modules, should be merged together and added to the build. - testing? - handle churn in v4l layer. Please send patchs to Greg Kroah-Hartman <greg@kroah.com> and Cc: Ross Cohen <rcohen@snurgle.org> as well.