99b7623380
Setting ->owner as done currently (pde->owner = THIS_MODULE) is racy as correctly noted at bug #12454. Someone can lookup entry with NULL ->owner, thus not pinning enything, and release it later resulting in module refcount underflow. We can keep ->owner and supply it at registration time like ->proc_fops and ->data. But this leaves ->owner as easy-manipulative field (just one C assignment) and somebody will forget to unpin previous/pin current module when switching ->owner. ->proc_fops is declared as "const" which should give some thoughts. ->read_proc/->write_proc were just fixed to not require ->owner for protection. rmmod'ed directories will be empty and return "." and ".." -- no harm. And directories with tricky enough readdir and lookup shouldn't be modular. We definitely don't want such modular code. Removing ->owner will also make PDE smaller. So, let's nuke it. Kudos to Jeff Layton for reminding about this, let's say, oversight. http://bugzilla.kernel.org/show_bug.cgi?id=12454 Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> |
||
|---|---|---|
| .. | ||
| adapter.h | ||
| capi20.h | ||
| capidtmf.c | ||
| capidtmf.h | ||
| capifunc.c | ||
| capifunc.h | ||
| capimain.c | ||
| cardtype.h | ||
| cp_vers.h | ||
| dadapter.c | ||
| dadapter.h | ||
| debug.c | ||
| debug_if.h | ||
| debuglib.c | ||
| debuglib.h | ||
| dfifo.h | ||
| di.c | ||
| di.h | ||
| di_dbg.h | ||
| di_defs.h | ||
| did_vers.h | ||
| diddfunc.c | ||
| diva.c | ||
| diva.h | ||
| diva_didd.c | ||
| diva_dma.c | ||
| diva_dma.h | ||
| diva_pci.h | ||
| divacapi.h | ||
| divamnt.c | ||
| divasfunc.c | ||
| divasi.c | ||
| divasmain.c | ||
| divasproc.c | ||
| divasync.h | ||
| dqueue.c | ||
| dqueue.h | ||
| dsp_defs.h | ||
| dsp_tst.h | ||
| dspdids.h | ||
| dsrv4bri.h | ||
| dsrv_bri.h | ||
| dsrv_pri.h | ||
| entity.h | ||
| helpers.h | ||
| idifunc.c | ||
| io.c | ||
| io.h | ||
| istream.c | ||
| Kconfig | ||
| kst_ifc.h | ||
| maintidi.c | ||
| maintidi.h | ||
| Makefile | ||
| man_defs.h | ||
| mdm_msg.h | ||
| message.c | ||
| mi_pc.h | ||
| mntfunc.c | ||
| os_4bri.c | ||
| os_4bri.h | ||
| os_bri.c | ||
| os_bri.h | ||
| os_capi.h | ||
| os_pri.c | ||
| os_pri.h | ||
| pc.h | ||
| pc_init.h | ||
| pc_maint.h | ||
| pkmaint.h | ||
| platform.h | ||
| pr_pc.h | ||
| s_4bri.c | ||
| s_bri.c | ||
| s_pri.c | ||
| sdp_hdr.h | ||
| um_idi.c | ||
| um_idi.h | ||
| um_xdi.h | ||
| xdi_adapter.h | ||
| xdi_msg.h | ||
| xdi_vers.h | ||