297d716f62
Change the ownership of power_supply structure from each driver implementing the class to the power supply core. The patch changes power_supply_register() function thus all drivers implementing power supply class are adjusted. Each driver provides the implementation of power supply. However it should not be the owner of power supply class instance because it is exposed by core to other subsystems with power_supply_get_by_name(). These other subsystems have no knowledge when the driver will unregister the power supply. This leads to several issues when driver is unbound - mostly because user of power supply accesses freed memory. Instead let the core own the instance of struct 'power_supply'. Other users of this power supply will still access valid memory because it will be freed when device reference count reaches 0. Currently this means "it will leak" but power_supply_put() call in next patches will solve it. This solves invalid memory references in following race condition scenario: Thread 1: charger manager Thread 2: power supply driver, used by charger manager THREAD 1 (charger manager) THREAD 2 (power supply driver) ========================== ============================== psy = power_supply_get_by_name() Driver unbind, .remove power_supply_unregister() Device fully removed psy->get_property() The 'get_property' call is executed in invalid context because the driver was unbound and struct 'power_supply' memory was freed. This could be observed easily with charger manager driver (here compiled with max17040 fuel gauge): $ cat /sys/devices/virtual/power_supply/cm-battery/capacity & $ echo "1-0036" > /sys/bus/i2c/drivers/max17040/unbind [ 55.725123] Unable to handle kernel NULL pointer dereference at virtual address 00000000 [ 55.732584] pgd = d98d4000 [ 55.734060] [00000000] *pgd=5afa2831, *pte=00000000, *ppte=00000000 [ 55.740318] Internal error: Oops: 80000007 [#1] PREEMPT SMP ARM [ 55.746210] Modules linked in: [ 55.749259] CPU: 1 PID: 2936 Comm: cat Tainted: G W 3.19.0-rc1-next-20141226-00048-gf79f475f3c44-dirty #1496 [ 55.760190] Hardware name: SAMSUNG EXYNOS (Flattened Device Tree) [ 55.766270] task: d9b76f00 ti: daf54000 task.ti: daf54000 [ 55.771647] PC is at 0x0 [ 55.774182] LR is at charger_get_property+0x2f4/0x36c [ 55.779201] pc : [<00000000>] lr : [<c034b0b4>] psr: 60000013 [ 55.779201] sp : daf55e90 ip : 00000003 fp : 00000000 [ 55.790657] r10: 00000000 r9 : c06e2878 r8 : d9b26c68 [ 55.795865] r7 : dad81610 r6 : daec7410 r5 : daf55ebc r4 : 00000000 [ 55.802367] r3 : 00000000 r2 : daf55ebc r1 : 0000002a r0 : d9b26c68 [ 55.808879] Flags: nZCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment user [ 55.815994] Control: 10c5387d Table: 598d406a DAC: 00000015 [ 55.821723] Process cat (pid: 2936, stack limit = 0xdaf54210) [ 55.827451] Stack: (0xdaf55e90 to 0xdaf56000) [ 55.831795] 5e80: 60000013 c01459c4 0000002a c06f8ef8 [ 55.839956] 5ea0: db651000 c06f8ef8 daebac00 c04cb668 daebac08 c0346864 00000000 c01459c4 [ 55.848115] 5ec0: d99eaa80 c06f8ef8 00000fff 00001000 db651000 c027f25c c027f240 d99eaa80 [ 55.856274] 5ee0: d9a06c00 c0146218 daf55f18 00001000 d99eaa80 db4c18c0 00000001 00000001 [ 55.864468] 5f00: daf55f80 c0144c78 c0144c54 c0107f90 00015000 d99eaab0 00000000 00000000 [ 55.872603] 5f20: 000051c7 00000000 db4c18c0 c04a9370 00015000 00001000 daf55f80 00001000 [ 55.880763] 5f40: daf54000 00015000 00000000 c00e53dc db4c18c0 c00e548c 0000000d 00008124 [ 55.888937] 5f60: 00000001 00000000 00000000 db4c18c0 db4c18c0 00001000 00015000 c00e5550 [ 55.897099] 5f80: 00000000 00000000 00001000 00001000 00015000 00000003 00000003 c000f364 [ 55.905239] 5fa0: 00000000 c000f1a0 00001000 00015000 00000003 00015000 00001000 0001333c [ 55.913399] 5fc0: 00001000 00015000 00000003 00000003 00000002 00000000 00000000 00000000 [ 55.921560] 5fe0: 7fffe000 be999850 0000a225 b6f3c19c 60000010 00000003 00000000 00000000 [ 55.929744] [<c034b0b4>] (charger_get_property) from [<c0346864>] (power_supply_show_property+0x48/0x20c) [ 55.939286] [<c0346864>] (power_supply_show_property) from [<c027f25c>] (dev_attr_show+0x1c/0x48) [ 55.948130] [<c027f25c>] (dev_attr_show) from [<c0146218>] (sysfs_kf_seq_show+0x84/0x104) [ 55.956298] [<c0146218>] (sysfs_kf_seq_show) from [<c0144c78>] (kernfs_seq_show+0x24/0x28) [ 55.964536] [<c0144c78>] (kernfs_seq_show) from [<c0107f90>] (seq_read+0x1b0/0x484) [ 55.972172] [<c0107f90>] (seq_read) from [<c00e53dc>] (__vfs_read+0x18/0x4c) [ 55.979188] [<c00e53dc>] (__vfs_read) from [<c00e548c>] (vfs_read+0x7c/0x100) [ 55.986304] [<c00e548c>] (vfs_read) from [<c00e5550>] (SyS_read+0x40/0x8c) [ 55.993164] [<c00e5550>] (SyS_read) from [<c000f1a0>] (ret_fast_syscall+0x0/0x48) [ 56.000626] Code: bad PC value [ 56.011652] ---[ end trace 7b64343fbdae8ef1 ]--- Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> [for the nvec part] Reviewed-by: Marc Dietrich <marvin24@gmx.de> [for compal-laptop.c] Acked-by: Darren Hart <dvhart@linux.intel.com> [for the mfd part] Acked-by: Lee Jones <lee.jones@linaro.org> [for the hid part] Acked-by: Jiri Kosina <jkosina@suse.cz> [for the acpi part] Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by: Sebastian Reichel <sre@kernel.org>
421 lines
10 KiB
C
421 lines
10 KiB
C
/*
|
|
* Battery and Power Management code for the Sharp SL-5x00
|
|
*
|
|
* Copyright (C) 2009 Thomas Kunze
|
|
*
|
|
* based on tosa_battery.c
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License version 2 as
|
|
* published by the Free Software Foundation.
|
|
*
|
|
*/
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/power_supply.h>
|
|
#include <linux/delay.h>
|
|
#include <linux/spinlock.h>
|
|
#include <linux/interrupt.h>
|
|
#include <linux/gpio.h>
|
|
#include <linux/mfd/ucb1x00.h>
|
|
|
|
#include <asm/mach/sharpsl_param.h>
|
|
#include <asm/mach-types.h>
|
|
#include <mach/collie.h>
|
|
|
|
static DEFINE_MUTEX(bat_lock); /* protects gpio pins */
|
|
static struct work_struct bat_work;
|
|
static struct ucb1x00 *ucb;
|
|
static int wakeup_enabled;
|
|
|
|
struct collie_bat {
|
|
int status;
|
|
struct power_supply *psy;
|
|
int full_chrg;
|
|
|
|
struct mutex work_lock; /* protects data */
|
|
|
|
bool (*is_present)(struct collie_bat *bat);
|
|
int gpio_full;
|
|
int gpio_charge_on;
|
|
|
|
int technology;
|
|
|
|
int gpio_bat;
|
|
int adc_bat;
|
|
int adc_bat_divider;
|
|
int bat_max;
|
|
int bat_min;
|
|
|
|
int gpio_temp;
|
|
int adc_temp;
|
|
int adc_temp_divider;
|
|
};
|
|
|
|
static struct collie_bat collie_bat_main;
|
|
|
|
static unsigned long collie_read_bat(struct collie_bat *bat)
|
|
{
|
|
unsigned long value = 0;
|
|
|
|
if (bat->gpio_bat < 0 || bat->adc_bat < 0)
|
|
return 0;
|
|
mutex_lock(&bat_lock);
|
|
gpio_set_value(bat->gpio_bat, 1);
|
|
msleep(5);
|
|
ucb1x00_adc_enable(ucb);
|
|
value = ucb1x00_adc_read(ucb, bat->adc_bat, UCB_SYNC);
|
|
ucb1x00_adc_disable(ucb);
|
|
gpio_set_value(bat->gpio_bat, 0);
|
|
mutex_unlock(&bat_lock);
|
|
value = value * 1000000 / bat->adc_bat_divider;
|
|
|
|
return value;
|
|
}
|
|
|
|
static unsigned long collie_read_temp(struct collie_bat *bat)
|
|
{
|
|
unsigned long value = 0;
|
|
if (bat->gpio_temp < 0 || bat->adc_temp < 0)
|
|
return 0;
|
|
|
|
mutex_lock(&bat_lock);
|
|
gpio_set_value(bat->gpio_temp, 1);
|
|
msleep(5);
|
|
ucb1x00_adc_enable(ucb);
|
|
value = ucb1x00_adc_read(ucb, bat->adc_temp, UCB_SYNC);
|
|
ucb1x00_adc_disable(ucb);
|
|
gpio_set_value(bat->gpio_temp, 0);
|
|
mutex_unlock(&bat_lock);
|
|
|
|
value = value * 10000 / bat->adc_temp_divider;
|
|
|
|
return value;
|
|
}
|
|
|
|
static int collie_bat_get_property(struct power_supply *psy,
|
|
enum power_supply_property psp,
|
|
union power_supply_propval *val)
|
|
{
|
|
int ret = 0;
|
|
struct collie_bat *bat = power_supply_get_drvdata(psy);
|
|
|
|
if (bat->is_present && !bat->is_present(bat)
|
|
&& psp != POWER_SUPPLY_PROP_PRESENT) {
|
|
return -ENODEV;
|
|
}
|
|
|
|
switch (psp) {
|
|
case POWER_SUPPLY_PROP_STATUS:
|
|
val->intval = bat->status;
|
|
break;
|
|
case POWER_SUPPLY_PROP_TECHNOLOGY:
|
|
val->intval = bat->technology;
|
|
break;
|
|
case POWER_SUPPLY_PROP_VOLTAGE_NOW:
|
|
val->intval = collie_read_bat(bat);
|
|
break;
|
|
case POWER_SUPPLY_PROP_VOLTAGE_MAX:
|
|
if (bat->full_chrg == -1)
|
|
val->intval = bat->bat_max;
|
|
else
|
|
val->intval = bat->full_chrg;
|
|
break;
|
|
case POWER_SUPPLY_PROP_VOLTAGE_MAX_DESIGN:
|
|
val->intval = bat->bat_max;
|
|
break;
|
|
case POWER_SUPPLY_PROP_VOLTAGE_MIN_DESIGN:
|
|
val->intval = bat->bat_min;
|
|
break;
|
|
case POWER_SUPPLY_PROP_TEMP:
|
|
val->intval = collie_read_temp(bat);
|
|
break;
|
|
case POWER_SUPPLY_PROP_PRESENT:
|
|
val->intval = bat->is_present ? bat->is_present(bat) : 1;
|
|
break;
|
|
default:
|
|
ret = -EINVAL;
|
|
break;
|
|
}
|
|
return ret;
|
|
}
|
|
|
|
static void collie_bat_external_power_changed(struct power_supply *psy)
|
|
{
|
|
schedule_work(&bat_work);
|
|
}
|
|
|
|
static irqreturn_t collie_bat_gpio_isr(int irq, void *data)
|
|
{
|
|
pr_info("collie_bat_gpio irq\n");
|
|
schedule_work(&bat_work);
|
|
return IRQ_HANDLED;
|
|
}
|
|
|
|
static void collie_bat_update(struct collie_bat *bat)
|
|
{
|
|
int old;
|
|
struct power_supply *psy = bat->psy;
|
|
|
|
mutex_lock(&bat->work_lock);
|
|
|
|
old = bat->status;
|
|
|
|
if (bat->is_present && !bat->is_present(bat)) {
|
|
printk(KERN_NOTICE "%s not present\n", psy->desc->name);
|
|
bat->status = POWER_SUPPLY_STATUS_UNKNOWN;
|
|
bat->full_chrg = -1;
|
|
} else if (power_supply_am_i_supplied(psy)) {
|
|
if (bat->status == POWER_SUPPLY_STATUS_DISCHARGING) {
|
|
gpio_set_value(bat->gpio_charge_on, 1);
|
|
mdelay(15);
|
|
}
|
|
|
|
if (gpio_get_value(bat->gpio_full)) {
|
|
if (old == POWER_SUPPLY_STATUS_CHARGING ||
|
|
bat->full_chrg == -1)
|
|
bat->full_chrg = collie_read_bat(bat);
|
|
|
|
gpio_set_value(bat->gpio_charge_on, 0);
|
|
bat->status = POWER_SUPPLY_STATUS_FULL;
|
|
} else {
|
|
gpio_set_value(bat->gpio_charge_on, 1);
|
|
bat->status = POWER_SUPPLY_STATUS_CHARGING;
|
|
}
|
|
} else {
|
|
gpio_set_value(bat->gpio_charge_on, 0);
|
|
bat->status = POWER_SUPPLY_STATUS_DISCHARGING;
|
|
}
|
|
|
|
if (old != bat->status)
|
|
power_supply_changed(psy);
|
|
|
|
mutex_unlock(&bat->work_lock);
|
|
}
|
|
|
|
static void collie_bat_work(struct work_struct *work)
|
|
{
|
|
collie_bat_update(&collie_bat_main);
|
|
}
|
|
|
|
|
|
static enum power_supply_property collie_bat_main_props[] = {
|
|
POWER_SUPPLY_PROP_STATUS,
|
|
POWER_SUPPLY_PROP_TECHNOLOGY,
|
|
POWER_SUPPLY_PROP_VOLTAGE_MIN_DESIGN,
|
|
POWER_SUPPLY_PROP_VOLTAGE_NOW,
|
|
POWER_SUPPLY_PROP_VOLTAGE_MAX_DESIGN,
|
|
POWER_SUPPLY_PROP_VOLTAGE_MAX,
|
|
POWER_SUPPLY_PROP_PRESENT,
|
|
POWER_SUPPLY_PROP_TEMP,
|
|
};
|
|
|
|
static enum power_supply_property collie_bat_bu_props[] = {
|
|
POWER_SUPPLY_PROP_STATUS,
|
|
POWER_SUPPLY_PROP_TECHNOLOGY,
|
|
POWER_SUPPLY_PROP_VOLTAGE_MIN_DESIGN,
|
|
POWER_SUPPLY_PROP_VOLTAGE_NOW,
|
|
POWER_SUPPLY_PROP_VOLTAGE_MAX_DESIGN,
|
|
POWER_SUPPLY_PROP_VOLTAGE_MAX,
|
|
POWER_SUPPLY_PROP_PRESENT,
|
|
};
|
|
|
|
static const struct power_supply_desc collie_bat_main_desc = {
|
|
.name = "main-battery",
|
|
.type = POWER_SUPPLY_TYPE_BATTERY,
|
|
.properties = collie_bat_main_props,
|
|
.num_properties = ARRAY_SIZE(collie_bat_main_props),
|
|
.get_property = collie_bat_get_property,
|
|
.external_power_changed = collie_bat_external_power_changed,
|
|
.use_for_apm = 1,
|
|
};
|
|
|
|
static struct collie_bat collie_bat_main = {
|
|
.status = POWER_SUPPLY_STATUS_DISCHARGING,
|
|
.full_chrg = -1,
|
|
.psy = NULL,
|
|
|
|
.gpio_full = COLLIE_GPIO_CO,
|
|
.gpio_charge_on = COLLIE_GPIO_CHARGE_ON,
|
|
|
|
.technology = POWER_SUPPLY_TECHNOLOGY_LIPO,
|
|
|
|
.gpio_bat = COLLIE_GPIO_MBAT_ON,
|
|
.adc_bat = UCB_ADC_INP_AD1,
|
|
.adc_bat_divider = 155,
|
|
.bat_max = 4310000,
|
|
.bat_min = 1551 * 1000000 / 414,
|
|
|
|
.gpio_temp = COLLIE_GPIO_TMP_ON,
|
|
.adc_temp = UCB_ADC_INP_AD0,
|
|
.adc_temp_divider = 10000,
|
|
};
|
|
|
|
static const struct power_supply_desc collie_bat_bu_desc = {
|
|
.name = "backup-battery",
|
|
.type = POWER_SUPPLY_TYPE_BATTERY,
|
|
.properties = collie_bat_bu_props,
|
|
.num_properties = ARRAY_SIZE(collie_bat_bu_props),
|
|
.get_property = collie_bat_get_property,
|
|
.external_power_changed = collie_bat_external_power_changed,
|
|
};
|
|
|
|
static struct collie_bat collie_bat_bu = {
|
|
.status = POWER_SUPPLY_STATUS_UNKNOWN,
|
|
.full_chrg = -1,
|
|
.psy = NULL,
|
|
|
|
.gpio_full = -1,
|
|
.gpio_charge_on = -1,
|
|
|
|
.technology = POWER_SUPPLY_TECHNOLOGY_LiMn,
|
|
|
|
.gpio_bat = COLLIE_GPIO_BBAT_ON,
|
|
.adc_bat = UCB_ADC_INP_AD1,
|
|
.adc_bat_divider = 155,
|
|
.bat_max = 3000000,
|
|
.bat_min = 1900000,
|
|
|
|
.gpio_temp = -1,
|
|
.adc_temp = -1,
|
|
.adc_temp_divider = -1,
|
|
};
|
|
|
|
static struct gpio collie_batt_gpios[] = {
|
|
{ COLLIE_GPIO_CO, GPIOF_IN, "main battery full" },
|
|
{ COLLIE_GPIO_MAIN_BAT_LOW, GPIOF_IN, "main battery low" },
|
|
{ COLLIE_GPIO_CHARGE_ON, GPIOF_OUT_INIT_LOW, "main charge on" },
|
|
{ COLLIE_GPIO_MBAT_ON, GPIOF_OUT_INIT_LOW, "main battery" },
|
|
{ COLLIE_GPIO_TMP_ON, GPIOF_OUT_INIT_LOW, "main battery temp" },
|
|
{ COLLIE_GPIO_BBAT_ON, GPIOF_OUT_INIT_LOW, "backup battery" },
|
|
};
|
|
|
|
#ifdef CONFIG_PM
|
|
static int collie_bat_suspend(struct ucb1x00_dev *dev)
|
|
{
|
|
/* flush all pending status updates */
|
|
flush_work(&bat_work);
|
|
|
|
if (device_may_wakeup(&dev->ucb->dev) &&
|
|
collie_bat_main.status == POWER_SUPPLY_STATUS_CHARGING)
|
|
wakeup_enabled = !enable_irq_wake(gpio_to_irq(COLLIE_GPIO_CO));
|
|
else
|
|
wakeup_enabled = 0;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int collie_bat_resume(struct ucb1x00_dev *dev)
|
|
{
|
|
if (wakeup_enabled)
|
|
disable_irq_wake(gpio_to_irq(COLLIE_GPIO_CO));
|
|
|
|
/* things may have changed while we were away */
|
|
schedule_work(&bat_work);
|
|
return 0;
|
|
}
|
|
#else
|
|
#define collie_bat_suspend NULL
|
|
#define collie_bat_resume NULL
|
|
#endif
|
|
|
|
static int collie_bat_probe(struct ucb1x00_dev *dev)
|
|
{
|
|
int ret;
|
|
struct power_supply_config psy_main_cfg = {}, psy_bu_cfg = {};
|
|
|
|
if (!machine_is_collie())
|
|
return -ENODEV;
|
|
|
|
ucb = dev->ucb;
|
|
|
|
ret = gpio_request_array(collie_batt_gpios,
|
|
ARRAY_SIZE(collie_batt_gpios));
|
|
if (ret)
|
|
return ret;
|
|
|
|
mutex_init(&collie_bat_main.work_lock);
|
|
|
|
INIT_WORK(&bat_work, collie_bat_work);
|
|
|
|
psy_main_cfg.drv_data = &collie_bat_main;
|
|
collie_bat_main.psy = power_supply_register(&dev->ucb->dev,
|
|
&collie_bat_main_desc,
|
|
&psy_main_cfg);
|
|
if (IS_ERR(collie_bat_main.psy)) {
|
|
ret = PTR_ERR(collie_bat_main.psy);
|
|
goto err_psy_reg_main;
|
|
}
|
|
|
|
psy_main_cfg.drv_data = &collie_bat_bu;
|
|
collie_bat_bu.psy = power_supply_register(&dev->ucb->dev,
|
|
&collie_bat_bu_desc,
|
|
&psy_bu_cfg);
|
|
if (IS_ERR(collie_bat_bu.psy)) {
|
|
ret = PTR_ERR(collie_bat_bu.psy);
|
|
goto err_psy_reg_bu;
|
|
}
|
|
|
|
ret = request_irq(gpio_to_irq(COLLIE_GPIO_CO),
|
|
collie_bat_gpio_isr,
|
|
IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
|
|
"main full", &collie_bat_main);
|
|
if (ret)
|
|
goto err_irq;
|
|
|
|
device_init_wakeup(&ucb->dev, 1);
|
|
schedule_work(&bat_work);
|
|
|
|
return 0;
|
|
|
|
err_irq:
|
|
power_supply_unregister(collie_bat_bu.psy);
|
|
err_psy_reg_bu:
|
|
power_supply_unregister(collie_bat_main.psy);
|
|
err_psy_reg_main:
|
|
|
|
/* see comment in collie_bat_remove */
|
|
cancel_work_sync(&bat_work);
|
|
gpio_free_array(collie_batt_gpios, ARRAY_SIZE(collie_batt_gpios));
|
|
return ret;
|
|
}
|
|
|
|
static void collie_bat_remove(struct ucb1x00_dev *dev)
|
|
{
|
|
free_irq(gpio_to_irq(COLLIE_GPIO_CO), &collie_bat_main);
|
|
|
|
power_supply_unregister(collie_bat_bu.psy);
|
|
power_supply_unregister(collie_bat_main.psy);
|
|
|
|
/*
|
|
* Now cancel the bat_work. We won't get any more schedules,
|
|
* since all sources (isr and external_power_changed) are
|
|
* unregistered now.
|
|
*/
|
|
cancel_work_sync(&bat_work);
|
|
gpio_free_array(collie_batt_gpios, ARRAY_SIZE(collie_batt_gpios));
|
|
}
|
|
|
|
static struct ucb1x00_driver collie_bat_driver = {
|
|
.add = collie_bat_probe,
|
|
.remove = collie_bat_remove,
|
|
.suspend = collie_bat_suspend,
|
|
.resume = collie_bat_resume,
|
|
};
|
|
|
|
static int __init collie_bat_init(void)
|
|
{
|
|
return ucb1x00_register_driver(&collie_bat_driver);
|
|
}
|
|
|
|
static void __exit collie_bat_exit(void)
|
|
{
|
|
ucb1x00_unregister_driver(&collie_bat_driver);
|
|
}
|
|
|
|
module_init(collie_bat_init);
|
|
module_exit(collie_bat_exit);
|
|
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_AUTHOR("Thomas Kunze");
|
|
MODULE_DESCRIPTION("Collie battery driver");
|