01294d8262
If two drivers are probing devices at the same time, both will write their match table result to the dev->of_match cache at the same time. Only write the result if the device matches. In a thread titled "SBus devices sometimes detected, sometimes not", Meelis reported his SBus hme was not detected about 50% of the time. From the debug suggested by Grant it was obvious another driver matched some devices between the call to match the hme and the hme discovery failling. Reported-by: Meelis Roos <mroos@linux.ee> Signed-off-by: Milton Miller <miltonm@bga.com> [grant.likely: modified to only call of_match_device() once] Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
67 lines
1.8 KiB
C
67 lines
1.8 KiB
C
#ifndef _LINUX_OF_DEVICE_H
|
|
#define _LINUX_OF_DEVICE_H
|
|
|
|
#include <linux/platform_device.h>
|
|
#include <linux/of_platform.h> /* temporary until merge */
|
|
|
|
#ifdef CONFIG_OF_DEVICE
|
|
#include <linux/device.h>
|
|
#include <linux/of.h>
|
|
#include <linux/mod_devicetable.h>
|
|
|
|
extern const struct of_device_id *of_match_device(
|
|
const struct of_device_id *matches, const struct device *dev);
|
|
extern void of_device_make_bus_id(struct device *dev);
|
|
|
|
/**
|
|
* of_driver_match_device - Tell if a driver's of_match_table matches a device.
|
|
* @drv: the device_driver structure to test
|
|
* @dev: the device structure to match against
|
|
*/
|
|
static inline int of_driver_match_device(struct device *dev,
|
|
const struct device_driver *drv)
|
|
{
|
|
const struct of_device_id *match;
|
|
|
|
match = of_match_device(drv->of_match_table, dev);
|
|
if (match)
|
|
dev->of_match = match;
|
|
return match != NULL;
|
|
}
|
|
|
|
extern struct platform_device *of_dev_get(struct platform_device *dev);
|
|
extern void of_dev_put(struct platform_device *dev);
|
|
|
|
extern int of_device_add(struct platform_device *pdev);
|
|
extern int of_device_register(struct platform_device *ofdev);
|
|
extern void of_device_unregister(struct platform_device *ofdev);
|
|
|
|
extern ssize_t of_device_get_modalias(struct device *dev,
|
|
char *str, ssize_t len);
|
|
|
|
extern int of_device_uevent(struct device *dev, struct kobj_uevent_env *env);
|
|
|
|
static inline void of_device_node_put(struct device *dev)
|
|
{
|
|
of_node_put(dev->of_node);
|
|
}
|
|
|
|
#else /* CONFIG_OF_DEVICE */
|
|
|
|
static inline int of_driver_match_device(struct device *dev,
|
|
struct device_driver *drv)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static inline int of_device_uevent(struct device *dev,
|
|
struct kobj_uevent_env *env)
|
|
{
|
|
return -ENODEV;
|
|
}
|
|
|
|
static inline void of_device_node_put(struct device *dev) { }
|
|
|
|
#endif /* CONFIG_OF_DEVICE */
|
|
|
|
#endif /* _LINUX_OF_DEVICE_H */
|