Uwe Kleine-König
aec563b4f0
staging/trivial: fix typos concerning "address"
...
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-02-18 13:30:09 -08:00
Marek Belisko
bcd2d92e62
staging: ft1000: Remove unnecessary check in write_blk_fifo().
...
byte_length = word_length * 4;
if (byte_length % 4) ...
word_length * 4 is always aligned at 4 bytes. Remove pointless
check.
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-02-09 14:55:51 -08:00
Marek Belisko
677aaa4306
staging: ft1000: Fix coding style in card_reset_dsp function.
...
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-02-09 14:55:51 -08:00
Marek Belisko
8bfef50259
staging: ft1000: Fix coding style in fix_ft1000_write_dpram32 fucntion.
...
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-02-09 14:55:51 -08:00
Marek Belisko
71e3335d55
staging: ft1000: Fix coding style in fix_ft1000_read_dpram32 function.
...
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-02-09 14:55:51 -08:00
Marek Belisko
460bd5ddab
staging: ft1000: Fix coding style in ft1000_read/write_dpram16 functions.
...
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-02-09 14:55:50 -08:00
Marek Belisko
e3fc923d4d
staging: ft1000: Fix coding style in ft1000_read/write_dpram32 functions.
...
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-02-09 14:55:50 -08:00
Marek Belisko
31da7c09de
staging: ft1000: Fix coding style in ft1000_write/read_register functions.
...
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-02-09 14:55:50 -08:00
Marek Belisko
4a526fca84
staging: ft1000: Fix return values type.
...
Change return values type from u16 to int because all functions
use ft1000_control function which return int.
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-02-09 14:55:49 -08:00
Marek Belisko
dc080fdaca
staging: ft1000: Remove unused header ft1000_hw.h
...
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-02-09 14:55:49 -08:00
Marek Belisko
537a20aba6
staging: ft1000: Fix coding style in ft1000_control function.
...
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-02-09 14:55:49 -08:00
Marek Belisko
dfc9539fe8
staging: ft1000: Remove unnecessary assignment.
...
dsp_img_info->version and requested_version have same type
so additional temporary variable creation could be omitted
because variables could be compares directly.
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-02-04 12:43:44 -08:00
Marek Belisko
e7af078630
staging: ft1000: Create common function for buffers check.
...
Same check was done on three places which make code unreadable.
Put repeat routine to separate function.
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-02-04 12:43:43 -08:00
Marek Belisko
672dfeba92
staging: ft1000: Remove unused variables.
...
Remove variables which was defined and assigned
but never used in function.
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-02-04 12:43:43 -08:00
Marek Belisko
6f953fbbf6
staging: ft1000: Fix indentation in scram_dnldr() function.
...
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-02-04 12:43:43 -08:00
Marek Belisko
857af455c8
staging: ft1000: Fix coding style in write_blk_fifo() function.
...
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-02-04 12:43:43 -08:00
Marek Belisko
d7a7318b38
staging: ft1000: Fix coding style in get_handshake() function.
...
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-02-04 12:43:42 -08:00
Marek Belisko
78395f672a
staging: ft1000: Fix coding style in hdr_checksum() function.
...
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-02-04 12:43:42 -08:00
Marek Belisko
cc4f65bfbf
staging: ft1000: Fix coding style in put_request_value() function.
...
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-02-04 12:43:42 -08:00
Marek Belisko
114a06ae84
staging: ft1000: Fix coding style in get_request_value() function.
...
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-02-04 12:43:41 -08:00
Marek Belisko
c3ed5d2f25
staging: ft1000: Fix coding style in get_request_type_usb() function.
...
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-02-04 12:43:41 -08:00
Marek Belisko
9b43f37468
staging: ft1000: Fix coding style in get_request_type() function.
...
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-02-04 12:43:41 -08:00
Marek Belisko
5acc5396af
staging: ft1000: Fix coding style in put_handshake_usb() function.
...
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-02-04 12:43:41 -08:00
Marek Belisko
5865a18eaa
staging: ft1000: Fix coding style in get_handshake_usb() function.
...
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-02-04 12:43:40 -08:00
Marek Belisko
a8d4d198a7
staging: ft1000: Fix coding style in put_handshake() function.
...
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-02-04 12:43:40 -08:00
Marek Belisko
c5d680c058
staging: ft1000: Fix coding style in check_usb_db() function.
...
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-02-04 12:43:40 -08:00
Marek Belisko
165d290f8a
staging: ft1000: Remove dead code.
...
Remove code which was under #if 0.
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-02-04 12:43:40 -08:00
Jesper Juhl
7bd74cd0e5
Staging: FT1000: remove duplicate inc of linux/slab.h
...
linux/slab.h is included twice in ft1000_dnld.c - remove duplicate.
Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-01-21 12:31:47 -08:00
Marek Belisko
c331e766f9
staging: ft1000-pcmcia: Fix compilation errors.
...
Following patch will fix all compilation errors. Main problems
was with pcmcia API changes. Also remove BROKEN as now driver
is properly build.
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Stano Lanci <chl.pixo@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2011-01-20 15:59:03 -08:00
Marek Belisko
91cda632eb
staging: ft1000: Fix kernel panic when use ioctl.
...
During ioctl testing was observed kernel panic beuase
file->private_data pointer was not correctly set when
debugfs file was created. Add correct pointer setup.
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-12-16 12:20:05 -08:00
Marek Belisko
0ce72ea3b2
staging: ft1000: Fix camelcase variable names.
...
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-12-16 12:20:05 -08:00
Marek Belisko
c346541f3d
staging: ft1000: Rename ft1000_chdev.c to ft1000_debug.c.
...
Name of old file was misleading because it is currently
updated to debugfs so change also file name.
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-12-16 12:18:25 -08:00
Marek Belisko
dab56ffe9a
staging: ft1000: Fix camelcase function names.
...
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-12-16 12:18:25 -08:00
Marek Belisko
448d401401
staging: ft1000: Always extract device number from netdev name.
...
Using gCardIndex as global variable was not correctly used because
for every plugged device was set to 0 in init_ft1000_netdev.
Remove global definition. Use it locally and for every plugged
device extract number from net device name.
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-12-13 10:25:54 -08:00
Greg Kroah-Hartman
64d74c6cbe
Staging: ft1000: fix world writable debugfs file
...
You should not be able to write to a debugfs file from any user.
Cc: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-12-10 10:55:27 -08:00
Marek Belisko
c5e61563e2
staging: ft1000: Add file header to ft1000_proc.c
...
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-12-09 16:35:15 -08:00
Marek Belisko
e2398c6127
staging: ft1000: Remove dead code.
...
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-12-09 16:35:15 -08:00
Marek Belisko
96ff77f735
staging: ft1000: Fix coding style.
...
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-12-09 16:35:14 -08:00
Marek Belisko
85d47cff4e
staging: ft1000: Coding style fix in ft1000ReadProc.
...
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-12-09 16:35:14 -08:00
Marek Belisko
92914cc8bb
staging: ft1000: Fix coding style in ft1000NotifyProc.
...
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-12-09 16:35:14 -08:00
Marek Belisko
1c46282421
staging: ft1000: Use return value for ft1000InitProc.
...
Add checking for return value ft1000InitProc and cleanup
if something fail.
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-12-09 16:35:13 -08:00
Marek Belisko
04c6620117
staging: ft1000: Fix coding style.
...
Fix coding style in ft1000CleanupProc and ft1000InitProc
functions.
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-12-09 16:35:13 -08:00
Marek Belisko
5fd866fb64
staging: ft1000: Fix proc initialization handling.
...
Cleaning proc entries when error occures was not handled correctly.
So fix and also add proper cleaning.
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-12-09 16:35:13 -08:00
Marek Belisko
115884118a
staging: ft1000: Fix debug messages.
...
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-12-09 16:34:33 -08:00
Marek Belisko
05371d1861
staging: ft1000: Remove unused headers.
...
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-12-09 16:34:33 -08:00
Marek Belisko
c82632d247
staging: ft1000: Remove dead code.
...
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-12-09 16:34:32 -08:00
Marek Belisko
4d791234f4
staging: ft1000: Fix camelcase functions and variables.
...
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-12-09 16:34:32 -08:00
Marek Belisko
67e9f9e26b
staging: ft1000: Remove unused variable.
...
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-12-09 16:34:32 -08:00
Marek Belisko
e34dc580dc
staging: ft1000: Remove unused pdevobj array.
...
We don't need to store pointer to device in some local
array because we always pass to debugfs correct device pointer.
So remove it.
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-12-09 16:34:31 -08:00
Marek Belisko
6d96940b2d
staging: ft1000: Fix private data pointer usage.
...
Assign private data pointer to device for usage in file operations.
Signed-off-by: Marek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
2010-12-09 16:34:31 -08:00