Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

tools: PCI: Fix broken pcitest compilation

Browse source 
[ Upstream commit 8a5e0af240e07dd3d4897eb8ff52aab757da7fab ]

pcitest is currently broken due to the following compiler error
and related warning. Fix by changing the run_test() function
signature to return an integer result.

pcitest.c: In function run_test:
pcitest.c:143:9: warning: return with a value, in function
returning void
  return (ret < 0) ? ret : 1 - ret; /* return 0 if test succeeded */

pcitest.c: In function main:
pcitest.c:232:9: error: void value not ignored as it ought to be
  return run_test(test);

Fixes: fef31ecaaf2c ("tools: PCI: Fix compilation warnings")
Signed-off-by: Alan Mikhak <alan.mikhak@sifive.com>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Reviewed-by: Paul Walmsley <paul.walmsley@sifive.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Alan Mikhak 2019-05-23 14:18:00 -07:00 committed by Greg Kroah-Hartman
parent 4039b5dd0f
commit ff36ace6c1
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
tools/pci/pcitest.c
View file

@ -47,15 +47,15 @@ struct pci_test {
unsigned long size; unsigned long size;
}; };
static void run_test(struct pci_test *test) static int run_test(struct pci_test *test)
{ {
long ret; int ret = -EINVAL;
int fd; int fd;
fd = open(test->device, O_RDWR); fd = open(test->device, O_RDWR);
if (fd < 0) { if (fd < 0) {
perror("can't open PCI Endpoint Test device"); perror("can't open PCI Endpoint Test device");
return; return -ENODEV;
} }
if (test->barnum >= 0 && test->barnum <= 5) { if (test->barnum >= 0 && test->barnum <= 5) {