Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

ALSA: vx_core: off by one in vx_read_status()

Browse source 
This code is older than git, and I haven't tested it, but if size ==
SIZE_MAX_STATUS then we would write one space past the end of the
rmh->Stat[] array.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Dan Carpenter 2013-06-21 15:25:33 +03:00 committed by Takashi Iwai
parent 88d5760649
commit fefe228c5f
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
sound/drivers/vx/vx_core.c
View file

@ -205,7 +205,7 @@ static int vx_read_status(struct vx_core *chip, struct vx_rmh *rmh)
if (size < 1) if (size < 1)
return 0; return 0;
if (snd_BUG_ON(size > SIZE_MAX_STATUS)) if (snd_BUG_ON(size >= SIZE_MAX_STATUS))
return -EINVAL; return -EINVAL;
for (i = 1; i <= size; i++) { for (i = 1; i <= size; i++) {