Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

mpi/mpi-mpow: NULL dereference on allocation failure

Browse source 
We can't call mpi_free() on the elements if the first kzalloc() fails.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Dmitry Kasatkin <dmitry.kasatkin@intel.com>
Signed-off-by: James Morris <jmorris@namei.org>
This commit is contained in:
Dan Carpenter 2011-12-07 13:58:26 +02:00 committed by James Morris
parent de35353375
commit fe0e94c5a7
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
lib/mpi/mpi-mpow.c
View file

@ -73,7 +73,7 @@ int mpi_mulpowm(MPI res, MPI *basearray, MPI *exparray, MPI m)
G = kzalloc((1 << k) * sizeof *G, GFP_KERNEL); G = kzalloc((1 << k) * sizeof *G, GFP_KERNEL);
if (!G) if (!G)
goto nomem; goto err_out;
/* and calculate */ /* and calculate */
tmp = mpi_alloc(mpi_get_nlimbs(m) + 1); tmp = mpi_alloc(mpi_get_nlimbs(m) + 1);
@ -129,5 +129,6 @@ int mpi_mulpowm(MPI res, MPI *basearray, MPI *exparray, MPI m)
for (i = 0; i < (1 << k); i++) for (i = 0; i < (1 << k); i++)
mpi_free(G[i]); mpi_free(G[i]);
kfree(G); kfree(G);
err_out:
return rc; return rc;
} }