Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

[SCSI] sg: remove unnecessary check

Browse source 
coverity spotted this (cid #758).  All callers dereference sfp, so we dont
need this check.  In addition to this, we dereference it earlier in the
function.

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Acked-by: Douglas Gilbert <dougg@torque.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
This commit is contained in:
Eric Sesterhenn 2007-05-23 14:41:36 -07:00 • committed by James Bottomley
parent deff2627cd
commit fb119935e1
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/scsi/sg.c
View file

@ -1842,7 +1842,7 @@ sg_build_indirect(Sg_scatter_hold * schp, Sg_fd * sfp, int buff_size)
int blk_size = buff_size; int blk_size = buff_size;
struct page *p = NULL; struct page *p = NULL;
if ((blk_size < 0) || (!sfp)) if (blk_size < 0)
return -EFAULT; return -EFAULT;
if (0 == blk_size) if (0 == blk_size)
++blk_size; /* don't know why */ ++blk_size; /* don't know why */