Techwizz/kernel-fxtec-pro1x
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

xdp: sample: Missing curly braces in read_route()

Browse source 
The assert statement is supposed to be part of the else branch but the
curly braces were accidentally left off.

Fixes: 3e29cd0e65 ("xdp: Sample xdp program implementing ip forward")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Dan Carpenter 2017-11-14 09:12:03 +03:00 committed by David S. Miller
parent 4e6759be28
commit fae45363ae
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
samples/bpf/xdp_router_ipv4_user.c
View file

@ -206,12 +206,13 @@ static void read_route(struct nlmsghdr *nh, int nll)
direct_entry.arp.mac = 0; direct_entry.arp.mac = 0;
direct_entry.arp.dst = 0; direct_entry.arp.dst = 0;
if (route.dst_len == 32) { if (route.dst_len == 32) {
if (nh->nlmsg_type == RTM_DELROUTE) if (nh->nlmsg_type == RTM_DELROUTE) {
assert(bpf_map_delete_elem(map_fd[3], &route.dst) == 0); assert(bpf_map_delete_elem(map_fd[3], &route.dst) == 0);
else } else {
if (bpf_map_lookup_elem(map_fd[2], &route.dst, &direct_entry.arp.mac) == 0) if (bpf_map_lookup_elem(map_fd[2], &route.dst, &direct_entry.arp.mac) == 0)
direct_entry.arp.dst = route.dst; direct_entry.arp.dst = route.dst;
assert(bpf_map_update_elem(map_fd[3], &route.dst, &direct_entry, 0) == 0); assert(bpf_map_update_elem(map_fd[3], &route.dst, &direct_entry, 0) == 0);
}
} }
for (i = 0; i < 4; i++) for (i = 0; i < 4; i++)
prefix_key->data[i] = (route.dst >> i * 8) & 0xff; prefix_key->data[i] = (route.dst >> i * 8) & 0xff;